Skip to content

fix: shard pull request domain mutation testing - #729

Merged
thomasluizon merged 1 commit into
mainfrom
thomasluizon/ticket-1492-mutation-pr-shards
Oct 17, 2026
Merged

thomasluizon merged 1 commit into
mainfrom
thomasluizon/ticket-1492-mutation-pr-shards

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Closes thomasluizon/orbit-tickets#1492

Pull requests now split domain mutation testing into domain-habit-freeze and domain-user-invariants, using the same file patterns and available-core concurrency as nightly runs. This keeps each domain shard within the existing mutation scope while retaining --since:origin/main on the PR path.

The change is confined to .github/workflows/mutation.yml. A shared YAML matrix replaces the event-specific JSON matrix so PR, scheduled, and manual runs use the same four jobs. The PR step reuses the nightly argument construction to pass each shard's quoted --mutate patterns and --concurrency from nproc. Application and infrastructure retain their job names and configured mutation scope. The 45-minute timeout and mutation thresholds stay unchanged.

External interface evidence

Restored the manifest's Stryker.NET 4.16.0 with dotnet tool restore and read its installed NuGet package metadata, which identifies source commit f9109e24c615a7030a3b33e5532c665c974e4ec5. Read the source at that exact commit before changing the workflow:

  • ConfigBuilder loads file configuration before CLI options. CommandLineConfigReader replaces the mutate input with repeated CLI values, parses --since:origin/main, and accepts integer concurrency.
  • MutantFilterFactory enables both file-pattern and since filters. BroadcastMutantFilter passes only remaining mutants to each subsequent filter, enforcing shard boundaries alongside diff selection. SinceMutantFilter retains Stryker's existing changed-source and changed-test behavior within that scope.

Test evidence

  • dotnet build Orbit.slnx: exit 0, zero errors; existing package and obsolete-API warnings.
  • dotnet test: exit 0; 7,150 passed, zero failed or skipped across analyzer, domain, application, and infrastructure suites.
  • actionlint .github/workflows/mutation.yml: exit 0 before and after the change. The unchanged lint check does not detect missing PR shards; no existing workflow behavior test covers that defect.
  • The matrix regression probe below exits 1 against the parent workflow with PR matrix is not shared with nightly, then exits 0 against the fixed workflow:
check='job = YAML.load(STDIN.read).fetch("jobs").fetch("mutation"); matrix = job.fetch("strategy").fetch("matrix").fetch("include"); abort "PR matrix is not shared with nightly" unless matrix.is_a?(Array); abort "Unexpected mutation jobs" unless matrix.map { |entry| entry["shard"] || entry["project"] } == %w[domain-habit-freeze domain-user-invariants application infrastructure]'
git show HEAD^:.github/workflows/mutation.yml | ruby -ryaml -e "$check"
ruby -ryaml -e "$check" < .github/workflows/mutation.yml

A temporary Ruby/Bash probe also parsed the workflow and executed its actual Stryker step bodies with argument capture for all four jobs under pull_request, schedule, and workflow_dispatch. All 12 checks passed, including literal shard glob arguments, PR-only since selection, explicit concurrency, empty application/infrastructure overrides, stable naming, and the 45-minute timeout. No permanent test file was added for this workflow-only change.

Mutation CI completion, the post-merge run for orbit-api#723, and propagation through #746 remain for the orchestrator to verify. No CI waiting or merge was performed by this worker.

Assumptions

  • Use the existing nightly shard names on PRs instead of retaining a separate Mutation (domain) job; this preserves the naming convention and the application/infrastructure names while exposing both required domain shards.

@sonarqubecloud

Copy link
Copy Markdown

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes in .github/workflows/mutation.yml, including shard coverage, CLI argument construction, and event-specific execution.

  • Shared matrix: Pull requests now use the same two domain shards as scheduled and manual runs, with application and infrastructure entries preserved.
  • Scoped PR execution: Repeated, quoted --mutate arguments and explicit concurrency retain --since:origin/main; the domain patterns exactly partition the existing configured scope.
  • Verification: All 12 event/job shell argument probes passed. Checked the cited Stryker source to confirm CLI override behavior and cumulative shard/since filtering. Full mutation runtime was not reproduced locally.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@thomasluizon
thomasluizon merged commit bcfd81e into main Oct 17, 2026
27 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/ticket-1492-mutation-pr-shards branch October 17, 2026 17:30
thomasluizon added a commit that referenced this pull request Oct 18, 2026
* fix: pin analyzer test Pkcs dependency to patched version (#728)

(cherry picked from commit 61b0090)

* fix: shard pull request domain mutation testing (#729)

(cherry picked from commit bcfd81e)

* Promote the API redesign with production compatibility checks (#723)

* Bring the API redesign tree onto main for #1413

* Preserve calendar connection detection for shipped clients

* Prove API and migrated schema compatibility with shipped clients

* Trim whitespace in the archived main schema proof

* Require the production health response to report the released commit

* Bind initial approval previews to stored pending operations

* fix: return the bulk skip refresh outcome and split the undo skip query

SonarCloud failed the quality gate on two reliability findings in code this pull request brings to main:
the bulk skip conflict check read a flag only a lambda wrote (S2583), and the undo skip check loaded
Tags and Goals in one query (S8733). The transaction now returns whether every habit refreshed, and the
undo skip check splits its query. A new case covers the concurrent change conflict; it failed with the
refresh outcome forced to true and passes with the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 5526c9b)

* Add per-account feature flag targeting and admin controls (#724)

* feat: resolve feature flags per account

* feat: administer account feature flags through MCP and REST

* test: exclude feature flag targets from rate limit fixture

* fix: reconcile account flag tests and migration metadata with redesign

(cherry picked from commit 1b886bd)

* Add header API versioning for v1 and v2 (#733)

* Add header API versioning with v1 compatibility

* Verify versioned OpenAPI and browser header compatibility

* Preserve skip undo path contract with optional version header

(cherry picked from commit ac8b34a)

* fix: expose the config response in OpenAPI (#734)

(cherry picked from commit a9d8dd5)

* Route production redesign accounts through Cloudflare (#735)

* Add cookie-based routing for the production redesign web service

* Document web routing rollout, permissions, and rollback checks

* Fix web routing coverage and disable infra install scripts

* chore: regenerate the v2 OpenAPI document on main

orbit-api#733 added openapi_v2.json and orbit-api#734 typed the /api/config
response in parallel, so main carries a v2 document without the typed config
schema and the Build check's stale-document step fails on every merge with
main. dotnet build src/Orbit.Api regenerates it; openapi.json is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 9c64770)

* Fix habit edit gating, end dates, and reminder updates (#736)

* fix: validate habit updates with the resulting time range

* fix: preserve end dates when creating root habits

* fix: gate slip alert activation and preserve unchanged reminders

* fix: compare effective reminder rules across stored formats

(cherry picked from commit 7472203)

* Reduce mutation and guard CI jobs (#737)

* Select mutation shards from changed projects

* Consolidate guards and filter artifact generation

* Skip project documentation in mutation selection

* Validate mutation base refs and restrict Git PATH

* Read mutation shard changes from standard input

(cherry picked from commit b802f9e)

* test: strengthen habit and goal ownership coverage (#739)

(cherry picked from commit 0e32628)

* test: verify checkout session user metadata (#740)

(cherry picked from commit da2f53a)

* fix: protect OAuth code delivery with Turnstile (#741)

(cherry picked from commit 1149606)

* fix: enforce chat interaction scope before loading context (#743)

(cherry picked from commit 98faf4e)

* fix: erase accountability pairs during account deletion and reset (#745)

* fix: erase accountability pairs during account deletion and reset

* test: preserve migration compatibility checks after accountability cleanup

(cherry picked from commit a9e5fb9)

* Fix goal sync dates and deadline reminder counts (#747)

* fix: compare streak sync dates in the user timezone

* fix: show actual days remaining in goal deadline reminders

* test: configure timezone for streak scheduler fixtures

(cherry picked from commit 0e63842)

* Manage staging landing routing in Terraform (#742)

(cherry picked from commit abdd738)

* Restrict Web Push endpoints to supported push services (#1503) (#751)

Web Push subscriptions accept only HTTPS endpoints on the FCM, Mozilla, Apple and WNS push hosts, and the push HTTP client follows no redirects. Replaces orbit-api#748 as one commit so no commit carries the high-entropy sample fixture.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit d9f847a)

* Erase account uploads before permanent deletion (#1507) (#750)

* fix: erase uploaded objects before completing account deletion

* fix: refuse upload reads after permanent account deletion

* fix: grant uploads bucket deletion permissions and verify provider wiring

* test: align storage startup checks with erasure requirements

* fix: retire deleted Supabase upload storage

* test: configure upload erasure providers in deletion fixtures

Share the existing object-store fake across account deletion and scheduler fixtures after merging main. Preserve accountability assertions and production provider requirements for thomasluizon/orbit-tickets#1507.

(cherry picked from commit fa33a94)

* fix: limit anonymous auth and waitlist by email and source IP (ORB-108) (#749)

* fix: enforce source IP ceilings alongside anonymous email limits

* test: cover both rate limit dimensions before bot verification

* fix: isolate BFF email rate limits by verified client IP

* fix: generate and persist BFF forwarding secrets

(cherry picked from commit de0f42f)

* Limit access tokens to fifteen minutes (#738)

* fix(auth): limit access tokens to fifteen minutes

* fix(auth): align managed JWT lifetime and prove logout rejection

(cherry picked from commit ade7016)

* fix(auth): equalize account provisioning work (ORB-96) (#744)

* test(auth): expose registration dependent sign-in work

* fix(auth): perform uniform registration work before sign-in responses

* test(auth): cover expired codes and tracked upsert conflicts

* fix(auth): isolate signup retries and restore provisioning guards

* fix(auth): recover signup work after dispatch failures

* fix(auth): roll back failed signup referrals before retry

(cherry picked from commit 1bd0d26)

* fix: expose redesign controllers in both API versions

Apply the carried version declarations to the Notion and proactive controllers and regenerate the v2 contract. Refs thomasluizon/orbit-tickets#746.

* fix: honor account flags in proactive engine

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant