[thomasluizon]

Fixes thomasluizon/orbit-tickets#1515

A streak synced at 23:30 in UTC-3 can now sync and complete on the next local day. A first catch-up reminder for a goal due tomorrow now says "due tomorrow" instead of "due in 7 days".

Approach

• GoalStreakSyncService.cs converts StreakSyncedAtUtc into the owner's timezone before comparing calendar dates. GoalCompletionService.cs resolves that timezone once per passive batch through IUserDateService.GetUserTimeZoneAsync, implemented in UserDateService.cs using the existing cached preferences and timezone fallback.
• GoalDeadlineNotificationService.cs formats push and in-app bodies with the actual days remaining. Milestone values still identify dedupe keys, and the existing return after one notification preserves the per-goal, per-tick limit.
• GoalStreakSyncServiceTests.cs covers both sides of local midnight in UTC-3 and UTC+14. GoalCompletionServiceTests.cs exercises persisted completion and its reward call through the real date service. GoalDeadlineNotificationServiceTests.cs checks one, two and five days remaining, the persisted body and the milestone key. StreakGoalSyncServiceTests.cs supplies the new timezone method in its existing UTC fixture.

The build regenerated the OpenAPI documents without changing their contents.

Assumptions

• Expose the resolved timezone through the existing IUserDateService dependency rather than add a user repository dependency to goal completion; this reuses the current preference cache and timezone fallback.

Test evidence

Existing tests were run unchanged with both defects present:

dotnet test tests/Orbit.Application.Tests --filter 'FullyQualifiedName~GoalStreakSyncServiceTests'
dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~GoalDeadlineNotificationServiceTests|FullyQualifiedName~GoalCompletionServiceTests'

Both exited 0: 18 and 48 tests passed respectively. This included NeedsPassiveSync_SyncedBeforeUserToday_ReturnsTrue and the unchanged CheckAndSendDeadlineNotifications_MissedSevenDayTick_StillSendsHighestCrossedMilestone; their existing assertions did not catch these defects.

Before fixing each implementation:

dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~SyncDerivedGoals_PassiveSyncAfterLateSaoPauloSync'
dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~CheckAndSendDeadlineNotifications_MissedSevenDayTick'

The new SyncDerivedGoals_PassiveSyncAfterLateSaoPauloSync_CompletesNextLocalDay exited 1: the expected completion update was absent after a sync at 02:30 UTC, which was 23:30 on the previous local day. The strengthened existing deadline test exited 1 with all three cases failing: each captured "due in 7 days", including the goal due tomorrow.

After the fixes:

dotnet test tests/Orbit.Application.Tests --no-build --filter 'FullyQualifiedName~GoalStreakSyncServiceTests'
dotnet test tests/Orbit.Infrastructure.Tests --no-build --filter 'FullyQualifiedName~GoalCompletionServiceTests|FullyQualifiedName~UserDateServiceTests'
dotnet test tests/Orbit.Infrastructure.Tests --no-build --filter 'FullyQualifiedName~GoalDeadlineNotificationServiceTests'

All exited 0: 22, 22 and 38 tests passed. These runs include both previously failing regressions.

The first broader infrastructure run exposed an unconfigured timezone method in the existing scheduler test double. After supplying UTC for its users without timezone settings, this focused run exited 0 with 10 tests passed:

dotnet test tests/Orbit.Infrastructure.Tests --filter 'FullyQualifiedName~StreakGoalSyncServiceTests'

Final validation:

dotnet build Orbit.slnx
dotnet test tests/Orbit.Domain.Tests --no-build
dotnet test tests/Orbit.Application.Tests --no-build
dotnet test tests/Orbit.Infrastructure.Tests --no-build
dotnet test tests/Orbit.Analyzers.Tests --no-build

Build exited 0 with zero errors and existing warnings. All test projects exited 0: Domain 671, Application 5,489, Infrastructure 3,360 and Analyzers 32; 9,552 passed, none failed or skipped. Commit hooks passed, and changed files contain no bare narration comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pullfrog]

✅ No new issues found.

Reviewed changes Across all nine changed files, reviewed local-date streak synchronization, deadline reminder wording, and the affected callers and tests.

• Local sync dates: Passive reconciliation converts the saved UTC sync timestamp into the owner's timezone, resolved once per batch through the existing date preferences cache and fallback.
• Deadline reminders: Push and persisted notification bodies show actual days remaining while retaining milestone dedupe keys and the existing per-tick limit.
• Regression coverage: Tests cover UTC-3 and UTC+14 day boundaries, persisted completion and its reward call, catch-up reminder bodies, and the scheduler fixture update. All 92 focused tests passed; the full solution suite was not rerun during this review.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}