[thomasluizon]

Closes thomasluizon/orbit-tickets#1514

Free accounts can save ordinary habit edits even when shipped clients send slipAlertEnabled: false. Enabling slip alerts still requires Pro. Root habits retain their requested end date, unchanged reminder schedules preserve sent rows, and clearing an end time validates the resulting time range.

Changes

• src/Orbit.Application/Habits/Commands/UpdateHabitCommand.cs: check slip alert activation after loading the owned habit under the existing update lock. Compare due time, reminder enablement, and effective reminder rule sets before and after the domain update. This accounts for legacy clock fields, relative rules, ordering, and duplicate offsets across fields before deciding to clear today's sent rows.
• src/Orbit.Application/Habits/Commands/CreateHabitCommand.cs: pass EndDate into root creation, matching the child path and retaining domain validation.
• src/Orbit.Domain/Entities/Habit.cs: validate the same replacement time values that the update assigns.
• Regression coverage stays in the existing application handler and domain entity test files. The request and response contracts stay compatible with shipped clients.

Test evidence

Before changing tests or implementation, these commands passed with all four defects present:

dotnet test tests/Orbit.Application.Tests --filter 'FullyQualifiedName~UpdateHabitCommandHandlerTests|FullyQualifiedName~CreateHabitCommandHandlerTests' --verbosity quiet
dotnet test tests/Orbit.Domain.Tests --filter FullyQualifiedName~HabitTests --verbosity quiet

The application run passed 45 tests, including Handle_ValidCommand_UpdatesAndSaves, Handle_ValidCommand_CreatesHabitAndSaves, Handle_DueTimeChanged_ClearsSentReminder, and Handle_TimedHabitScheduledReminderEdit_SavesFoldedClockReminder. The domain run passed 157 tests, including Update_AllOptionalFields_Applied and Update_DueEndTimeBeforeDueTime_ReturnsFailure. Those cases did not exercise the failing payloads.

With the strengthened root-create test and new regression theories, before any production fix:

dotnet test tests/Orbit.Application.Tests --filter 'FullyQualifiedName~UpdateHabitCommandHandlerTests|FullyQualifiedName~CreateHabitCommandHandlerTests' --verbosity quiet
dotnet test tests/Orbit.Domain.Tests --filter FullyQualifiedName~HabitTests --verbosity normal

The application run failed 9 of 63 cases; the domain run failed 1 of 162. Each failure was observed before its fix:

Defect	Regression and red observation	Green observation
Slip alert gate	Handle_SlipAlerts_OnlyEnablingRequiresPro: free edits sending false, disabling alerts, and leaving true unchanged failed the success assertion.	All 7 cases pass, including denied activation without Pro, successful activation with Pro, and no gate call for unchanged, false, or omitted values.
Root end date	Strengthened Handle_ValidCommand_CreatesHabitAndSaves: no added root matched the requested end date.	The root passed to AddAsync carries the requested end date.
Reminder reset	Handle_ReminderSchedule_ClearsSentRowsOnlyWhenChanged: unchanged, reordered, and equivalent clock payloads incorrectly removed a sent row; clearing due time failed to remove it. Handle_UntimedReminderSchedule_ClearsSentRowsOnlyWhenChanged failed to clear after a clock change.	All final reminder cases pass, covering changed due time, clearing time, reminder enablement, offsets, relative rules, and clocks. Yesterday's rows and another habit's rows remain intact.
Time validation	Update_TimeRange_ValidatesResultingValues: moving the start from 09:00 to 11:00 while clearing the old 10:00 end failed the success assertion.	All 5 cases pass, including clearing both times, setting a valid end, and rejecting an invalid range without mutation.

After the first reminder fix, the existing 9 reminder theory cases passed. Adding the offset-equivalent case exposed an unnecessary reset when two fields described the same reminder. This command failed 1 of 10 cases with an unexpected Remove call. After comparing effective rules, the same theory passes within the final 37 update-handler cases:

dotnet test tests/Orbit.Application.Tests --filter FullyQualifiedName~Handle_ReminderSchedule_ClearsSentRowsOnlyWhenChanged --logger 'console;verbosity=normal'

Focused compilation and green checks before the corresponding commits:

dotnet test tests/Orbit.Domain.Tests --filter FullyQualifiedName~HabitTests --verbosity quiet
dotnet test tests/Orbit.Application.Tests --filter FullyQualifiedName~CreateHabitCommandHandlerTests --verbosity quiet
dotnet test tests/Orbit.Application.Tests --filter FullyQualifiedName~UpdateHabitCommandHandlerTests --verbosity quiet

Results: 162 domain cases, 27 create-handler cases, and 37 final update-handler cases passed.

Final verification:

dotnet build Orbit.slnx --verbosity quiet
dotnet test tests/Orbit.Domain.Tests --verbosity quiet
dotnet test tests/Orbit.Application.Tests --verbosity quiet
dotnet test tests/Orbit.Infrastructure.Tests --verbosity quiet
dotnet test --no-build --verbosity quiet

• Solution build: exit 0, zero errors, 19 warnings in untouched files and package dependencies. Generated OpenAPI documents have no diff.
• Domain suite: exit 0, 671 passed.
• Application suite: exit 0, 5,485 passed.
• Infrastructure suite: exit 0, 3,357 passed.
• Full solution test run: exit 0, 9,545 passed across all four projects, including 32 analyzer tests.
• Final focused regressions: 20 application cases and 5 domain cases passed after the final build.
• Git hooks passed on each commit. Diff whitespace, dash, timeless prose, suppression, and added-comment checks passed.

Assumptions

• Preserve the existing replacement semantics for DueTime and DueEndTime: null clears each time. Rejected treating null as keep, because the domain update assigns null.
• Compare reminder rules by their effective values, ignoring order and duplicate offsets across fields. Rejected comparing raw request lists, because the scheduler combines and deduplicates those rules.

Manual steps

• After merge and the owner's explicit release approval, use GitHub Actions > Release API (.github/workflows/release.yml) in thomasluizon/orbit-api. Dispatch from main with environment=production and branch=main. The workflow's Verify API health and live commit step must succeed for the released commit; verify an ordinary free-account edit succeeds with slipAlertEnabled: false. Production release was left for the owner as required by the ticket.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pullfrog]

✅ No new issues found.

Reviewed changes across all six changed files, including domain guards, transaction boundaries, reminder scheduling, and the sibling client's request builders; no High or Critical regressions found.

• Slip-alert activation gate: Requires Pro only when enabling previously disabled alerts, allowing ordinary free-account edits and alert disablement.
• Root habit end dates: Passes the requested end date into root creation and retains domain validation.
• Reminder deduplication: Preserves sent rows for unchanged effective schedules while detecting due-time, enablement, offset, and clock-rule changes across stored formats.
• Replacement time validation: Validates the time values actually assigned, allowing end-time clearing without comparing against the old end time.
• Verification: Passed 64 create/update handler cases, 162 habit domain cases, and 84 reminder scheduler cases. Full solution tests were not rerun during this review.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}