[thomasluizon]

Closes thomasluizon/orbit-tickets#1509.

Adds Checkout_UserId_IsSentInSessionMetadata in tests/Orbit.Infrastructure.Tests/Services/StripeBillingServiceTests.cs. It captures the real adapter's SessionCreateOptions through the existing Stripe service substitute and asserts that Metadata["userId"] matches the supplied user ID. Two cases cover distinct users with and without a referral coupon. A separate theory keeps this contract explicit beside the existing return URL assertions.

Rechecked origin/main at b802f9e4d87b4afa6e74cfba32764d0017a120f4: the checkout adapter writes session metadata and HandleWebhookCommand reads its userId key. The adapter does not populate subscription metadata, so no additional subscription assertion applies. Production and webhook code remain unchanged.

Test evidence

The temporary defect renamed only the checkout metadata key in StripeBillingService.cs from userId to renamedUserId.

• Before changing the tests, dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~StripeBillingServiceTests exited 0 with all 19 original cases passing while the defect was present. This includes Checkout_ConfiguredReturnUrls_AreSentUnchanged.

• With the new theory and the same defect, dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~Checkout_UserId_IsSentInSessionMetadata exited 1: both cases failed because the captured metadata contained renamedUserId and lacked userId.

• After restoring the production key, dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~StripeBillingServiceTests exited 0 with all 21 cases passing, including both new cases.

• Post-commit dotnet build Orbit.slnx exited 0 with 0 errors; generated OpenAPI files had no diff.

• Post-commit dotnet test tests/Orbit.Infrastructure.Tests --filter FullyQualifiedName~Checkout_UserId_IsSentInSessionMetadata exited 0: 2 passed.

• dotnet test tests/Orbit.Domain.Tests exited 0: 671 passed.

• dotnet test tests/Orbit.Application.Tests exited 0: 5,485 passed.

• dotnet test tests/Orbit.Infrastructure.Tests exited 0: 3,359 passed.

External interface evidence

The installed Stripe.net 52.4.2 package's NuGet manifest pins source commit f4f1c8ce704825d7d7f00b4c9d848a2d028757eb. Its SessionCreateOptions source declares Metadata as Dictionary<string, string> with JSON name metadata. Confirmed by reading that exact source and the installed package XML member P:Stripe.Checkout.SessionCreateOptions.Metadata. Reproduce the source check with:

curl -fsSL https://raw.githubusercontent.com/stripe/stripe-dotnet/f4f1c8ce704825d7d7f00b4c9d848a2d028757eb/src/Stripe.net/Services/Checkout/Sessions/SessionCreateOptions.cs

The test reads the options created by the production adapter; it does not fabricate a metadata payload.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pullfrog]

✅ No new issues found.

Reviewed changes Reviewed the checkout metadata regression test against the production adapter, webhook lookup, and pinned Stripe SDK source.

• Session metadata contract: Adds two cases asserting the real adapter supplies Metadata["userId"] for distinct users, with and without a referral coupon.
• Focused verification: All 21 StripeBillingServiceTests cases passed locally, including both new cases. Production behavior and API contracts are unchanged; the full solution suite was not rerun.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}