Skip to content

Deploy Checklist: New Expensify 2024-02-13 #36429

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2024-02-13#36429
Assignees
applausebot
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@github-actions
github-actions
bot
opened on Feb 13, 2024

Release Version: 1.4.41-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. github-actions
    added
    StagingDeployCash
    on Feb 13, 2024
  2. github-actions
    assigned
    applausebot
    on Feb 13, 2024
  3. mountiny
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Feb 13, 2024

  4. blimpich commented on Feb 13, 2024

    @blimpich
    blimpich
    on Feb 13, 2024
    Contributor

    Demoting 36434

  5. amyevans commented on Feb 13, 2024

    @amyevans
    amyevans
    on Feb 13, 2024
    Contributor

    Demoted #36437

  6. OSBotify commented on Feb 14, 2024

    @OSBotify
    OSBotify
    on Feb 14, 2024
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.41-0 🚀

  7. Beamanator commented on Feb 14, 2024

    @Beamanator
    Beamanator
    on Feb 14, 2024
    Contributor

    Marked #36456 as NAB b/c we consider it a pretty strange edge case

  8. Beamanator commented on Feb 14, 2024

    @Beamanator
    Beamanator
    on Feb 14, 2024
    Contributor

    Also marked #36455 as NAB, it's not really broken - and it's a test that we'll be updating over the next few weeks

  9. Beamanator commented on Feb 14, 2024

    @Beamanator
    Beamanator
    on Feb 14, 2024
    Contributor

    #36458 also got marked nab as it's quite a small design bug that will be quick to fix

  10. kavimuru commented on Feb 14, 2024

    @kavimuru
    kavimuru
    on Feb 14, 2024

    Regression is 4% left.
    #31055 failing with #36455
    #34752 failing with #36479
    #34498 failing with #36449, #36451, #36447 and blocked in desktop with KI #36368
    #34303 failing with #36433 on desktop
    We still have validation pending on other unchecked PRs

  11. Julesssss commented on Feb 14, 2024

    @Julesssss
    Julesssss
    on Feb 14, 2024
    Contributor

    Checking off #36502 as it's not a big problem. Will fix without it being a blocker

  12. dangrous commented on Feb 14, 2024

    @dangrous
    dangrous
    on Feb 14, 2024
    Contributor

    #36487 is not a blocker and is sort of a dupe of #36455. Checking off.

  13. kavimuru commented on Feb 14, 2024

    @kavimuru
    kavimuru
    on Feb 14, 2024

    Regression completed.

    Unchecked PRs:
    #31055 failing with #36455
    #34752 failing with #36479
    #34498 failing with #36449,#36451,#36447 and blocked in desktop with KI36368
    #34303 failing with #36433 on desktop
    #34963 blocked by #36479
    #35287 blocked by #36433
    #35841 failing with #36434 but closed as not reproduced, checking it off
    #35853 blocked by #36433
    #36204 blocked by #36433 in iOS (tester does not have an account with previous requests to validate the PR. Because PR steps does not require a new IOU)
    #35645 - Looks internal testing, can I check it off?

    Open Blockers:
    #36433
    #36346
    #36438
    #36454
    #36457
    #36479
    #36481
    #36483
    #36490
    #36510
    #36517

    We are validating the 2 cps now.

  14. rlinoz commented on Feb 14, 2024

    @rlinoz
    rlinoz
    on Feb 14, 2024
    Contributor

    Checking off #36510 as this is already in prod.

  15. amyevans commented on Feb 14, 2024

    @amyevans
    amyevans
    on Feb 14, 2024
    Contributor

    Checked off #36454 following CP/retest

  16. mountiny commented on Feb 14, 2024

    @mountiny
    mountiny
    on Feb 14, 2024
    Contributor

    checking #36479 off, its backend blocker

  17. AndrewGable commented on Feb 15, 2024

    @AndrewGable
    AndrewGable
    on Feb 15, 2024
    Contributor

    Checked off #36517, it was fixed on staging by this CP https://github.com/Expensify/App/actions/runs/7909722028

  18. thienlnam commented on Feb 15, 2024

    @thienlnam
    thienlnam
    on Feb 15, 2024
    Contributor

    Only fresh crash is for
    ImageMetaData.getColorSpace - which only happened for 1 user on 1.4.38-6 so it seems fine to ignore

  19. thienlnam commented on Feb 15, 2024

    @thienlnam
    thienlnam
    on Feb 15, 2024
    Contributor

    Kicking off the deploy so we can get this fireroom fix to prod

  20. thienlnam commented on Feb 15, 2024

    @thienlnam
    thienlnam
    on Feb 15, 2024
    Contributor

    :shipit:

  21. thienlnam
    closed this as completedon Feb 15, 2024

  22. os-botify commented on Feb 15, 2024

    @os-botify
    os-botifyBot
    on Feb 15, 2024

    This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
    Reopening!

  23. os-botify
    reopened this on Feb 15, 2024

  24. melvin-bot commented on Feb 15, 2024

    @melvin-bot
    melvin-botBot
    on Feb 15, 2024 – with Melvin Bot

    📣 @os-botify[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  25. thienlnam commented on Feb 15, 2024

    @thienlnam
    thienlnam
    on Feb 15, 2024
    Contributor

    :shipit:

  26. thienlnam
    closed this as completedon Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions