Repository navigation
Deploy Checklist: New Expensify 2024-02-28 #37459
Description
Release Version: 1.4.45-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Perf/native stack navigation #29991
- Fix: PDF is not cached #32678
- Detect split request based on the route params #33482
- [TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168
- Prioritize display name to display in tooltip text #34213
- Change logic page not found in profile page #34329
- Fix: Status bar style not update #34637
- [TS migration] Migrate 'ReportActionCompose' component to TypeScript #34646
- Update Admin-Card-Settings-and-Features.md #34704
- Fix: Delay in updating green dot and total amount #34866
- fix error message disappear #35871
- [New Architecture] Upgrade
react-native-reanimated#36404 - fix receipt upload error when file name contain spaces #36531
- [TS Migration] Migrate 'RoomNameInput' to TypeScript #36676
- fix: prevent lag when adding code block in task description #36819
- Fix can't use Tab key in money request participant and confirmation page #36840
- Bump eslint-config-expensify version in E/App #36849
- Fix infinite loading when unlinking contact method #36850
- allow money requests on instantly submitted reports #36997
- Fix keyboard appears briefly when opening concierge page from a chat #37002
- [No QA] [TS migration] Migrate 'getCurrentBranchName.js' test to TypeScript #37010
- [TS migration] Migrate 'react-native-webview.js' mock to TypeScript #37018
- [No QA][TS migration] Migrate loginTest into Typescript #37031
- Make OpenApp a write command #37062
- [Audit][implementation] - replaceAndExtractEmojis double add fix #37093
- Fix unable to adjust volume by clicking on any part of the volume slider #37094
- [Fix]: Distance -When adding 'Stop' location the newly added location is added to 'Finish' location #37099
- Fix reimbursement account page back navigation #37120
- Hold Request, show status in preview #37121
- [No QA] [TS migration] Migrate 'index.js' test to TypeScript #37126
- [TS migration] Migrate 'ReimbursementAccountLoadingIndicator.js' component to TypeScript #37129
- Fix central screen is blank when using search shortcut from attachment preview #37130
- Feat/workspace categories settings #37133
- Failed to load PDF #37136
- feat: Use formula for the optimistic expense report #37160
- fix: Chat-In offline, uploading attachment & deleting it, is not showing strike-through #37179
- fix disallow report preview as latest action #37187
- Fix: VBA - Background page is reloading when proceeding through VBA flow #37188
- Fix/35654: Private note option does not appear #37193
- [No QA] [TS migration] Migrate 'EmojiTest.js', 'SidebarFilterTest.js', 'SidebarOrderTest.js', 'LHNTestUtils.js', 'SessionTest.js' test to TypeScript #37204
- Fix name of patch file #37225
- [No QA] Feature - Improve android build time #37227
- Fix error - "Please enter at least two different addresses" message remains #37231
- [No QA] Run pod install if firebase.json changed #37242
- fix(36385): update status bar colors #37244
- Profile page UI updates #37285
- Lowercase dequeued report action text since it starts with a verb #37286
- Remove duplicate logic, reuse method #37318
- fix: preserve credentials when clearing onyx #37401
- Refactor/align selectionlist checkboxes #37402
- Always use immediate parent report when rendering navigation header #37436
- Fix Workflows switch button's state for delayed submission #37438
- Remove deprecated method and pass down parentReportAction #37449
- [NoQA] Add the feature boolean flags to the policy type #37455
- [CP Staging] Fix missing default workspace avatar #37480
- [CP Staging]Fix: App crashes when upload PDF #37484
- revert #36819 #37500
- Make sure to compare the new parentReportAction when memoizing Report… #37504
- Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript" #37529
- Revert to correct expensify-common version #37570
Deploy Blockers:
- [$500] Changing playback speed is not taking effect when changing playback speed before playing #36827
- [PAID] [$500] Video - Two different crashes occur when downloading video #36833
- [HOLD for payment 2024-03-15] [$500] Expense - App crashes when changing date, description, merchant of the request #36857
- [$500] Distance - Total amount in report is not reset to 0.00 when changing distance request offline #36892
- [HOLD for payment 2024-03-07] [$500] Group - After selecting user in Group chat, the modal is not sliding upwards #37256
- [HOLD for payment 2024-03-07] [$500] [MEDIUM] Categories: Long category name is displayed in one line instead of two lines #37297
- [HOLD for payment 2024-03-07] [HOLD][$500] [MEDIUM] Tags: All tags are revealed when searching for hidden tag and clearing the search field #37335
- [HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square #37413
- [HOLD for payment 2024-03-14] Chat - Console error shows up when sending message with mention or text #37463
- [HOLD for payment 2024-06-11] [LOW] [Splits] [$500] IOU - App returns to participant selection page when hitting Save with Tab on Description page #37464
- [$500] [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Workspace - Workspace avatar is missing in Profile page #37465
- [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] IOU details page appears after delay and it is empty when request is created offline #37466
- [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] App crashes when uploading PDF or opening any attachment sent after PDF #37469
- [No payment] Chat-URL link shown in preview but turned to text after sending message. #37472
- IOU-"Enter a merchant name"error shown for amount in split bill scan. #37473
- Split - User can split bill with only one user and billable option is present in split menu #37488
- [HOLD FOR PAYMENT - 2024-03-03] IOU-Billable option is shown in send money confirmation page. #37489
- [ON HOLD] [MEDIUM] [Splits] [$250] Split bill - Split amount is lost when adding receipt and splitting bill #37491
- Split bill - Duplicated error message when making to split bill request with a user #37492
- Category - App returns to main chat when refreshing Categories Settings page #37505
- Category - Offline indicator appears below "Members must categorize.." instead of page bottom #37507
- [HOLD for payment 2024-04-15] [$500] [Simplified Collect][Categories] - "Categorize all expense" switch is not disabled when all categories are disabled #37508
- [HOLD for payment 2024-04-03] Category - Checkbox is clickable outside near the right of checkbox #37511
- Scan- Wrong IOU details in the notification email #37518
- Group Split - Error shows for Merchant and not Amount, while Merchant leads to error page #37523
- Android - Workspace - Workspace name is not fully displayed on Profile page #37548
- Workspace - Workspace owner can be checked marked on Members page #37555
- Category settings - The background changes if you refresh the page #37569
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Feb 29, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.45-0 🚀
melvin-bot commentedon Feb 29, 2024
kavimuru commentedon Feb 29, 2024
Regression is 5% left.
#37438 failing with KI #37363 not yet fixed. Please see the comment #37438 (comment). Checking it off
#37402 failing with 37511
#37285 failing with #37465
#34646 failing with #37463
#34168 failing with #36342 repro in production, checking it off
#32678 failing with #37469
luacmartins commentedon Feb 29, 2024
Checking off #37508. Demoted
puneetlath commentedon Feb 29, 2024
@kavimuru we CP'd this revert: #37529
Could you re-test these? The revert is live on v1.4.45-2
#37473
#37488
#37489
#37491
#37492
#37523
kavimuru commentedon Feb 29, 2024
#37491 and #37492 are still reproducible.
#37488 step 6 still fails. (Not sure if this is expected)
#37473, #37489 and #37523 are not reproducible
Videos for the bugs reproducible:
https://github.com/Expensify/App/assets/43996225/587d35a5-16c3-4446-ab35-1f88958064fc
https://github.com/Expensify/App/assets/43996225/0af6bf02-caef-4a07-9eea-879824a662ac
https://github.com/Expensify/App/assets/43996225/c5325333-eb1c-4cbc-8804-b1e4adadb032
puneetlath commentedon Feb 29, 2024
Great, thank you!
puneetlath commentedon Feb 29, 2024
For #37488 I think being able to split a bill with one user is correct, so I'm going to mark that one off.
kavimuru commentedon Feb 29, 2024
@puneetlath Regression is completed.
Unchecked PRs:
#32678 failing with #37469
#37402 failing with #37511
#37285 failing with #37465
#34646 failing with #37463
#32678 failing with #37469
#37136 failing with #37469
#36850 - in desktop navigating to web and correct message is displayed. Seems expected. Should we report it as a bug? Other platforms are pass.
#37160 failing with Known bug #36267 and not fixed. Please see comment - Checking off
#37133 failing with #37569
Open Blockers:
#37569
#37472
#37466
puneetlath commentedon Feb 29, 2024
I agree that sounds like the correct behavior. Going to check it off.
puneetlath commentedon Feb 29, 2024