Skip to content

Deploy Checklist: New Expensify 2024-11-05 #52084

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2024-11-05#52084
Assignees
Julesssssapplausebot
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@github-actions
github-actions
bot
opened on Nov 5, 2024

Release Version: 9.0.58-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. github-actions
    added
    StagingDeployCash
    on Nov 5, 2024
  2. github-actions
    assigned
    applausebot
    on Nov 5, 2024
  3. kavimuru
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Nov 5, 2024

  4. OSBotify commented on Nov 6, 2024

    @OSBotify
    OSBotify
    on Nov 6, 2024
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.58-0 🚀

  5. izarutskaya commented on Nov 6, 2024

    @izarutskaya
    izarutskaya
    on Nov 6, 2024

    Regression is at 63 % completed

    PRs:
    #50710 - Failing with #50020
    #51153 - Found KI #52098
    #51931 - KI #50694
    #51971 - KI #51042

    Blockers:
    #52095
    #52096
    #52097
    #52098

  6. lakchote commented on Nov 6, 2024

    @lakchote
    lakchote
    on Nov 6, 2024
    Contributor

    Demoted #52098 for this reason.

  7. Julesssss commented on Nov 6, 2024

    @Julesssss
    Julesssss
    on Nov 6, 2024
    Contributor

    Demoting #52097

  8. Julesssss commented on Nov 6, 2024

    @Julesssss
    Julesssss
    on Nov 6, 2024
    Contributor

    Checking off #52104

  9. Julesssss
    self-assigned this
    on Nov 6, 2024

  10. carlosmiceli commented on Nov 6, 2024

    @carlosmiceli
    carlosmiceli
    on Nov 6, 2024
    Contributor

    This was fixed by the CP: #52108

  11. kavimuru commented on Nov 6, 2024

    @kavimuru
    kavimuru
    on Nov 6, 2024

    Regression is 7% left

    Unchecked PRs:
    #50710 - Failing with original KI #50710 (comment)
    #51153 iOS validation is pending
    #51244 iOS validation is pending
    #51314 iOS validation is pending
    #51327 iOS validation is pending
    #51425 android and iOS validation are pending
    #51575 iOS validation is pending
    #51588 iOS validation is pending, failing with #52118 in desktop and android
    #51779 iOS validation is pending
    #51849 failing with #52099
    #51925 iOS validation is pending
    #51931 failing with original KI in mweb #51931 (comment)
    #51947 iOS validation is pending
    #51971 iOS validation pending

    The following PRs related to company card feed were internally verified by @joekaufmanexpensify, I am checking it off.
    https://applause-ts.slack.com/archives/C9YU7BX5M/p1730897126117409
    #51671
    #51948
    #51950
    #51952
    #52015

    #51136 checked it off as there was no QA steps

  12. rlinoz commented on Nov 6, 2024

    @rlinoz
    rlinoz
    on Nov 6, 2024
    Contributor

    Checking off
    #52099
    #52101
    #52106
    #52110
    #52111
    #52113

    Per https://expensify.slack.com/archives/C9YU7BX5M/p1730918481651709?thread_ts=1730910115.500509&cid=C9YU7BX5M

  13. srikarparsi commented on Nov 6, 2024

    @srikarparsi
    srikarparsi
    on Nov 6, 2024
    Contributor

    Checking off #52122 as it was also fixed by the revert

  14. kavimuru commented on Nov 6, 2024

    @kavimuru
    kavimuru
    on Nov 6, 2024

    Regression is completed:
    Unchecked PRs:
    #50710 - Failing with original KI #50710 (comment)
    #51425 failing with #52104
    #51588 failing with #52118 and #52106
    #51849 failing with #52099
    #51931 failing with original KI in mweb #51931 (comment)

  15. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor

    Checking off #52137

  16. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor

    #50710 - Failing with original KI #50710 (comment)

    Issue was deemed not to be a blocker

    #51425 failing with #52104

    We closed as it is being fixed elsewhere

    #51588 failing with #52118 and #52106

    Fixed, not a blocker

    #51849 failing with #52099

    Fixed

    #51931 failing with original KI in mweb #51931 (comment)

    Issue is not direct cause, being fixed elsewhere.

  17. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor

  18. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor
    • Firebase crashes:
      • iOS: Two new crashes, both with a single instance
      • Android: The only fresh issue is from an previous release and has 2 instances
    • App Timing looking reasonable
    • Github up ✅

  19. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor

    :shipit:

  20. Julesssss
    closed this as completedon Nov 7, 2024
  21. os-botify
    reopened this on Nov 7, 2024

  22. os-botify commented on Nov 7, 2024

    @os-botify
    os-botifyBot
    on Nov 7, 2024

    This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
    Reopening!

  23. melvin-bot commented on Nov 7, 2024

    @melvin-bot
    melvin-botBot
    on Nov 7, 2024 – with Melvin Bot

    📣 @os-botify[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  24. Julesssss commented on Nov 7, 2024

    @Julesssss
    Julesssss
    on Nov 7, 2024
    Contributor

    :shipit:

  25. Julesssss
    closed this as completedon Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions