Skip to content

Deploy Checklist: New Expensify 2022-02-23 #7883

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2022-02-23#7883
Assignees
applausebot
Labels
MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Feb 23, 2022

Release Version: 1.1.40-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Feb 23, 2022
  2. OSBotify
    assigned
    applausebot
    on Feb 23, 2022
  3. mvtglobally
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Feb 23, 2022

  4. OSBotify commented on Feb 23, 2022

    @OSBotify
    OSBotify
    on Feb 23, 2022
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.40-0 🚀

  5. luacmartins commented on Feb 24, 2022

    @luacmartins
    luacmartins
    on Feb 24, 2022
    Contributor

    I'm confused. I thought we had checked #7802 off the list yesterday. Checking it off again.

  6. mountiny commented on Feb 24, 2022

    @mountiny
    mountiny
    on Feb 24, 2022
    Contributor

    @luacmartins Yes! See created issue above! or here 😄

  7. nickmurray47 commented on Feb 24, 2022

    @nickmurray47
    nickmurray47
    on Feb 24, 2022
    Contributor

    Going to check off #7663 for now since we will actually need to test on Prod and @thienlnam and I will test once it's there.

  8. nkuoch commented on Feb 24, 2022

    @nkuoch
    nkuoch
    on Feb 24, 2022
    Contributor

    Checked off #7812

  9. mvtglobally commented on Feb 28, 2022

    @mvtglobally
    mvtglobally
    on Feb 28, 2022

    Regression is completed
    Deploy Blocker
    #7900
    #7888 - unable to verify in PROD, so added blocker label.

    PRs failing
    #7459 Issue raised #7884 - Checking off
    #7633 - Not fixed #7633 (comment)
    #7748 is failing due to #7888.
    #7765 is failing #7928. We may need a new Staging build to re-verify this issue

    Internal QA
    #7766 (comment)

    Additional issues logged
    #7885
    #7893
    #7899
    #7903
    #7919

  10. marcaaron commented on Feb 28, 2022

    @marcaaron
    marcaaron
    on Feb 28, 2022
    Contributor

    checked #7888 as the issue was closed.

  11. MelvinBot
    added
    MonthlyKSv2
    on Feb 28, 2022

  12. roryabraham commented on Feb 28, 2022

    @roryabraham
    roryabraham
    on Feb 28, 2022
    Contributor

    We identified that #7900 was caused by #7723 (shoutout to @kidroca for pointing this out), and as such a revert PR for #7723 is being CP'd to staging.

  13. roryabraham commented on Feb 28, 2022

    @roryabraham
    roryabraham
    on Feb 28, 2022
    Contributor

    Before shipping this deploy, I think we'll want to revert #7633 because it failed QA.

  14. OSBotify commented on Feb 28, 2022

    @OSBotify
    OSBotify
    on Feb 28, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.40-1 🚀

  15. OSBotify commented on Feb 28, 2022

    @OSBotify
    OSBotify
    on Feb 28, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.40-1 has been deployed to staging 🎉

  16. 3 remaining items

  17. yuwenmemon commented on Feb 28, 2022

    @yuwenmemon
    yuwenmemon
    on Feb 28, 2022
    Contributor

    Checking off #7663 because it is productionQA

  18. yuwenmemon commented on Feb 28, 2022

    @yuwenmemon
    yuwenmemon
    on Feb 28, 2022
    Contributor

    Checking off #7752 because even though it is not working, it is not a blocker: #7752 (comment)

  19. yuwenmemon commented on Feb 28, 2022

    @yuwenmemon
    yuwenmemon
    on Feb 28, 2022
    Contributor

    Checking off #7765 because it is not a blocker (see #7928 (comment))

  20. roryabraham commented on Feb 28, 2022

    @roryabraham
    roryabraham
    on Feb 28, 2022
    Contributor

    Just merged a revert for #7633

  21. OSBotify commented on Mar 1, 2022

    @OSBotify
    OSBotify
    on Mar 1, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.40-2 🚀

  22. OSBotify commented on Mar 1, 2022

    @OSBotify
    OSBotify
    on Mar 1, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.40-2 has been deployed to staging 🎉

  23. yuwenmemon commented on Mar 1, 2022

    @yuwenmemon
    yuwenmemon
    on Mar 1, 2022
    Contributor

    Checking off #7633 because it was reverted

  24. yuwenmemon commented on Mar 1, 2022

    @yuwenmemon
    yuwenmemon
    on Mar 1, 2022
    Contributor

    @mvtglobally Looks like we just need to re-QA #7748! Any update on that?

  25. mvtglobally commented on Mar 1, 2022

    @mvtglobally
    mvtglobally
    on Mar 1, 2022

    @yuwenmemon will have update early in the morning on this retest

  26. mvtglobally commented on Mar 1, 2022

    @mvtglobally
    mvtglobally
    on Mar 1, 2022

    Checking off #7748 (comment)

  27. yuwenmemon commented on Mar 1, 2022

    @yuwenmemon
    yuwenmemon
    on Mar 1, 2022
    Contributor

    Thanks! Just ran the accessibility check-off train

  28. yuwenmemon commented on Mar 1, 2022

    @yuwenmemon
    yuwenmemon
    on Mar 1, 2022
    Contributor

    :shipit:

  29. yuwenmemon
    closed this as completedon Mar 1, 2022

  30. Stutikuls commented on Mar 9, 2022

    @Stutikuls
    Stutikuls
    on Mar 9, 2022

    Checked all PRs and added comments on all PRs where accessibility issue were found.
    The non-applicable PRs are - #7565, #7522, #7742, #7748, #7751, #7762

  31. SumitDiyora commented on Mar 15, 2022

    @SumitDiyora
    SumitDiyora
    on Mar 15, 2022

    Checked all PRs and added comments to all PRs where accessibility issues were found.
    The non-applicable PRs are - #7765, #7771, #7782, #7817, #7819, #7828, #7830, #7845, #7865
    Impossibility to verify (After client confirmation) #7812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions