Repository navigation
feat(api): add vault updates and metadata filters - #4047
Conversation
Castiron-Internal-PR: openai/openai-python-internal#222 Castiron-Source-SHA: e3316d44fc0685761469bd0d3876c90856046ed0 Castiron-Public-Base-SHA: ef676db
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 50 mixed files remain; 0 existing customizations changed; 2 customizations removed; 4 generated baselines changed. Compared
48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38070628449 --repo openai/openai-python \
--name castiron-custom-code-38070628449-1 --dir /tmp/castiron-custom-code-38070628449-1
git apply --stat /tmp/castiron-custom-code-38070628449-1/custom-code.patch
cat /tmp/castiron-custom-code-38070628449-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin ef676dbc199bc09d12a1d051f3b8b2486aa53dc2 76092f445ecbaaf4ca73e1f37cf9f82718d2ca13
python3 scripts/castiron/custom_code_report.py report \
--base ef676dbc199bc09d12a1d051f3b8b2486aa53dc2 \
--head 76092f445ecbaaf4ca73e1f37cf9f82718d2ca13 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-76092f445ecb
cat /tmp/castiron-custom-code-76092f445ecb/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 76092f445ecbaaf4ca73e1f37cf9f82718d2ca13 against ef676dbc199bc09d12a1d051f3b8b2486aa53dc2. The shared query encoder preserves explicit empty strings while still omitting None. Both vault and credential lists use that path in synchronous and asynchronous clients, and pagination retains the filters. The new transport tests inspect the outgoing metadata parameter and pin their mock base URLs.
The update methods preserve omitted fields, explicit name=None, and metadata={}. I found no actionable correctness or structural issues. Hosted tests, lint, baseline consistency, and custom-code budget checks passed on this head. I reviewed pinned source and tests; I did not run local tests or generation.
Automated Release PR --- ## [3.29.0](openai/openai-python@v3.28.0...v3.29.0) (2026-10-11) ### Features * **api:** add billing_not_active session error code ([openai#4052](openai#4052)) ([c88b320](openai@c88b320)) * **api:** add shida to named Live voices ([openai#4053](openai#4053)) ([7352cf5](openai@7352cf5)) * **api:** add vault updates and metadata filters ([openai#4047](openai#4047)) ([e72f493](openai@e72f493)) * **api:** align beta pagination limits and non-null parameters ([openai#4057](openai#4057)) ([800899e](openai@800899e)) ### Chores * **api:** clarify decision creation documentation ([openai#4054](openai#4054)) ([16d3d3b](openai@16d3d3b)) * **api:** clarify Decisions question and answer descriptions ([openai#4051](openai#4051)) ([895d617](openai@895d617)) * **api:** document 128-character safety identifiers ([openai#4050](openai#4050)) ([2c1ae52](openai@2c1ae52)) * **api:** document decision choice constraints ([openai#4055](openai#4055)) ([b7a1990](openai@b7a1990)) * **api:** document Files API rate-limit responses ([openai#4049](openai#4049)) ([f6a3459](openai@f6a3459)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
2 participants
Summary
Adds synchronous and asynchronous vault updates and metadata filtering.
Changes
Update a vault name or replace its metadata.
Filter vaults and credentials by metadata key-value pairs.
Preserve empty-string query filter values while continuing to omit
None.