Skip to content

chore(api): clarify Decisions question and answer descriptions - #4051

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-225
Oct 10, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-225

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies the supported input, question types, and declined answers in the Decisions API.

Changes

  • Describe predicate, choice, and score questions.
  • Clarify shared evidence inputs and that one declined question does not prevent other answers.

Castiron-Internal-PR: openai/openai-python-internal#225
Castiron-Source-SHA: a162747ed287a86e2c55e67fbbb6e8290e13b75f
Castiron-Public-Base-SHA: 2c1ae52
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 10, 2026 21:29
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 10, 2026 21:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T21:31:00.066576Z 34188b5 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-10T21:31:49.724265Z 34188b5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 2c1ae5266a67303d82ea46c57be854deaa6e5676.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared 2c1ae5266a67 → 34188b53e601. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_github.py
  • scripts/castiron/test_custom_code_publication.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38087854090 --repo openai/openai-python \
  --name castiron-custom-code-38087854090-1 --dir /tmp/castiron-custom-code-38087854090-1
git apply --stat /tmp/castiron-custom-code-38087854090-1/custom-code.patch
cat /tmp/castiron-custom-code-38087854090-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 2c1ae5266a67303d82ea46c57be854deaa6e5676 34188b53e601b6a6d6e38235aae314a796fad825
python3 scripts/castiron/custom_code_report.py report \
  --base 2c1ae5266a67303d82ea46c57be854deaa6e5676 \
  --head 34188b53e601b6a6d6e38235aae314a796fad825 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-34188b53e601
cat /tmp/castiron-custom-code-34188b53e601/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.538s for Python SDK PR #4051.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 204ms
tests/chat-completions-create.test.ts ✅ Passed 276ms
tests/chat-completions-stream.test.ts ✅ Passed 274ms
tests/files-content-binary.test.ts ✅ Passed 234ms
tests/files-create-multipart.test.ts ✅ Passed 239ms
tests/files-list-pagination.test.ts ✅ Passed 236ms
tests/initialize-config.test.ts ✅ Passed 176ms
tests/instance-isolation.test.ts ✅ Passed 206ms
tests/models-list.test.ts ✅ Passed 209ms
tests/responses-background-lifecycle.test.ts ✅ Passed 168ms
tests/responses-body-method-errors.test.ts ✅ Passed 300ms
tests/responses-cancel-timeout.test.ts ✅ Passed 235ms
tests/responses-cancel.test.ts ✅ Passed 235ms
tests/responses-compact-retries.test.ts ✅ Passed 321ms
tests/responses-compact.test.ts ✅ Passed 191ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 180ms
tests/responses-create-advanced.test.ts ✅ Passed 231ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.238s
tests/responses-create-errors.test.ts ✅ Passed 200ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 233ms
tests/responses-create-retries.test.ts ✅ Passed 295ms
tests/responses-create-stream-failures.test.ts ✅ Passed 826ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 240ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.153s
tests/responses-create-stream.test.ts ✅ Passed 118ms
tests/responses-create-terminal-states.test.ts ✅ Passed 210ms
tests/responses-create-timeout.test.ts ✅ Passed 234ms
tests/responses-create.test.ts ✅ Passed 606ms
tests/responses-delete.test.ts ✅ Passed 204ms
tests/responses-input-items-errors.test.ts ✅ Passed 623ms
tests/responses-input-items-list.test.ts ✅ Passed 344ms
tests/responses-input-items-options.test.ts ✅ Passed 399ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 279ms
tests/responses-input-tokens-count.test.ts ✅ Passed 195ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.054s
tests/responses-not-found-errors.test.ts ✅ Passed 239ms
tests/responses-parse.test.ts ✅ Passed 259ms
tests/responses-retrieve-retries.test.ts ✅ Passed 233ms
tests/responses-retrieve.test.ts ✅ Passed 213ms
tests/responses-stored-method-errors.test.ts ✅ Passed 430ms
tests/retry-behavior.test.ts ✅ Passed 3.092s
tests/sdk-error-shape.test.ts ✅ Passed 287ms

View OkTest run #38087834879

SDK merge (3ae0ec126917) · head (34188b53e601) · base (2c1ae5266a67) · OkTest (57341bb8c17e)

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 34188b53e601b6a6d6e38235aae314a796fad825 against 2c1ae5266a67303d82ea46c57be854deaa6e5676. No findings.

The five Decisions schema descriptions and generated documentation are consistent. The synchronous and asynchronous create docs, input and question types, and refusal model remain consistent. Executable code, validation and signatures are unchanged. The public generation reference resolves to the expected generated contents.

CI is green for this commit as of 21:34 UTC. I reviewed immutable source and hosted checks; I did not run repository tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit 895d617 Oct 10, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-225 branch October 10, 2026 21:40
@openai-sdks openai-sdks Bot mentioned this pull request Oct 10, 2026
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-openai__openai-python that referenced this pull request Oct 11, 2026
Automated Release PR
---


##
[3.29.0](openai/openai-python@v3.28.0...v3.29.0)
(2026-10-11)


### Features

* **api:** add billing_not_active session error code
([openai#4052](openai#4052))
([c88b320](openai@c88b320))
* **api:** add shida to named Live voices
([openai#4053](openai#4053))
([7352cf5](openai@7352cf5))
* **api:** add vault updates and metadata filters
([openai#4047](openai#4047))
([e72f493](openai@e72f493))
* **api:** align beta pagination limits and non-null parameters
([openai#4057](openai#4057))
([800899e](openai@800899e))


### Chores

* **api:** clarify decision creation documentation
([openai#4054](openai#4054))
([16d3d3b](openai@16d3d3b))
* **api:** clarify Decisions question and answer descriptions
([openai#4051](openai#4051))
([895d617](openai@895d617))
* **api:** document 128-character safety identifiers
([openai#4050](openai#4050))
([2c1ae52](openai@2c1ae52))
* **api:** document decision choice constraints
([openai#4055](openai#4055))
([b7a1990](openai@b7a1990))
* **api:** document Files API rate-limit responses
([openai#4049](openai#4049))
([f6a3459](openai@f6a3459))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants