Repository navigation
feat(api): align beta pagination limits and non-null parameters - #4057
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#231 Castiron-Source-SHA: 69f35cf3436842b1718d99772aa0e1d768953cff Castiron-Public-Base-SHA: b7a1990
jbeckwith-oai
marked this pull request as ready for review
October 11, 2026 16:55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 50 mixed files remain; 0 existing customizations changed; 2 generated baselines changed. Compared
48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38157514252 --repo openai/openai-python \
--name castiron-custom-code-38157514252-1 --dir /tmp/castiron-custom-code-38157514252-1
git apply --stat /tmp/castiron-custom-code-38157514252-1/custom-code.patch
cat /tmp/castiron-custom-code-38157514252-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin b7a1990353baec896ee5e04b40b9f2dc2925a4f5 627779945e023617a9193082845e9f3bc3a72ea7
python3 scripts/castiron/custom_code_report.py report \
--base b7a1990353baec896ee5e04b40b9f2dc2925a4f5 \
--head 627779945e023617a9193082845e9f3bc3a72ea7 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-627779945e02
cat /tmp/castiron-custom-code-627779945e02/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Contributor
yoni-oai
approved these changes
Oct 11, 2026
Merged
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-openai__openai-python
that referenced
this pull request
Oct 11, 2026
Automated Release PR --- ## [3.29.0](openai/openai-python@v3.28.0...v3.29.0) (2026-10-11) ### Features * **api:** add billing_not_active session error code ([openai#4052](openai#4052)) ([c88b320](openai@c88b320)) * **api:** add shida to named Live voices ([openai#4053](openai#4053)) ([7352cf5](openai@7352cf5)) * **api:** add vault updates and metadata filters ([openai#4047](openai#4047)) ([e72f493](openai@e72f493)) * **api:** align beta pagination limits and non-null parameters ([openai#4057](openai#4057)) ([800899e](openai@800899e)) ### Chores * **api:** clarify decision creation documentation ([openai#4054](openai#4054)) ([16d3d3b](openai@16d3d3b)) * **api:** clarify Decisions question and answer descriptions ([openai#4051](openai#4051)) ([895d617](openai@895d617)) * **api:** document 128-character safety identifiers ([openai#4050](openai#4050)) ([2c1ae52](openai@2c1ae52)) * **api:** document decision choice constraints ([openai#4055](openai#4055)) ([b7a1990](openai@b7a1990)) * **api:** document Files API rate-limit responses ([openai#4049](openai#4049)) ([f6a3459](openai@f6a3459)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns beta agent pagination with the API’s shared validation rules.
Changes
Beta agent pagination now follows shared API validation: page sizes must be 1–100 (default 20). Session, vault, and vault-credential listings reject out-of-range limits with HTTP 400 instead of clamping them. Omit optional pagination arguments to use defaults. List parameter annotations no longer include
Nonefor the five list limits or the artifactaftercursor. Prefer omitting these arguments; existing PythonNoneserialization still omits them.Affected beta resources: agents, sessions, session artifacts, vaults, and vault credentials (
beta.agents). The corresponding HTTP paths are/agents,/agents/sessions,/agents/sessions/{session_id}/artifacts,/vaults, and/vaults/{vault_id}/credentials.Compatibility and migration
This follows the beta API’s move to shared pagination validation. Omit
limitto use 20, or supply an integer from 1 through 100. Omitafterto start at the first page. Artifact listing already enforced the numeric range; the newly rejected out-of-range requests identified here are session, vault, and vault-credential listings.The change remains within the beta surface and does not use a major-version marker.