Skip to content

chore(api): document 128-character safety identifiers - #4050

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-224
Oct 10, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-224

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Documents the 128-character maximum for safety identifiers.

Changes

  • Update safety_identifier descriptions and API reference constraints to reflect the 128-character limit.

Castiron-Internal-PR: openai/openai-python-internal#224
Castiron-Source-SHA: 64eb5a8be8cc3596d0987fbdc718cde49a6c7421
Castiron-Public-Base-SHA: f6a3459
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: f6a34593aa12eb8e6e89803590423b8cd2aa5933.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed; 6 generated baselines changed.

Compared f6a34593aa12 → 552a81c003f3. Generated baselines verified.

File Result Current custom patch
src/openai/resources/beta/responses/responses.py Generated baseline changed +140 / −107
src/openai/resources/chat/completions/completions.py Generated baseline changed +603 / −1
src/openai/resources/responses/responses.py Generated baseline changed +1028 / −137
src/openai/types/responses/response.py Generated baseline changed +16 / −0
src/openai/types/responses/responses_client_event.py Generated baseline changed +30 / −0
src/openai/types/responses/responses_client_event_param.py Generated baseline changed +30 / −0
44 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_github.py
  • scripts/castiron/test_custom_code_publication.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py

4 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38083120738 --repo openai/openai-python \
  --name castiron-custom-code-38083120738-1 --dir /tmp/castiron-custom-code-38083120738-1
git apply --stat /tmp/castiron-custom-code-38083120738-1/custom-code.patch
cat /tmp/castiron-custom-code-38083120738-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin f6a34593aa12eb8e6e89803590423b8cd2aa5933 552a81c003f374046acf4977d8bb6c6b2ef705e0
python3 scripts/castiron/custom_code_report.py report \
  --base f6a34593aa12eb8e6e89803590423b8cd2aa5933 \
  --head 552a81c003f374046acf4977d8bb6c6b2ef705e0 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-552a81c003f3
cat /tmp/castiron-custom-code-552a81c003f3/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 10, 2026 20:16
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 10, 2026 20:16
@openai-sdks

openai-sdks Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.298s for Python SDK PR #4050.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 251ms
tests/chat-completions-create.test.ts ✅ Passed 187ms
tests/chat-completions-stream.test.ts ✅ Passed 125ms
tests/files-content-binary.test.ts ✅ Passed 140ms
tests/files-create-multipart.test.ts ✅ Passed 153ms
tests/files-list-pagination.test.ts ✅ Passed 106ms
tests/initialize-config.test.ts ✅ Passed 1.386s
tests/instance-isolation.test.ts ✅ Passed 142ms
tests/models-list.test.ts ✅ Passed 199ms
tests/responses-background-lifecycle.test.ts ✅ Passed 1.425s
tests/responses-body-method-errors.test.ts ✅ Passed 214ms
tests/responses-cancel-timeout.test.ts ✅ Passed 193ms
tests/responses-cancel.test.ts ✅ Passed 138ms
tests/responses-compact-retries.test.ts ✅ Passed 247ms
tests/responses-compact.test.ts ✅ Passed 228ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 125ms
tests/responses-create-advanced.test.ts ✅ Passed 178ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.118s
tests/responses-create-errors.test.ts ✅ Passed 147ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 151ms
tests/responses-create-retries.test.ts ✅ Passed 249ms
tests/responses-create-stream-failures.test.ts ✅ Passed 91ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 209ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.575s
tests/responses-create-stream.test.ts ✅ Passed 253ms
tests/responses-create-terminal-states.test.ts ✅ Passed 225ms
tests/responses-create-timeout.test.ts ✅ Passed 210ms
tests/responses-create.test.ts ✅ Passed 413ms
tests/responses-delete.test.ts ✅ Passed 161ms
tests/responses-input-items-errors.test.ts ✅ Passed 326ms
tests/responses-input-items-list.test.ts ✅ Passed 227ms
tests/responses-input-items-options.test.ts ✅ Passed 256ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 245ms
tests/responses-input-tokens-count.test.ts ✅ Passed 676ms
tests/responses-malformed-inputs.test.ts ✅ Passed 779ms
tests/responses-not-found-errors.test.ts ✅ Passed 217ms
tests/responses-parse.test.ts ✅ Passed 266ms
tests/responses-retrieve-retries.test.ts ✅ Passed 726ms
tests/responses-retrieve.test.ts ✅ Passed 190ms
tests/responses-stored-method-errors.test.ts ✅ Passed 380ms
tests/retry-behavior.test.ts ✅ Passed 3.142s
tests/sdk-error-shape.test.ts ✅ Passed 233ms

View OkTest run #38083098826

SDK merge (de4737d0e180) · head (552a81c003f3) · base (f6a34593aa12) · OkTest (57341bb8c17e)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T20:18:01.639760Z 552a81c Draft marked ready
🔒 Security Review ✅ Completed 2026-10-10T20:19:18.662658Z 552a81c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 552a81c003f374046acf4977d8bb6c6b2ef705e0. No actionable findings.

Both safety-identifier schema limits and descriptions match the 128-character update. The rest of the parsed API reference is unchanged, and the source edits affect documentation or CLI help only. I verified the transformed-spec checksum and public generation snapshot. Request handling and API signatures are unchanged.

Hosted CI is green for this head. I reviewed source and hosted checks without running repository tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit 2c1ae52 Oct 10, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-224 branch October 10, 2026 20:26
@openai-sdks openai-sdks Bot mentioned this pull request Oct 10, 2026
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-openai__openai-python that referenced this pull request Oct 11, 2026
Automated Release PR
---


##
[3.29.0](openai/openai-python@v3.28.0...v3.29.0)
(2026-10-11)


### Features

* **api:** add billing_not_active session error code
([openai#4052](openai#4052))
([c88b320](openai@c88b320))
* **api:** add shida to named Live voices
([openai#4053](openai#4053))
([7352cf5](openai@7352cf5))
* **api:** add vault updates and metadata filters
([openai#4047](openai#4047))
([e72f493](openai@e72f493))
* **api:** align beta pagination limits and non-null parameters
([openai#4057](openai#4057))
([800899e](openai@800899e))


### Chores

* **api:** clarify decision creation documentation
([openai#4054](openai#4054))
([16d3d3b](openai@16d3d3b))
* **api:** clarify Decisions question and answer descriptions
([openai#4051](openai#4051))
([895d617](openai@895d617))
* **api:** document 128-character safety identifiers
([openai#4050](openai#4050))
([2c1ae52](openai@2c1ae52))
* **api:** document decision choice constraints
([openai#4055](openai#4055))
([b7a1990](openai@b7a1990))
* **api:** document Files API rate-limit responses
([openai#4049](openai#4049))
([f6a3459](openai@f6a3459))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants