fix(desktop): close the window before quit cleanup

[t3dotgg]

Quitting T3 Code kept the desktop window visible while the local backend completed about two seconds of graceful cleanup. This made Cmd+Q feel unresponsive on macOS.

The desktop now saves window bounds and destroys all Electron windows before it starts backend cleanup. The Electron process remains alive until cleanup completes, then exits as before. Updater-controlled quits still use the updater path.

Tests:

• vp test run apps/desktop/src/app/DesktopLifecycle.test.ts apps/desktop/src/electron/ElectronWindow.test.ts
• vp run --filter @t3tools/desktop typecheck
• targeted lint and formatting checks

Made by GPT-5.6 using T3 Code through the Codex harness.

---

Note

Medium Risk
Touches core quit/teardown ordering in the desktop lifecycle; behavior is well-tested but incorrect ordering could affect shutdown or updater paths.

Overview
Quit now hides the UI immediately by flushing main window bounds, destroying all Electron windows, and only then requesting backend shutdown—the process still exits after cleanup finishes.

ElectronWindow.destroyAll attempts every window and surfaces the first destroy error instead of stopping at the first failure; lifecycle logs destroy failures but does not block shutdown. macOS activate is ignored while DesktopState.quitting is set so a window cannot reopen during teardown.

Tests add shared mock layers plus coverage for flush → destroy → shutdown ordering and suppressed activation while quitting.

^{Reviewed by Cursor Bugbot for commit b146aa0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Close all Electron windows before backend shutdown on quit

• On before-quit, all Electron windows are now destroyed before requesting backend shutdown, ensuring windows close cleanly prior to teardown.
• destroyAll in ElectronWindow.ts now attempts to destroy every window even if earlier ones fail, reporting only the first failure cause.
• App activate events are ignored once the quitting flag is set, preventing activation during shutdown.
• Behavioral Change: requestDesktopShutdownAndWait now accepts an optional afterBoundsFlush effect, changing the quit sequence to: flush bounds → destroy windows → request shutdown → quit.

^{Macroscope summarized b146aa0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 43c0a35a-8577-4a6d-ac26-905b72e8f71d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9a82604. Configure here.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	12.6 KiB	12.6 KiB	0 B (0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.3 KiB	6.3 KiB	−10 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.3 KiB	6.3 KiB	+10 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	51.8 KiB	51.8 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	16	16	0 (0.0%)	21	✅
Claude	Total thread wire	12.6 KiB	12.6 KiB	−5 B (−0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.3 KiB	6.3 KiB	−1 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.3 KiB	6.3 KiB	−4 B (−0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	52.7 KiB	52.7 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	16	16	0 (0.0%)	21	✅

Baseline: 8bbbab5 · PR result: b146aa0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 99.9 KiB
• Claude decoded thread snapshot: 100.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at b146aa0

Macroscope's review found this PR approvable — Straightforward bug fix that reorders quit cleanup operations to destroy windows before waiting for backend shutdown. Changes are well-contained to the lifecycle/quit flow with proper test coverage added.

^{You can add or adjust custom eligibility rules. Learn more.}

[CDVolvik]

DesktopLifecycle.test.ts: 5/5, including win32.

Quitting while the window is still up runs renderer/cleanup against a dying UI. Destroy the window first, then the rest. The updater before-quit-for-update path still proceeds. MERGEABLE.

Dismissing prior approval to re-evaluate e1564a1