fix(marketing): Safari gets the arm64 Mac download - #7473
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 231cc01. Configure here.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes Safari's 'Apple GPU' renderer detection from x64 to arm64, affecting which Mac download users receive. An unresolved review comment raises a valid concern that Intel Safari users may receive incompatible arm64 builds, since 'Apple GPU' is reported on both Intel and Apple Silicon Macs. You can add or adjust custom eligibility rules. Learn more. |
…#7473, pingdotgg#7477 The add-surface menu takes upstream's data-driven action list and its keyboard shortcuts (pingdotgg#7318); the fork's per-profile Browser submenu rides on top of the Browser entry, so one click still opens the default profile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
## What's Changed * fix(marketing): Safari gets the arm64 Mac download by @t3dotgg in pingdotgg/t3code#7473 * feat(web): add shortcuts to the surface dropdown by @gsimone in pingdotgg/t3code#7318 * fix(marketing): never serve the Intel build to Apple Silicon Macs by @t3dotgg in pingdotgg/t3code#7477 * fix(web): animate command palette when closing by @tarik02 in pingdotgg/t3code#5169 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260819.1130...v0.0.34-nightly.20260819.1132 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260819.1132
* test(web): remove duplicate lookup assertion (pingdotgg#7364) * fix(mobile): show structured input option descriptions (pingdotgg#7321) * fix(orchestration): do not revive idle tasks from status-free progress (pingdotgg#7172) * refactor(server): simplify error transformation with Effect.mapError in GitHubPullRequestCli (pingdotgg#7385) Signed-off-by: aoright <102943475+aoright@users.noreply.github.com> * fix(preview): open local environment ports on localhost (pingdotgg#7300) * fix(desktop): prevent quit shortcut spillover (pingdotgg#7397) * fix(desktop): stop overwriting a custom dock icon on launch (pingdotgg#7125) * feat(web): show project location in new thread picker (pingdotgg#7392) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> * fix(packaging): install AUR launcher icons where icon themes look (pingdotgg#7421) * fix(web): label pull request merge actions (pingdotgg#7381) * fix(server): avoid PRs inherited from default upstreams (pingdotgg#7317) * fix(desktop): stop the passkey dialog from popping as soon as sign-in opens (pingdotgg#7437) * feat(desktop): mute a browser tab (pingdotgg#7252) * fix(web): improve disconnected composer placeholder (pingdotgg#7122) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> * fix(desktop): throttle hidden preview rendering (pingdotgg#7445) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> * fix(server): stop probing Grok, Cursor, and OpenCode unless turned on (pingdotgg#7459) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(desktop): boot the main window unthrottled so cold start paints at full speed (pingdotgg#7460) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(threads): a merged PR settles its thread only once (pingdotgg#7454) * feat(cli): npx t3 triage hands broken installs to your own coding agent (pingdotgg#6563) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(marketing): Safari gets the arm64 Mac download (pingdotgg#7473) * feat(web): add shortcuts to the surface dropdown (pingdotgg#7318) * fix(marketing): never serve the Intel build to Apple Silicon Macs (pingdotgg#7477) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): animate command palette when closing (pingdotgg#5169) * fix(desktop): upgrade Clerk OAuth transport (pingdotgg#7479) * feat(server): run the background service on macOS via launchd (pingdotgg#6286) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): align sidebar statuses with project names (pingdotgg#7491) Co-authored-by: GPT-5.6 <noreply@openai.com> * fix(desktop): close the window before quit cleanup (pingdotgg#6562) * fix(desktop): stop automatic passkey prompts (pingdotgg#7522) * docs(user): document phoenix triage and macOS background service The 2026-08-19 upstream sync added the triage command with no docs/user entry, and the docs index still called the background service Linux-only after launchd support landed. Found by PR #61 code review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Signed-off-by: aoright <102943475+aoright@users.noreply.github.com> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Nick Anisimov <n.anisimov.23@gmail.com> Co-authored-by: Maslin Edwin <maslinje@gmail.com> Co-authored-by: aoright <102943475+aoright@users.noreply.github.com> Co-authored-by: Guilherme Barros <gbarros1095@gmail.com> Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com> Co-authored-by: Rishet11 <154429365+Rishet11@users.noreply.github.com> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> Co-authored-by: Augie <augie@luebbers.email> Co-authored-by: Taras <Taras.Fomin@gmail.com> Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com> Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Chris Deeming <chris@xenforo.com> Co-authored-by: Inaya Yousfi <zied.essaber@gmail.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com> Co-authored-by: GPT-5.6 <noreply@openai.com>

Safari on Apple Silicon reports its WebGL renderer as
Apple GPU. The homepage treated that value as unknown and selected the x64 DMG, so M-series Macs downloaded the Intel build.The detector now classifies Safari’s generic Apple GPU renderer as arm64 after it checks explicit Intel, AMD, Radeon, Nvidia, and GeForce markers. An unavailable renderer still falls back to x64. A focused test covers the Safari value.
Tested with:
vp test run apps/marketing/src/lib/macArch.test.tsvp run --filter @t3tools/marketing typecheckCreated by GPT-5.6 using the Codex harness in T3 Code.
Note
Low Risk
Small change to client-side download arch detection on the marketing site; no auth, data, or backend impact.
Overview
Safari on Apple Silicon often reports WebGL as
Apple GPU, which previously missed the Apple Silicon regex and fell through to the x64 default—so the marketing homepage could offer the Intel DMG on M-series Macs.macArchFromGpuRenderernow treatsapple gpu(alongsideapple m*chips) as arm64, still after Intel/AMD/Nvidia-style markers so hybrid strings like ANGLE + Intel stay x64. Empty or unavailable renderer values still default to x64 for Intel compatibility. Tests split the Safari case from the empty-renderer fallback.Reviewed by Cursor Bugbot for commit 231cc01. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix Safari browser to receive arm64 Mac download by matching 'Apple GPU' renderer
Safari reports
Apple GPUas the WebGL renderer string instead of a specific chip name likeApple M1. TheAPPLE_SILICON_GPU_PATTERNregex in macArch.ts is expanded from\bapple\s+m\dto\bapple\s+(?:m\d|gpu)\bsoApple GPUnow maps toarm64instead of falling back tox64.Macroscope summarized 231cc01.