Skip to content

fix(marketing): Safari gets the arm64 Mac download - #7473

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/fix-arm64-download-detection
Aug 19, 2026
Merged

fix(marketing): Safari gets the arm64 Mac download#7473
t3dotgg merged 1 commit into
mainfrom
t3code/fix-arm64-download-detection

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Aug 19, 2026

Copy link
Copy Markdown
Member

Safari on Apple Silicon reports its WebGL renderer as Apple GPU. The homepage treated that value as unknown and selected the x64 DMG, so M-series Macs downloaded the Intel build.

The detector now classifies Safari’s generic Apple GPU renderer as arm64 after it checks explicit Intel, AMD, Radeon, Nvidia, and GeForce markers. An unavailable renderer still falls back to x64. A focused test covers the Safari value.

Tested with:

  • vp test run apps/marketing/src/lib/macArch.test.ts
  • vp run --filter @t3tools/marketing typecheck

Created by GPT-5.6 using the Codex harness in T3 Code.


Note

Low Risk
Small change to client-side download arch detection on the marketing site; no auth, data, or backend impact.

Overview
Safari on Apple Silicon often reports WebGL as Apple GPU, which previously missed the Apple Silicon regex and fell through to the x64 default—so the marketing homepage could offer the Intel DMG on M-series Macs.

macArchFromGpuRenderer now treats apple gpu (alongside apple m* chips) as arm64, still after Intel/AMD/Nvidia-style markers so hybrid strings like ANGLE + Intel stay x64. Empty or unavailable renderer values still default to x64 for Intel compatibility. Tests split the Safari case from the empty-renderer fallback.

Reviewed by Cursor Bugbot for commit 231cc01. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Safari browser to receive arm64 Mac download by matching 'Apple GPU' renderer

Safari reports Apple GPU as the WebGL renderer string instead of a specific chip name like Apple M1. The APPLE_SILICON_GPU_PATTERN regex in macArch.ts is expanded from \bapple\s+m\d to \bapple\s+(?:m\d|gpu)\b so Apple GPU now maps to arm64 instead of falling back to x64.

Macroscope summarized 231cc01.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ebb7df45-0c49-4a5b-8ca7-72f42ae4fe70

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 19, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 231cc01. Configure here.

Comment thread apps/marketing/src/lib/macArch.ts
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 12.6 KiB 12.6 KiB +11 B (+0.1%) 15.1 KiB
Codex Thread snapshot wire 6.3 KiB 6.3 KiB +4 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.3 KiB 6.3 KiB +7 B (+0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 51.8 KiB 51.8 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 12.6 KiB 12.6 KiB +8 B (+0.1%) 15.1 KiB
Claude Thread snapshot wire 6.3 KiB 6.3 KiB +1 B (+0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.3 KiB 6.3 KiB +7 B (+0.1%) 7.8 KiB
Claude Live turn WebSocket decoded 52.7 KiB 52.7 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 324ddda · PR result: 231cc01 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 99.9 KiB
  • Claude decoded thread snapshot: 100.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes Safari's 'Apple GPU' renderer detection from x64 to arm64, affecting which Mac download users receive. An unresolved review comment raises a valid concern that Intel Safari users may receive incompatible arm64 builds, since 'Apple GPU' is reported on both Intel and Apple Silicon Macs.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 5ea5a80 into main Aug 19, 2026
17 checks passed
@t3dotgg
t3dotgg deleted the t3code/fix-arm64-download-detection branch August 19, 2026 03:47
sheehanmunim added a commit to munimtechnologies/mtcode that referenced this pull request Aug 19, 2026
…#7473, pingdotgg#7477

The add-surface menu takes upstream's data-driven action list and its
keyboard shortcuts (pingdotgg#7318); the fork's per-profile Browser submenu rides on
top of the Browser entry, so one click still opens the default profile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 19, 2026
## What's Changed
* fix(marketing): Safari gets the arm64 Mac download by @t3dotgg in pingdotgg/t3code#7473
* feat(web): add shortcuts to the surface dropdown by @gsimone in pingdotgg/t3code#7318
* fix(marketing): never serve the Intel build to Apple Silicon Macs by @t3dotgg in pingdotgg/t3code#7477
* fix(web): animate command palette when closing by @tarik02 in pingdotgg/t3code#5169


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260819.1130...v0.0.34-nightly.20260819.1132

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260819.1132
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 19, 2026
roughcoder added a commit to goodbirdhq/phoenix that referenced this pull request Aug 20, 2026
* test(web): remove duplicate lookup assertion (pingdotgg#7364)

* fix(mobile): show structured input option descriptions (pingdotgg#7321)

* fix(orchestration): do not revive idle tasks from status-free progress (pingdotgg#7172)

* refactor(server): simplify error transformation with Effect.mapError in GitHubPullRequestCli (pingdotgg#7385)

Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>

* fix(preview): open local environment ports on localhost (pingdotgg#7300)

* fix(desktop): prevent quit shortcut spillover (pingdotgg#7397)

* fix(desktop): stop overwriting a custom dock icon on launch (pingdotgg#7125)

* feat(web): show project location in new thread picker (pingdotgg#7392)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

* fix(packaging): install AUR launcher icons where icon themes look (pingdotgg#7421)

* fix(web): label pull request merge actions (pingdotgg#7381)

* fix(server): avoid PRs inherited from default upstreams (pingdotgg#7317)

* fix(desktop): stop the passkey dialog from popping as soon as sign-in opens (pingdotgg#7437)

* feat(desktop): mute a browser tab (pingdotgg#7252)

* fix(web): improve disconnected composer placeholder (pingdotgg#7122)

Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>

* fix(desktop): throttle hidden preview rendering (pingdotgg#7445)

Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>

* fix(server): stop probing Grok, Cursor, and OpenCode unless turned on (pingdotgg#7459)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(desktop): boot the main window unthrottled so cold start paints at full speed (pingdotgg#7460)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(threads): a merged PR settles its thread only once (pingdotgg#7454)

* feat(cli): npx t3 triage hands broken installs to your own coding agent (pingdotgg#6563)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(marketing): Safari gets the arm64 Mac download (pingdotgg#7473)

* feat(web): add shortcuts to the surface dropdown (pingdotgg#7318)

* fix(marketing): never serve the Intel build to Apple Silicon Macs (pingdotgg#7477)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): animate command palette when closing (pingdotgg#5169)

* fix(desktop): upgrade Clerk OAuth transport (pingdotgg#7479)

* feat(server): run the background service on macOS via launchd (pingdotgg#6286)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): align sidebar statuses with project names (pingdotgg#7491)

Co-authored-by: GPT-5.6 <noreply@openai.com>

* fix(desktop): close the window before quit cleanup (pingdotgg#6562)

* fix(desktop): stop automatic passkey prompts (pingdotgg#7522)

* docs(user): document phoenix triage and macOS background service

The 2026-08-19 upstream sync added the triage command with no docs/user
entry, and the docs index still called the background service Linux-only
after launchd support landed. Found by PR #61 code review.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Nick Anisimov <n.anisimov.23@gmail.com>
Co-authored-by: Maslin Edwin <maslinje@gmail.com>
Co-authored-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com>
Co-authored-by: Rishet11 <154429365+Rishet11@users.noreply.github.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Augie <augie@luebbers.email>
Co-authored-by: Taras <Taras.Fomin@gmail.com>
Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Chris Deeming <chris@xenforo.com>
Co-authored-by: Inaya Yousfi <zied.essaber@gmail.com>
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com>
Co-authored-by: GPT-5.6 <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant