refactor(server): simplify error transformation with Effect.mapError in GitHubPullRequestCli

[aoright]

Summary

• In apps/server/src/pullRequest/GitHubPullRequestCli.ts, replace filesPage(1).pipe(Effect.catch(() => Effect.fail(error))) with filesPage(1).pipe(Effect.mapError(() => error)).
• Expresses the error transformation directly in idiomatic Effect syntax.

---

Note

Low Risk
Single-line Effect refactor in error handling for an existing fallback path; behavior should be unchanged.

Overview
In getPullRequestDiff, when gh pr diff fails with GitHubCliCommandError and the code retries via the files API (filesPage(1)), a failed fallback still surfaces the original CLI refusal—not the files-page error.

The implementation switches from Effect.catch(() => Effect.fail(error)) to Effect.mapError(() => error), which expresses the same “replace fallback failure with the caught error” behavior in more idiomatic Effect style. No intended runtime behavior change.

^{Reviewed by Cursor Bugbot for commit d7e4b6c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Simplify error handling in GitHubPullRequestCli fallback path using Effect.mapError

Replaces Effect.catch(() => Effect.fail(error)) with Effect.mapError(() => error) on the filesPage(1) call in GitHubPullRequestCli.ts. Both approaches map any error from filesPage(1) to the original GitHubCliCommandError, but mapError is more idiomatic and concise.

^{Macroscope summarized d7e4b6c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c109d19-d542-4eba-b185-97549d1ee7bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at d7e4b6c

Macroscope's review found this PR approvable — This is a mechanical simplification replacing Effect.catch(() => Effect.fail(error)) with the equivalent Effect.mapError(() => error). Both have identical runtime semantics - the change is purely stylistic with no behavioral impact.

^{You can add or adjust custom eligibility rules. Learn more.}