test(web): remove duplicate lookup assertion - #7364
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved 9cd1dc2 Test-only change that removes a duplicate assertion line. No runtime behavior is affected. You can customize Macroscope's approvability policy. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 18, 2026
## What's Changed * test(web): remove duplicate lookup assertion by @t3-code[bot] in pingdotgg/t3code#7364 * fix(mobile): show structured input option descriptions by @none23 in pingdotgg/t3code#7321 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260817.1120...v0.0.34-nightly.20260818.1124 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260818.1124
sheehanmunim
pushed a commit
to munimtechnologies/mtcode
that referenced
this pull request
Aug 18, 2026
sheehanmunim
added a commit
to munimtechnologies/mtcode
that referenced
this pull request
Aug 18, 2026
…otgg#7172 already cherry-picked
NeilTheFisher
pushed a commit
to NeilTheFisher/t3code
that referenced
this pull request
Aug 18, 2026
frankdavidcorona
pushed a commit
to frankdavidcorona/t3code
that referenced
this pull request
Aug 18, 2026
bcotrim
pushed a commit
to bcotrim/mognet
that referenced
this pull request
Aug 20, 2026
(cherry picked from commit 3723722)
roughcoder
added a commit
to goodbirdhq/phoenix
that referenced
this pull request
Aug 20, 2026
* test(web): remove duplicate lookup assertion (pingdotgg#7364) * fix(mobile): show structured input option descriptions (pingdotgg#7321) * fix(orchestration): do not revive idle tasks from status-free progress (pingdotgg#7172) * refactor(server): simplify error transformation with Effect.mapError in GitHubPullRequestCli (pingdotgg#7385) Signed-off-by: aoright <102943475+aoright@users.noreply.github.com> * fix(preview): open local environment ports on localhost (pingdotgg#7300) * fix(desktop): prevent quit shortcut spillover (pingdotgg#7397) * fix(desktop): stop overwriting a custom dock icon on launch (pingdotgg#7125) * feat(web): show project location in new thread picker (pingdotgg#7392) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> * fix(packaging): install AUR launcher icons where icon themes look (pingdotgg#7421) * fix(web): label pull request merge actions (pingdotgg#7381) * fix(server): avoid PRs inherited from default upstreams (pingdotgg#7317) * fix(desktop): stop the passkey dialog from popping as soon as sign-in opens (pingdotgg#7437) * feat(desktop): mute a browser tab (pingdotgg#7252) * fix(web): improve disconnected composer placeholder (pingdotgg#7122) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> * fix(desktop): throttle hidden preview rendering (pingdotgg#7445) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> * fix(server): stop probing Grok, Cursor, and OpenCode unless turned on (pingdotgg#7459) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(desktop): boot the main window unthrottled so cold start paints at full speed (pingdotgg#7460) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(threads): a merged PR settles its thread only once (pingdotgg#7454) * feat(cli): npx t3 triage hands broken installs to your own coding agent (pingdotgg#6563) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(marketing): Safari gets the arm64 Mac download (pingdotgg#7473) * feat(web): add shortcuts to the surface dropdown (pingdotgg#7318) * fix(marketing): never serve the Intel build to Apple Silicon Macs (pingdotgg#7477) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): animate command palette when closing (pingdotgg#5169) * fix(desktop): upgrade Clerk OAuth transport (pingdotgg#7479) * feat(server): run the background service on macOS via launchd (pingdotgg#6286) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): align sidebar statuses with project names (pingdotgg#7491) Co-authored-by: GPT-5.6 <noreply@openai.com> * fix(desktop): close the window before quit cleanup (pingdotgg#6562) * fix(desktop): stop automatic passkey prompts (pingdotgg#7522) * docs(user): document phoenix triage and macOS background service The 2026-08-19 upstream sync added the triage command with no docs/user entry, and the docs index still called the background service Linux-only after launchd support landed. Found by PR #61 code review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Signed-off-by: aoright <102943475+aoright@users.noreply.github.com> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Nick Anisimov <n.anisimov.23@gmail.com> Co-authored-by: Maslin Edwin <maslinje@gmail.com> Co-authored-by: aoright <102943475+aoright@users.noreply.github.com> Co-authored-by: Guilherme Barros <gbarros1095@gmail.com> Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com> Co-authored-by: Rishet11 <154429365+Rishet11@users.noreply.github.com> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> Co-authored-by: Augie <augie@luebbers.email> Co-authored-by: Taras <Taras.Fomin@gmail.com> Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com> Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Chris Deeming <chris@xenforo.com> Co-authored-by: Inaya Yousfi <zied.essaber@gmail.com> Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com> Co-authored-by: GPT-5.6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
claimWorkspaceBasenameLookup's single-claim test called the same predicate twice in a row and assertedtrueboth times.change
removed only the second, identical assertion.
evidence
verification
./node_modules/.bin/vp test run apps/web/src/workspaceBasenameLookup.test.tspassed, 1 file and 10 tests./node_modules/.bin/vp test run apps/web/src/workspaceBasenameLookup.test.tspassed, 1 file and 10 tests./node_modules/.bin/vp lint apps/web/src/workspaceBasenameLookup.test.ts --report-unused-disable-directivespassed./node_modules/.bin/vp run --filter @t3tools/web typecheckpassed./node_modules/.bin/vp fmt --check apps/web/src/workspaceBasenameLookup.test.tspassedgit diff --checkpassedmade with gpt-5.6-sol via hermes agent.
Note
Low Risk
Test-only change with no production code or behavior impact.
Overview
Test cleanup in
workspaceBasenameLookup.test.ts: the"stays valid while it is the only claim"case no longer asserts the claim predicate twice with the same expectation.The remaining assertion still verifies that a lone
claimWorkspaceBasenameLookup()returns a predicate that evaluates totrue. The dropped call duplicated the same branch with no extra claim or state change.Reviewed by Cursor Bugbot for commit 9cd1dc2. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove duplicate assertion in
claimWorkspaceBasenameLookuptestRemoves a redundant second call to the same claim function in the "stays valid while it is the only claim" test in workspaceBasenameLookup.test.ts. The test now asserts validity once instead of twice.
Macroscope summarized 9cd1dc2.