Repository navigation
Deploy Checklist: New Expensify 2023-06-16 #20928
Description
Release Version: 1.3.29-11
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Fix: Resend magic code option behaves inconsistently #18632
- Fix Form useEffect #20091
- Migrate Checkbox.js to function component #20193
- Immediately remove messages flagged as assault or harassment #20223
- Add Mark as Read/Unread option to LHN Context menu #20254
- 17060 - migrated ImageView to PressableWithoutFeedback #20269
- Start personalDetails migration to *List #20323
- Continue
personalDetails->personalDetailsListmigration #20328 - Tests fixed for "beaman-continueMigration" branch #20351
- fix: fixing failing tests for
OptionsListUtilsandReportUtilssuites #20371 - Policy members keyed by accountID #20397
- Fix: On delete Message hide un-actionable items #20460
- Main
personalDetailsList&policyMembersOnyx key migrations #20473 - [NO QA] Migrate Expensify guide & employee emails checks #20474
- Finish policy members migration #20482
- Personal details migration todos #20506
- [Personal details list migration] fix: TODOs in
OptionsListUtilsandPolicyUtils#20508 - PasswordForm Function Migration #20515
- [NO QA] Send logins in openReport API command #20547
- Fix email and default avatar shows on detail split bill page #20573
- [Personal Details List migration]fix: show search value when searching for new account #20576
- Fix: Chat - Email address is displayed instead of 'You' when pulling up the reaction detail #20584
- Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649
- fix send money - green payment button is visible bug #20655
- fix: bug 2 for Personal details list migration #20661
- Personal details migration - bug 3: LHN groups showing current user name #20662
- fix: bug6 for Personal details list migration #20665
- Remove redundant error messages for report actions #20666
- Personal details migration - bug 4: app displays old name in LNH for some time after posting new comment #20668
- Personal details list migration: fix
Header not displayed while sending money#20679 - Personal details list migration: fix Thread related bugs #20691
- Details page function migrate #20702
- fix: prevent welcome message showing up on abradacabra page #20706
- Add
failureDatatoAddWorkspaceRoomAPI command #20734 - Fix: Uppercase zipcode before validating or submiting #20735
- Fix unable to open reaction list after coming back from another chat #20739
- fix: 20412 new user is not navigating to concierge chat after tab on link #20740
- Update en.js #20744
- Add tooltips and nav to bill details #20746
- Personal details list migration: fix type error related ot avatar of anon users #20748
- Personal details list migration: fix create room console errors #20750
- Personal details list migration: fix IOU report header and undefined in money request LHN #20752
- Personal details list migration: revert fallback for getDisplayNameForParticipant #20753
- fix: update expensify-common to fix italic syntax removing a preceding character #20769
- Personal details list migration: use accountID (number) in setContactMethodAsDefault #20792
- Show green dot for uncompleted tasks assigned to current user #20808
- fix: dispatch pop always at the root state #20815
- [Fix] Missing Email in Workspace invite page #20823
- fix: select all workspace invite comparison #20826
- Update es.js #20833
- Fix condition for welcome messages #20837
- Fix: Wrong text color for our mention #20845
- Update Everything-About-Chat.md #20846
- Fix: Mention is selected as anchor tag #20894
- Handle nonexistent login and get correct avatar #20897
- [CP Staging] Make sure that we first check the PersonalDetails we already have before creating fake optimistic personal details #20951
- Fix: Error message "Can't remove admin" isn't shown when selecting workspace admins #21023
- fix avatar tooltip issues across the app #21026
- Fix Mentions crash #21030
- [Fix] New Room participants list is empty #21072
- Use new path for share url #21081
- Fix split bill display / selection with new users #21113
- Fix: Search - Group chat displays blank in Search results #21148
- personalDetails.login can be missing for new accounts #21150
- Only consider personal details with logins set in
OptionsListUtils.getOptions#21159
Internal QA:
Deploy Blockers:
- [HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Not able to sign up with a new account #20676
- [HOLD for payment 2023-06-29][$1000] Error message "Can't remove admin" isn't shown when selecting workspace admins #20809
- [HOLD for payment 2023-06-28] Font color is blue instead of white in mention #20819
- [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Tooltip not present on multiple avatar groups #20934
- No error on selecting the admin in workspace members page #20939
- "__fake__" appears on LHN after flagging a content #20940
- [C+ payment] New group - Users' avatars appear only after some moment #20943
- Connect Bank Account - Checkbox is checked after returning to previous stage #20950
- Security - Endless spinner when try to close account #20955
- [HOLD for payment 2023-06-29] CRITICAL [SNH]: Chat - Status “User is typing” shows the email instead of the username #20956
- Workspace - New users invited to WS are not displayed in members list but chats are created for them #20961
- Web - Log in - The skeleton is displayed in the concierge chat after log in with a new account #20962
- IOS - Search - App is crashed when taping something on search results #20963
- [$500] Web- Split bill - Unable to split the money with new users in a group #20964
- [REPORTING BONUS PAYMENT] [Hold Auth #8141] Web - Search - Two concierge chats and user's own account appears in search #20965
- Web - Split Bill - No details shown on split bill details page of a new user (only profile picture is shown) #20966
- [HOLD for payment 2023-06-28] [$1000] New member as Hidden shows while create new room in offline mode #20967
- [HOLD for payment 2023-06-29] App crashes when trying to use mention
@#20969 - The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill. #20970
- [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Concierge - Concierge icon is not displaying in popup #20971
- Workspace - 'Track distance' has rate = 0 and endless spinner is shown instead of block ‘Unlock next-day reimbursements’ #20977
- [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Incomplete Member Information Displayed When Hovering Over Photos in Admin Rooms #20981
- Inconsistency in email font size when hovering over email and photo in group members section #20982
- User is able to request an IOU from Concierge #20991
- email address displayed in tooltip goes out of border when hovering over images #20992
- [$1000] [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Avatar is not loading when opening a 'share code' link #20993
- Android - Chat - Avatar and welcome message disappear after creating a new not existing account #20994
- Room - After creating the room, 504 error appeared in the console for a minute later. #20995
- Split bill - Can't select more than few users under specific Gmail account login #21002
- Default profile avatar is show instead of profile avatar for brief time in reply thread #21032
- App displays "Hidden" instead of email for group members #21035
- new chat does not reflect immediately for new account #21036
- Admin also appears in the "invite new members list in workspace #21037
- Email not shown for new user in the contact method (on Profile page) #21039
- [HOLD for payment 2023-06-29] Web - Group chat - "Invalid email" error message appears when creating a group DM with Concierge #21040
- [HOLD] Chat - Unable to access deleted group member profile #21041
- [$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits #21044
- [HOLD for payment 2023-06-29] Selecting/removing one user selects/removes all the user on split bill group page #21075
- [$1000] Admin is selected when Clicking Select all #21079
- New Group - Unknown broken contact is added to group when selecting contacts with only avatars #21086
- [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Workspace - App is crashing when added to WS several existing users with names/avatars + new user #21112
- [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] [$1000] Search - Group chat displays blank in Search results #21127
- Chat - Unable to find user monil@expensifail.com #21135
- App crashes when you search any value on a fresh new public account #21149
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jun 16, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.29-0 🚀
esh-g commentedon Jun 16, 2023
Just a heads up, QA for the above PR will not be successful currently due to failure in a underlying method. But that will get fixed in #20934
After which I expect it work properly
Beamanator commentedon Jun 18, 2023
Checking off these since they're part of this bigger App PR (they weren't PRs into
main):OptionsListUtilsandPolicyUtils#20508Header not displayed while sending money#20679OSBotify commentedon Jun 19, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.29-1🚀OSBotify commentedon Jun 19, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-1 has been deployed to staging 🎉
OSBotify commentedon Jun 19, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.29-2🚀OSBotify commentedon Jun 19, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-2 has been deployed to staging 🎉
Julesssss commentedon Jun 19, 2023
I don't believe #21037 is a blocker, so I removed the label and checked it off. But @luacmartins please review again in case anyone has been able to reproduce after I signed off (and we also think it. is important enough to block the release).
mvtglobally commentedon Jun 19, 2023
Regression is completed
PR #20193 is failing #20950
PR #20223 is failing #20940
PR #20702 is failing #20969
PR #20706 is failing #20999
PR #20746 is failing #20970
PR #20750 is failing #20995
PR #20823 is failing #20803
PR #20826 is failing #20939
PR #20837, #21023,, #21026 testing
Beamanator commentedon Jun 19, 2023
Checking off #20971 b/c the fix was pushed to staging & tests passed on staging
50 remaining items
luacmartins commentedon Jun 20, 2023
Checking off #20940 as per this comment
luacmartins commentedon Jun 20, 2023
Checking off #20966 as per this comment
luacmartins commentedon Jun 20, 2023
Checking off #21044 as per this comment
luacmartins commentedon Jun 20, 2023
Checking off #21002 as per this comment
luacmartins commentedon Jun 20, 2023
Checking off #21148 as per this comment
OSBotify commentedon Jun 20, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.29-10🚀OSBotify commentedon Jun 20, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-10 has been deployed to staging 🎉
luacmartins commentedon Jun 20, 2023
Checking off #20223 since we demoted the fix to not a blocker.
OSBotify commentedon Jun 21, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.29-11🚀luacmartins commentedon Jun 21, 2023
Checking off #21150. I tested on staging and it's a pass.
OSBotify commentedon Jun 21, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-11 has been deployed to staging 🎉
luacmartins commentedon Jun 21, 2023
Checking off #21159 and #21040. I tested on staging and it's a pass.
luacmartins commentedon Jun 21, 2023
Checklist is clear. Kicking off the deploy,
luacmartins commentedon Jun 21, 2023