Repository navigation
Deploy Checklist: New Expensify 2023-07-31 #23945
Description
Release Version: 1.3.48-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
- fix: do not escape HTML special chars for an invite's welcomeNote #21912
- refactored BasePaymentsPage to function based component #22412
- Update dynamically attachment modal #22543
- form: never have value prop for input as undefined #22589
- Reusable function instead of repetitive statements #22649
- Migrate BasePicker to function component #22788
- [Step 1] Temporarily support both fundList and cardList ONYX keys #23242
- fix: 22058 delay in transitioning from hand cursor to now allowed sign #23336
- Fix console error when validating/unlinking secondary account #23469
- fix: header message for already invited member of workspace #23490
- [NoQA] Replace the moment library with date-fns: Add library, add tests #23520
- Hide All Muted Chats #23521
- fix crash when trying to unlink secondary contact #23561
- Migrate DragNDrop #23589
- fix: show main composer when there is no focused draft #23618
- Fix wrong last accessed report #23625
- Only render ReportActionItemReactions if there are reactions #23671
- Fix bankAccountID not being passed on manual BA connect #23677
- Remove blue border from Ondifo buttons on hover #23699
- Use stateNum to determine report state #23700
- Fix report total update #23701
- Fixed offline Android overlapping icons #23710
- Fix/21929 - Hide context menu from LHN window resize #23728
- Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734
- [NoQA] Perf/onyx upgrade use cache directly #23749
- Upload optimized lottie JSON files #23776
- Fix: Wrong translation of
paidin LHN after deleting last message #23778 - Fix reaction appears for deleted message #23782
- Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815
- fixed navigateToAddPaypalRoute issue #23816
- Return null for native Drag and Drop consumers to prevent Drag UI on native #23829
- fix: add no dropzone only if RHN is active #23856
- [CP Staging] Return early when dismissing modal so we don't call
onNavigatewith no attachments #23988 - [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003
Deploy Blockers:
- [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Pressing Enter key on Split bill page doesn't navigate to next step #23950
- [HOLD for payment 2023-08-10] App crashes when clicking 'Split bill' button for newly created account #23951
- [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [$1000] IOU - Double "request money" tab if request money #23962
- [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Chat - Crash when deleting attachment from user B when user A has open attachment modal #23964
- Pay elsewhere button is shown after deleting requested money #23966
- Chat - Concierge chat won't load when open concierge link and sign in #23968
- Not Allowed sign is not shown when dragging attachments on LHN #23969
- [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] IOU - When a new IOU is opened, the sum of the previous IOU is displayed in the modal window #23973
- [HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA #24005
- [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Home address - Page constantly crashes if insert values and quit the app #24006
- mWeb Android/Chrome - Compose box is hidden when we delete edited message #24016
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jul 31, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.48-0 🚀
mvtglobally commentedon Jul 31, 2023
#22543 is failing #23964
roryabraham commentedon Aug 1, 2023
Checking off #23969 as NAB
Beamanator commentedon Aug 1, 2023
Checking off #23966 since we agreed it's not a blocker
Beamanator commentedon Aug 1, 2023
Checking off #23968 b/c i couldn't reproduce at all in staging
mvtglobally commentedon Aug 1, 2023
@Beamanator We are down to last 10% of the TR regression and a few PRs.
Current summary
#21912 pending validation on all platforms
#22543 is failing #23964
#22649 pending validation on all platforms
#22788 pending validation on all platforms
#23242 (comment) can you QA this internally?
#23778 is failing #21959, repro in PROD
#23815 is failing #23973
#23856 pending validation on all platforms
Beamanator commentedon Aug 1, 2023
Thanks very much @mvtglobally !
Just to be clear,
pending validation on all platformsmeans your team is still working on testing those, right? Nothing for me to do there?#23242 - I asked Georgia to help test in staging 🙏
Looks like the other failing items have PRs in progress to fix 🚀
mvtglobally commentedon Aug 1, 2023
@Beamanator correct. We are still testing and will update once done
Beamanator commentedon Aug 1, 2023
Amazing, thanks so much! 👍
Beamanator commentedon Aug 1, 2023
Great, this means we can check #23778 off the list, no?
mvtglobally commentedon Aug 1, 2023
@Beamanator We are down to last 1% of the TR regression and 1 PR.
Current summary
#22649 & #23856 checked off
#21912 pending validation on all platforms
#22543 is failing #23964
#22788 is failing #23768 & #23997
#23815 is failing #23973
Beamanator commentedon Aug 1, 2023
Checked off #23964 (was DB) and #22543
onNavigatewith no attachments #23988Beamanator commentedon Aug 1, 2023
latest version is now 1.3.48-3 - https://expensify.slack.com/archives/C07J32337/p1690906010777539
Beamanator commentedon Aug 1, 2023
Checking off all 5 issues fixed by #24003 👍
Also checking off these PRs which failed due to issues fixed ^:
Beamanator commentedon Aug 1, 2023
@mvtglobally is #21912 still in the process of being tested?
mvtglobally commentedon Aug 1, 2023
@Beamanator TR is completed.
#21912 is only left Android. Rest platforms are pass.
Since this need to receive SMS, we need Device/phone combination, so it takes a bit longer to cover. If you can validate Android internally, we are all done then.
mvtglobally commentedon Aug 1, 2023
potential Blocker incoming.. https://expensify.slack.com/archives/C049HHMV9SM/p1690903191529089
puneetlath commentedon Aug 1, 2023
Checking off #23988 since @Beamanator confirmed it was working on staging.
puneetlath commentedon Aug 1, 2023
Checking off #24003 since it's a revert and all deploy blockers that it was supposed to fix have been checked off.
puneetlath commentedon Aug 1, 2023
Checking off #24005 since @tgolen confirmed it's working.
puneetlath commentedon Aug 1, 2023
Checking off #24016 as I confirmed that the revert that was CP'd here worked.
puneetlath commentedon Aug 1, 2023