Repository navigation
Deploy Checklist: New Expensify 2023-10-11 #29252
Description
Release Version: 1.3.81-9
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Fix spaces #2
- Add Expensify eslint #3
- Fix incorrect navigation when update Report welcome message after visit by direct link #25543
- fix: background image clipping on extra wide screens #26078
- Fix country flags not searchable in spanish language #26200
- Fix Chat - Notification is NOT received in the main device after Control policy was created #26358
- Show notification instead of login page when user has another tab open - #26161 #27385
- [No QA][TS migration] Migrate 'RenamePriorityModeKey.js' lib to TypeScript #27500
- Only add the new emojis to the frequent emojis list by doing a difference between former and new emojis #27687
- Allow Adding a category to a Split Bill #27936
- [TS migration] Migrate 'NetworkConnection.js' lib to TypeScript #28016
- Fix unread marker showing double lines on task comment #28146
- [NoQA] feat: Remove moment from the project (Except Datepicker) #28175
- Add notification preference for all the reports and update the design for the group chats #28200
- [ECard Transactions] Update
TransactionsandReportTS Types #28246 - @swm/global nav menu v1 #28277
- activate physical card #28313
- Bring back send money option for newDot #28321
- Update Plan-Types.md #28348
- Add Hover to TabItem #28357
- [NoQA] Safely catch translation key when it's wrong or missing #28377
- Fix inconsistent margins for reacted emojis to code-block comments #28387
- Create Add-a-Deposit-Account-(AUD).md #28397
- Profile pic error should display I cursor and allow to select and copy the text #28443
- Check a category before adding to recently used categories on Money Request #28475
- Fix navigation breaks on opening search page after reloading the attachment #28486
- Update Account-Details.md #28505
- Update Invoicing.md #28511
- fix: update add leading zero to delete digit before decimal #28567
- Improve memoization of LHN by handling the isFocused prop better #28615
- Fix Android camera permission prompt #28619
- Allow Viewing a category to a Split Bill #28628
- Refactor how data is loaded into the edit request page #28645
- Fix inconsistent font weight between android and other platforms. #28678
- Update QuickBooks-Desktop.md #28679
- Fix/27779: Expand button disappear after clicking send #28681
- fix: 28340 Focus freeze on add contact method magic code on coming back from search #28682
- Update Attendee-Tracking.md #28728
- build: upgrade to react-native-key-command 1.0.6 #28733
- Update Tax-Exempt.md #28746
- Adding Expensify Card dispute help site article #28755
- [NoQA] Reattempt using OSBotify installation token in actions #28773
- fix: align checkbox with input levels #28785
- fix: Reactions in thread do not update parent action #28796
- Fix: RBR - Deleted error notifications reappear after reloading #28810
- fix empty display name when access deep link #28842
- Disable SelectCircle for current user in split bill #28850
- [NoQA] Access the report action safely in notification logic #28880
- Fix not all split bills are registered when leaving offline mode #28882
- Update appropriate message for legal name validation. #28892
- Fix/27776 Workspace - WS invite page keeps loading in offline if no members present #28897
- [NO QA] Add screenshot/video section to standard issue template #28903
- Fix load more message skeletons aren't showing #28905
- [NoQA] Add the "auto reporting" and "submitted" state as const to the App #28906
- [NoQA] feat: show submit button in Report preview for open/draft reports #28918
- [TS migration] Migrate 'useThrottledButtonState.js' hook to TypeScript #28920
- [NoQA] Feat: Add submit action #28947
- import moment for es locale #28948
- prevent focusing on composer while popover is open #28953
- fix: Workspaces - Cursor opacity is not reduced when checkbox is disabled #28957
- [NoQA] Update Adhoc Provisioning profile #28972
- fix cursor default when menu can not clickable #28973
- Create Xero Integration HelpDoc Article #28975
- Fix opens two "Flag as offensive" list #28978
- last message fetch using optimistic actions #28980
- Implement Iframe component #28981
- Fix: adding parentheses after link removes link #28985
- Add optimistic data to archive workspace chats when remove members #28987
- Fixing zoom and google items being accessible after room achieving #28992
- [No QA]Add card transactions helper functions and mcc icons #28993
- [NoQA] feat: show submit button in MoneyReportHeader when report is in draft #28998
- Images for Expensify Card Statement Help Site Rewrite #29018
- [No QA][TS migration] Migrate 'usePrevious.js' hook to TypeScript #29019
- text align for main tooltip #29025
- fix: close modal simply when waypoints not changed in edit distance request #29047
- fix: extra space when code added to private note #29055
- Edit Message Box Style Fixes #29059
- Delete request pop-up does not close when requestee pays the money request #29068
- feat(27641): Performance tests of LHN with Reassure #29083
- fix: prevent refocusing in options-selector and selection-list #29084
- Set
authTokenandemailcookies from NewDot #29089 - [CP Staging] Revert "fix: 26657 Another error message for a short time when opening archived chat from search bar" #29106
- Fix: 28988 parent for subcategories can be selected with arrow keys #29111
- Fix #28748 and Remove catching error in
SaveResponseInOnyx#29117 - fix delete request confirmation modal title #29120
- Fix: Cursor is not consistent on input in help page #29121
- fix: LHN features twice in Acronyms, removed the duplicate #29124
- Revert "Initial fix" #29126
- fix welcome fab menu doesn't show up #29142
- Fix: show proper avatar and display name when hovering #29146
- Fix/28599: Pressing back while writting notes make text disappear #29149
- Fix code block font is not a monospace #29158
- Fix can't change currency when double click the currency symbol button #29161
- Updated room name regex to that accept the all lowercase letters using unicode and removed the à-ÿ range #29168
- Fix: Can click on the space on the right to change the default skin tone #29177
- Add repo setting to fix deploys #29224
- Fix crash on deep link request page #29227
- Revert "[NoQA] Reattempt using OSBotify installation token in actions" #29233
- Bring Save the world button back #29236
- [CP Staging] fix crash when first open contact profile page #29277
- [CP stag]Removed old code - multiplying amount to 100 in getSendMoneyParams #29353
- [CP Staging] Fix couple of bugs in the Send money flow #29358
Internal QA:
- Add
ScantoSplit Billand implement IOU action startSplitBill #28710 - @youssef-lr - add “Report virtual card fraud” page and route #28312 - @JKobrynski
Deploy Blockers:
- [HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Crash when opening uknown profile URL #29313
- Send money - Chat history goes blank and reloads when sending money in the chat #29316
- [HOLD for payment 2023-10-23][$500] Send money - Extra two digits are added before the decimal point when money is sent offline #29318
- [HOLD for payment 2023-10-25] [$250] Workspace - Display name for #announce room members in details page is cut off #29321
- [$100] Group chat - No tooltip when hovering over group member avatar in details page #29322
- Chat - Unavailable to access an account detail page via the header of conversation #29335
- [HOLD for payment 2023-10-27] [$250] Android - Send money - Send money deep link redirects to mobile browser instead of native app #29362
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363
- [$250] Send money - User can send money to group by modifying the URL to ../send/new/.. #29367
- [HOLD for payment 2023-11-09] [$500] IOU - Site crashes when editing a description with numbers after changing amount #29369
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Enter key does not work in Send money confirmation page #29373
- [HOLD for payment 2023-10-23] Distance - The merchant is displayed on the distance request page but not on the request report #29374
- [$500] Web - Send money - Save and continue button infinitely loading after entering additional details #29380
- Send money - Date is not saved when sending money #29381
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Sent money info can be edited when sent offline but changes are not saved online #29384
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
kavimuru commentedon Oct 11, 2023
Checked of the PRs from the past builds:
#25543
#26200
#26358
#27385
#27936
#28146
#28277
#28348
#28357
#28387
#28397
#28443
#28486
#28505
#28567
#28615
#28628
#28645
#28679
#28681
#28728
#28746
#28785
#28796
#28810
#28842
#28850
#28882
#28905
#28920
#28948
#28953
#28957
#28975
#28978
#28980
#28985
#28987
#28992
#29106
#29126
Checked of PRs related to help.expensify.com
#28511
#28755
#29121
kavimuru commentedon Oct 11, 2023
Regression 55% progress.
#29084 failing with #29003 (known issue) checking it off.
jasperhuangg commentedon Oct 11, 2023
Checking off #29362
kavimuru commentedon Oct 11, 2023
Regression is 83% progress.
#29084 failing with #29003 in android (Ok to check it off?)
#29277 failing with #29368 - repro in production.
amyevans commentedon Oct 11, 2023
Checked off #29318
jasperhuangg commentedon Oct 11, 2023
Checking off #29369
jasperhuangg commentedon Oct 11, 2023
Checking off #29363 via #29363 (comment)
jasperhuangg commentedon Oct 11, 2023
Checking off #29367
luacmartins commentedon Oct 11, 2023
Checking off #29380. Not an issue with NewDot.
marcaaron commentedon Oct 12, 2023
Checked off #28312 context -> #28312 (comment)
mvtglobally commentedon Oct 12, 2023
Regression is completed. Validating CPs
Open Blockers:
#29373
#29374
#29384
Unchecked PRs:
#29084 failing with #29003 in android (Ok to check it off?)
#29277 failing with #29368 - repro in production. Checking off
8 remaining items
jasperhuangg commentedon Oct 12, 2023
OSBotify commentedon Oct 12, 2023
Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!
jasperhuangg commentedon Oct 12, 2023
lol wat
jasperhuangg commentedon Oct 12, 2023
okayyy one more time!
And if you wanna know what's going on you can follow on from here onwards in #deployer
jasperhuangg commentedon Oct 12, 2023
jasperhuangg commentedon Oct 12, 2023
one more time
jasperhuangg commentedon Oct 12, 2023