Repository navigation
Deploy Checklist: New Expensify 2023-11-27 #32066
Description
Release Version: 1.4.4-3
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS Migration] Migrate 'ReportUtils.js' lib to TypeScript #29012
- Approving-Reports.md #29283
- [TS migration] Migrate 'DotIndicatorMessage.js' component to TypeScript #30353
- Promote referral program messaging in NewDot Settings > Share code #30436
- Automatically pan initial map based on current location #30506
- Update Pay-Bills.md #30660
- [13604] Run GHA workflow tests on each PR #30975
- [TS migration] Migrate RadioButton to Typescript #31050
- [TS migration] Migrate 'AutoCompleteSuggestions' component to TypeScript #31065
- [TS migration] Migrate 'Button' component to TypeScript #31102
- [Form Provider Refactor] AddDebitCardPage fixes #31133
- Fix: Extra padding between the header and address field in waypoint editor #31247
- Fix: Only the delete confirmation modal should close when pressing ESC button #31256
- Fix crash when opening a split bill preview on an #announce room #31291
- Allow editing card transactions (not amount) #31353
- [Form Provider Refactor] IdologyQuestions #31401
- Update QuickBooks-Online.md #31405
- [TS migration] Migrate 'withPolicyAndFullscreenLoading.js' HOC to TypeScript #31428
- Feature: Implement theme dependent illustrations (
useThemeIllustrationshook) #31452 - fix: Attachments reopen on multiple 'esc' click and hang on browser's navigation back #31524
- [NoQA] change ressure perf test workflow #31624
- [Form Provider Refactor] BankAccountPlaidStep #31629
-
SignInPagealways dark mode #31636 - Fix: multiple browser tab sign in bug #31662
- Web - Profile - When selecting the last country or state extra space is displayed for a while #31737
- Fix/30992: Workspace invitation message still preserved #31770
- [Form Provider Refactor] EditRequestMerchantPage #31772
- Remove released betas #31784
- Revert "[NoQA] change ressure perf test workflow" #31825
- [NoQA] fix(dev): e2e tests broken #31826
- [NoQA] enable perf tests for ReportScreen #31828
- revert ref forwarding logic in CheckboxWithLabel #31851
- Fix app crashing when cancelling a task in offline mode #31862
- Fix/button component after ts migration #31906
- Check cardID exists in cardList #32097
- Revert "[Form Provider Refactor] IdologyQuestions" #32138
Deploy Blockers:
- [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] IOU - Clicking on card and amount does not cause any action #32077
- [HOLD for payment 2024-01-24] [$500] Share code/Get $250 - Copy referral link is not activated using the Tab button #32080
- Web - Wallet - Cannot proceed with add bank account flow #32082
- [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] Wallet - On first try, SSN is verified after second attempt to submit the form #32083
- Wallet - SSN field is not filled after user hits back button #32085
- [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] Request money - Unable to edit money request from IOU #32086
- [HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question #32104
- Distance - IOU report for changed details, title is not shown in LHN when user re-login #32111
- [$500] Bank account - User is redirected to BA page when paying with Expensify and BA is set up #32112
- Share code/Get $250 - The label 'Copy referral link' is being captured within a frame #32118
- [$500] Wallet - Radio buttons in questionnaire page have a different design #32119
- [HOLD for payment 2023-12-29] Android - Distance - Location permission prompt reappears after declining it #32121
- Split bill - Does nothing when clicking on "Split bill preview" #32122
- Wallet -
Auth CreateFund returned an errorappears when adding debit card #32126
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
melvin-bot commentedon Nov 27, 2023
os-botify commentedon Nov 27, 2023
melvin-bot commentedon Nov 27, 2023
OSBotify commentedon Nov 27, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.4-0 🚀
kavimuru commentedon Nov 28, 2023
Regression is 2% left.
#31050 failing with #32082
#31102 failing with #32076
#31401 failing with #32104 and #32085
#31133 failing with #32126
#31291 failing with #32078 and #32122
#31629 failing with #32079
#31353 not sure if we have to test the internal steps provided, #31353 (comment)
mountiny commentedon Nov 28, 2023
Demoted #32118
mountiny commentedon Nov 28, 2023
Demoted #32080 repro in production
Julesssss commentedon Nov 28, 2023
Demoting #32119. It isn't reproducable in prod so its impossible to confirm.
It's still a high-priority issue.
Julesssss commentedon Nov 28, 2023
The comment wasn't added, but I cherry-picked the fix to issue #31830
luacmartins commentedon Nov 28, 2023
Checking off #32083 and #32104. We CPed a revert and tested well in staging.
luacmartins commentedon Nov 28, 2023
Checking off #32077. We CPed a fix and it tests well in staging.
marcaaron commentedon Nov 28, 2023
Checking off #32082 - seems like tester error
mvtglobally commentedon Nov 28, 2023
Regression is completed.
No Open blockers
#31050 failing with #32082
#31102 failing with #32076. Repro in PROD, checking off
#31133 failing with #32126
#31291 failing with #32078(repro in prod) and #32122(closed as not an issue) checking off.
#31353 can you QA internally?
#31401 failing with #32104 and #32085. Both are closed now. Do we need to retest or can check it off?
#31629 failing with #32079. Repro in prod, checking off.
#31851 just pending IOS validation
#32097 (comment) - Can you QA internally?
AndrewGable commentedon Nov 28, 2023
@luacmartins tested #32097, checking it off.
mountiny commentedon Nov 29, 2023
Checking #31353 off, QA almost finished, but not a blocker
mountiny commentedon Nov 29, 2023