Repository navigation
Deploy Checklist: New Expensify 2024-03-27 #39033
Description
Release Version: 1.4.57-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Connect react-fast-pdf #33434
- Transactions - Update Generic Receipts to use ReceiptBackground #34843
- [TS migration] Migrate WorkspaceReimburse Page #35399
- fix: task background image getting cropped #36261
- [TS migration] Migrate 'TagPicker' component to TypeScript #36580
- [TS migration] Migrate AttachmentCarousel to typescript #36658
- Comment linking e2e #36791
- [Audit][Implementation] - Memoize SidebarLinksData #37205
- Fix - [TS migration] Migrate 'TimePicker' component to TypeScript #37422
- fix: Add indenting logic for subcategories #37456
- Fix problem with cursor jumping back to start when adding an emoji in edit mode #37666
- Fix issues with the bold (unread) status on Workspace Item #37672
- Fix video not loading after regaining internet connection #37674
- [No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685
- [No QA][TS migration] Migrate Storybook files #37771
- Fix the incorrect payer name on the non-reimbursable transaction #37773
- [TS migration] Migrate 'AttachmentPicker' component to TypeScript #37810
- Feature/35716 changing owner flow #37869
- Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875
- [TS-migration] Migrate 'AddPaymentMethodMenu.tsx' to TypeScript #37900
- Fix deleted characters display briefly after saving edited parent message #37957
- [NO QA] [TS migration] Migrate 'IOUTest.js' test to TypeScript #37992
- [TS migration] Migrate G14 stories from storybook to Typescript #38056
- [HelpDot] Add light mode #38107
- Fix mention with the same front name #38121
- [Wave 8] [Ideal Nav] Save scroll position on HOME screen #38161
- Add optimistic created action for iou report and create created action for chat report #38197
- fixes-37403 Workflows-If the first 2 options are enabled,cannot scroll to see the 3th option #38248
- fix: Workspace - If title is changed offline, the description is no Ionger greyed out. #38249
- Disable thread in archived room #38251
- Fix report preview buttons #38253
- Fix/37448: Incorrect title thread #38267
- Fix: anonymous user can delete task #38272
- [No QA] [TS Migration] Migrate 'nativeVersionUpdater.js', 'GithubUtils.js', 'markPullRequestsAsDeployed.js' and 'bumpVersion.js' .github files to TypeScript #38280
- [TS migration] Migrate 'mocks' workflow test to TypeScript #32059 #38288
- Update and rename Vacation-Delegate.md to Delegate-when-out-of-office.md #38313
- [No QA][TS migration] Migrate workflow_tests, adjust utils migration #38363
- fix: add default rates data #38375
- Fix can't use right and left arrow key when a mention suggestion is shown #38383
- removed unused closeFullScreen function #38418
- Prevent full screen loading on Workflows page if data is present #38428
- fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443
- fix: Workspace - Error message is left and bottom aligned in WS menus. #38454
- [No QA] [TS migration] Migrate 'cherryPick.test.js' and 'authorChecklist.test.js' workflow tests to TypeScript #38467
- Create Change-member-workspace-roles.md #38481
- Create Set-time-and-distance-rates.md #38486
- Update and rename Distance-Tracking.md to Track-mileage-expenses.md #38493
- fix: annonymous user can open setting #38503
- Delete docs/articles/expensify-classic/settings/Copilot.md #38511
- Fix three-dot menu overlaps with emoji menu #38553
- Fix failed to load PDF is shown while previewing a pdf receipt after going online #38557
- [Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes by separating iOS and android implementation #38565
- [No QA] [TS migration] Migrate remaining Mock and Script files to TypeScript #38570
- fix: Category - Recent and All sections appear when selected category is invalid with <8 categories. #38601
- Fix: deleted messages are shown until revisit page #38609
- Fix: No navigation object in state picker story #38659
- [No QA][TS migration] Migrate workflow_tests assertions to TypeScript #38664
- Display Quick Action Button #38669
- [No QA][TS migration] Failure notifier TypeScript migration #38678
- [TS Migration] [No QA] Migrate wdyr.js to TS #38681
- [No QA] Ensure we send the typing indicator as soon as you type and once ever… #38716
- fix: Tag - Deleted tag can be clicked on when deleted offline. #38725
- [Taxes] Add extra decimal places, new API #38733
- 35380 virtual viewport on report screen #38755
- [FIX]: Inconsistent behavior when saving existing name without edit and unnecessary
APIcalls #38757 - Fix video play/pause on fullscreen #38765
- resolve flicker #38766
- Fix - App crashes when click on Category while creating Money request #38777
- Update and rename Close-Account.md to Close-or-reopen-account.md #38779
- fix: allow user to instantly edit created distance rate #38799
- [No QA] [TS migration] Migrate 'react-native.js' mock to TypeScript #38801
- Fix: load report details when refreshing the page on request confirma… #38804
- Fix tooltip overlaps with the desktop header #38806
- [No QA] Fix off by one error in optimistic distance rate name #38823
- [FIX]: Offline indicator is not at bottom of page on Categories and Tags empty state #38832
- Auto focus Tax value input #38843
- [FIX]: Workspace - Categories load without loading spinner #38849
- Disable scroll on tax name page #38850
- Revert "[No QA][TS migration] Migrate workflow_tests, adjust utils migration" #38857
- Fix tag becomes disabled when renaming #38863
- Fix expensify/chat alignments #38891
- [Snyk] Upgrade electron-updater from 6.1.9 to 6.2.1 #38893
- Add new beta flag for accounting integration #38901
- fix: draft message edit issue #38906
- [No QA] [TS migration] Migrate 'withFailTimeout.js' HOC to TypeScript #38923
- fix: display warning popup in all cases #38929
- [NoQA] Fix workflow test mocks typings #38930
- fix: change props for edit rate page wrapper #38932
- Create Add-Domain-Members-and-Admins.md #38938
- Create Switch-Domain-Member-to-Admin.md #38939
- Enabling self-dm and threads in the Share Logs list #38946
- Update Create-A-Report.md #38951
- [Simplified Collect][Taxes] - Fix for app crashing when opening Foreign currency default row after deleting the selected tax #38961
- disable main button when selected settlement option is disabled #38962
- Check quickAction.action is set before trying to display in popover #38973
- fix: Preferences page is visible for a moment when navigate via text link in Focus Mode popup #38977
- Fix can't close receipt attachment modal page from not found view #38982
- [NoQA] e2e: ignore "missing test" error #39009
- Update the beta flag name #39013
- [No QA] Stop calling OptInToPushNotifications when receiving notifications #39019
- Create generic network layer logic for conflicting write requests #39024
- Only switch position if it is possible #39143
- Fix/39049 shortcut self dm task #39215
Internal QA:
- [No QA] Fix: Expensify engineer is not tagged and assigned in Deploy Checklist to complete the QA for PRs with Internal QA. #38434 - @roryabraham
Deploy Blockers:
- [HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline #38814
- [HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824
- [HOLD for payment 2024-04-05] Expense - Expense preview shows skeleton loading after paying with Expensify #38869
- [$250] [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [Dev] Infinite loop of GetOlderActions calls #39028
- [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat – Action menu opens down when pressing on the top of highlighted message #39044
- [$250] Shortcut - Workspace avatar next to request shortcut does not update when it is changed #39045
- [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [$500] Shortcut - Error shows up when creating second self-assigned task via Assign task shortcut #39049
- [HOLD for payment 2024-04-09] Web - Reimbursements - There is no offline indicator message on 'Reimbursements' page #39050
- [$500] [QAB] Shortcut - Request money shortcut for workspace remains after workspace is deleted #39051
- [$250] Shortcut - Group chat counter under Shortcut appears differently than LHN and chat header #39052
- [HOLD for payment 2024-04-15] Distance- Blank space above waypoints when transitioning between request and confirmation page #39053
- [HOLD for payment 2024-04-09] [$50] [Simplified Collect][Members] Transfer owner - Typing error in "You're now the owner if this workspace" #39055
- Scan - receipt thumbnail is not shown due to a cors policy error #39056
- [HOLD for payment 2024-04-15] [Simplified Collect][Members] Members list does not update to show the new admin and owner #39057
- [HOLD for payment 2024-04-25] [$500] Chat - Compose Box is shown above empty space and doesn't resize properly #39061
- Chat - Red dot appears when send message in Public room #39064
- [$250] mWeb/Safari - Chat - Space appears above chat header after opening and closing attachment #39065
- [$250] Room -Notify me about new messages is shown as "daily" #39077
- Distance rates - Empty space between distance rates after deleting and adding distance rate #39083
- [$500] Chat - When pressing the left/right arrow keys after typing '@', the text selection does not move #39102
- [Simplified Collect][Taxes] - "Hmm it's not here" error appears briefly when opening taxes tab again #39154
- Chat - Chat header hidden below app banner after dismissing the device keypad #39156
- [HOLD for payment 2024-04-15] [$500] Expense - LHN preview does not show request description for request with description #39158
- Scan - Header in 1:1 DM turns to skeleton after creating Scan request #39163
- [HOLD for payment 2024-04-25] Android & iOS - Workspace - Workspace is not crossed out when deleted offline #39178
- [HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] Chat - Emoji tab opens at lower level, Change default skin tone not accessible for an attachment #39195
- [Hold for payment 2024-05-30][$250] Deleted message disappear for a moment when transistioning from offline to online #39218
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
mountiny commentedon Mar 27, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version
1.4.57-2tgolen commentedon Mar 27, 2024
I'm marking #39061 off of the deploy blocker list and we will just look into it as a normal bug.
luacmartins commentedon Mar 27, 2024
Checking off #39055. Demoted to NAB.
luacmartins commentedon Mar 27, 2024
Checking off #39057. Demoted to NAB.
blimpich commentedon Mar 27, 2024
Demoting #39077
johnmlee101 commentedon Mar 27, 2024
Fixed #39064 39064 so checking off
amyevans commentedon Mar 27, 2024
Demoted 39045
kavimuru commentedon Mar 27, 2024
Regression is at 81% in the TR.
#38850 failing with #38497 - Bug is not fixed in Android and iOS comment
#38977 failing with #37606 - Bug is not fixed and repro in all the platforms. comment
We are still working on other unchecked PRs.
grgia commentedon Mar 28, 2024
Demoting #39178
luacmartins commentedon Mar 28, 2024
Demoted #39154
kavimuru commentedon Mar 28, 2024
Regression is completed in the TestRail .
#38850 failing with #38497 - Bug is not fixed in Android and iOS #38850 (comment)
#38977 failing with #37606 - Bug is not fixed and repro in all the platforms. #38977 (comment)
#38272 failing with #25790 (comment) in Desktop - Can we check it off?
#38375 failing with #39154 in android
#38383 failing with #39102
#38849 failing with #37904 Bug is not fixed in Android comment
#38766 failing with #34520- Bug is not fixed in Android comment
#38503 validation on desktop is pending
#38253 validation on desktop and iOS are pending
francoisl commentedon Mar 28, 2024
#39195 is fixed by #39143 (was just CP'ed to staging, confirmed there), checking it off.
kavimuru commentedon Mar 28, 2024
Regression is completed.
#38253 failing with #39171 repro in PROD, checking it off
#38951 is a PROD PR help.expensify.com checking it off
Unchecked PRs:
#38850 failing with #38497 - Bug is not fixed in Android and iOS #38850 (comment)
#38977 failing with #37606 - Bug is not fixed and repro in all the platforms. #38977 (comment)
#38272 and #38503are failing with
#25790 (comment) in Desktop - Can we check it off?
#38375 failing with #39154 in android
#38383 failing with #39102
#38849 failing with #37904 Bug is not fixed in Android #38849 (comment)
#38766 failing with #34520 Bug is not fixed in Android #38766 (comment)
Open Blockers:
#39028
#39044
#39049
#39053
#39102
#39156
#39163
yuwenmemon commentedon Mar 28, 2024
Checking off #39102 and #38383 after discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1711605158432349 cc @stitesExpensify
luacmartins commentedon Mar 28, 2024
Checked off #38850. Demoted to NAB
yuwenmemon commentedon Mar 29, 2024