Repository navigation
Deploy Checklist: New Expensify 2024-04-22 #40702
Description
Release Version: 1.4.64-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Add global indicator based on Pusher status #85
- Receipt thumbnail should show the top of the receipt #35041
- Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822
- Feat/36985 create new rate field #38543
- Fix unchecked user becomes checked again when searching #38867
- Export main page - initial #39191
- Create Enable-and-set-up-expense-violations.md #39211
- Fix - “Submitted $amount” system message appears for a moment when Employee submit IOU #39321
- Block edit assignee and mark as complete simultaneously #39397
- Skip confirmation page for Quick Actions #39413
- Fix workspace BA data is cleared when close the bank account page #39790
- Get correct transaction data in ReportActionItem #39940
- fix: The background of fallback avatar has the same color as selection highlight #39950
- Tasks for guided setup #39951
- Android: fix GetMissingOnyxUpdates in the background #40022
- uncaught exception error when uploading a video #38720 #40132
- Remove
MoneyRequestConfirmationListand replace toMoneyTemporaryForRefactorRequestConfirmationList#40176 - Fix here is your magic code shows briefly when login with magic link #40177
- Workspace switcher: Expensify is no longer bolded and missing RBR after refreshing the page #40197
- Update report actions in CONST.ts to use underscores #40214
- fix: Android - No bottom margin under the sign out button. #40218
- Fix disconnected bank account still displayed in workflow page #40226
- [Fabric] iOS - Stretched border animations between screen transitions #40243
- Implement live markdown for private notes #40247
- Fix transaction thread header is not grayed out when creating while offline #40270
- fix: Transaction thread opens in skeleton after replying to system message thread #40274
- fix Unsynchronized transition of left and right page when deleting workspace #40276
- [Search v1] Implement Search navigation logic #40280
- [CP Staging] Chat is not scrolled to the new message on a newly created WS chat after whisper message #40286
- Exclude domain rooms check from canSeeDefaultRooms #40298
- fix bump expensify-common #40332
- Display violation when tax rate is invalid #40334
- fix: wrong attachment corrupt alert for pdf. #40351
- Optimistically set the right resolution for actionable whispers #40358
- [No QA] Add instructions to receive notifications on dev build #40361
- Refactor participant selector page #40370
- [No QA] Remove unused react-native-async-storage dependency #40389
- fix add bold style guided setup #40393
- Fix back navigation loop after refreshing page on transfer owner success #40395
- fix just display track expense of selfDM is loaded #40409
- [No QA] Reduce string unions in
Routetype #40418 - removed server logging code for getIOUReportActionDisplayMessage #40420
- [HelpDot] detect infinite redirect cycles in redirects.csv #40434
- Remove offline indicator #40475
- [NoQA] [CI/CD] Fix merging on E2E Performance Tests #40540
- Fix inverted flat list #40547
- fix: non-clickable elements on iOS #40560
- Changed route related to money request #40576
- Fix capitalization in 'Pay someone, get $250' banner #40592
- [No QA] Remove shouldAllowRawHTML hack #40614
- fix add queue command length log #40619
- [CP Staging] Fix: Correct Footer Display in MoneyRequestConfirmationList Component #40659
- [NoQA] e2e: compare
deltavsmaininstead ofmainvsmain#40684 - fix: gracefully handle missing test cases between two apps #40689
- [CP Staging] Feat/36985 create new rate field followups #40711
- [CP Staging] Revert "Block edit assignee and mark as complete simultaneously" #40729
- [CP Staging] Revert "Fix here is your magic code shows briefly when login with magic link" #40760
Deploy Blockers:
- [$1000] Android - Unable to access popup menu while "New message" marker is visible #40108
- [HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page #40397
- [$250] Thread - Unable to upload photo for thread avatar from group chat #40470
- [$250] Group chat - User can return to group chat after leaving the group chat via back button #40474
- Submit Expense - 'No PDF file specified' shown on confirmation page after adding PDF receipt #40476
- [HOLD for payment 2024-05-13] [$250] Web - Pressing on keyboard enter key on notification option of a room takes back two steps #40551
- [HOLD #38338][$250] IOU - Deleted IOU request report starts blinking with not found when return online #40705
- [HOLD for payment 2024-05-02] Split scan - Missing Split button in the split menu RHP #40709
- Distance - Distance rate currency does not update after changing distance expense currency #40710
- [HOLD for payment 2024-05-02] Distance - Distance row shows "0.00 miles" instead of "Pending" after changing distance #40712
- Onboarding - Missing attachment, not here page and skeleton in concierge task page #40715
- Submit Expense - Header Remains as "Submit Expense" Instead of "Manual" #40717
- Web - Task - Confirmation page not skipped for assign task flow when accessed from QAB #40719
- [HOLD for payment 2024-05-02] Task - "Mark as complete' button grays out briefly when selecting Delete/Pin #40720
- [HOLD for payment 2024-05-03] [$250] [QAB] "Pay elsewhere" button is small when paying someone via Quick action #40721
- [HOLD for payment 2024-05-02] Distance - Selected distance rate is not highlighted in rate list #40722
- [$500] Android - Report - Attempting to save an edited post freezes the app #40723
- [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] CRITICAL: [UX Reliability] [$1000] Chat - Chat does not scroll down when sending messages #40724
- [HOLD for payment 2024-05-03] Onboarding - Message received in Concierge DM does not include correct and bold text #40725
- [HOLD for payment 2024-06-06] 2FA - Web - Infinite loading spinner on 2FA authentication page #40742
- [$500] Chat - When navigating to chat via URL, user has to tap on back arrow twice to return to LHN #40743
- [C+ Checklist Needs Completion] [$250] Quick action - Split expense is created in a new group chat when splitting a second time from the same group from global creation #40745
- [$250] Infinite loading on members list on refreshing transfer owner success page & back to members list #40746
- Split - Search field is refocused and the list scrolls up every time a member is selected #40747
- [$250] [HOLD for payment 2024-05-06] Group split scan - Error appears for Merchant when clicking Split expense for the second time #40749
- [Guided Setup Stage 2] Keyboard not opened when navigating to enter name screen #40750
- [PAID] [$250] Scan - Scan expense preview created with PDF file is shown larger than with images #40751
- Track expense - Track expense option is not displayed in fab. #40752
- [$250] Distance - Gap displayed between start&finish after moving stops and deleting one #40753
- [HOLD for payment 2024-05-02] [$250] Android - Workspace list - Workspace name and email address are truncated #40754
- Taxes - Error shows up when selecting tax rate in split scan menu #40755
- [HOLD for payment 2024-05-06] Split scan - No error for missing amount when clicking Split expense for workspace split scan #40756
- Distance - Mileage Rate changes from previous value when editing waypoints #40762
- [$250] Distance - The route image is cropped in the IOU preview #40791
- [$250][HOLD #37374] Track expense - Waypoints swap places when tap and hold #40818
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
mountiny commentedon Apr 22, 2024
@Expensify/applauseleads to confirm this is ready to start the regression testing
mountiny commentedon Apr 22, 2024
Also checked off the deploy blockers, which were incorrectly added from the previous build. I forgot to remove the labels.
francoisl commentedon Apr 22, 2024
Closed #40717, the change was intended.
chiragsalian commentedon Apr 22, 2024
Checking off #40719 since it doesn't feel blocker worthy imo.
mountiny commentedon Apr 22, 2024
demoting #40722
kavimuru commentedon Apr 22, 2024
Regression is 43% progress.
#35041 failing with fixed issue #34120 commented here
#39397 failing with #38577 in mweb, issue not fixed. comment
#40334 failing with #39798 in all platforms except Web. comment
blimpich commentedon Apr 22, 2024
Demoting #40721 as its a minor UI bug and PR is already out to fix it.
mountiny commentedon Apr 23, 2024
Demoting #40746
mountiny commentedon Apr 23, 2024
demoted #40747 minor ux issues
mountiny commentedon Apr 23, 2024
demoted #40749 minor ux issue
mountiny commentedon Apr 23, 2024
demoted #40751 minor ui issue
1 remaining item
mountiny commentedon Apr 23, 2024
demoting #40762 as its a new feature and not really blocking behaviour
mountiny commentedon Apr 23, 2024
demoted #40756
mountiny commentedon Apr 23, 2024
demoted #40724, it feels like a minor ux issue
mountiny commentedon Apr 23, 2024
demoting #40755 as taxes are not yet fully supported in the split expense flow
mountiny commentedon Apr 23, 2024
#40745 was demoted
kavimuru commentedon Apr 23, 2024
Regression is just 7 steps left to run in the TR
#35041 failing with fixed issue #34120 commented here
#35822 failing with #40717 OK to check it off since it is expected behavior?
#39397 failing with #38577 in mweb, issue not fixed. comment
#40334 failing with 39798 in all platforms except Web. comment
#40393 failing with #40725
#38543 failing with #40762
#39413 failing with #40790 repro in production, checking it off
#39951 validation pending in Web, mweb, desktop and iOS
#40176 validation pending in android and iOS
#40619 validation pending in desktop
#40659 Validation pending in android and iOS
#40298 comment
kavimuru commentedon Apr 23, 2024
Regression is completed
unchecked PRs:
#35041 failing with fixed issue #34120 commented #35041 (comment)
#35822 failing with #40717 OK to check it off since it is expected behavior?
#39397 failing with #38577 in mweb, issue not fixed. #39397 (comment)
#40334 failing with 39798 in all platforms except Web. #40334 (comment)
#40393 failing with #40725
#38543 failing with #40762
#40619 is failing with #40820 checking it off
#40298 #40298 (comment)
Open Blockers:
#40712
#40723
#40724
#40743
#40754
#40818
mountiny commentedon Apr 23, 2024
demoted #40818
mountiny commentedon Apr 23, 2024
checking off:
mountiny commentedon Apr 23, 2024
Shared one expo related crash from android with SWM
Graphs looking good
mountiny commentedon Apr 23, 2024
verified #40286 on all platforms except android, but its platform agnostic change so proceeding with deploy
mountiny commentedon Apr 23, 2024
All clear
mountiny commentedon Apr 23, 2024