Repository navigation
Deploy Checklist: New Expensify 2024-04-04 #39588
Description
Release Version: 1.4.60-13
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [CP Stag] Fix pasting text into main composer #39177
- [No QA][TS migration] Migrate 'reviewerChecklist.js', 'getReleaseBody.js', 'getPreviousVersion.js' and 'checkDeployBlockers.js' .github files to Typescript #39197
- Fix going back from wallet page returns to the same page after adding a bank account #39351
- [CP Stag] Fix inline code font size in composer #39516
- [NoQA] Delete docs/articles/expensify-classic/copilots-and-delegates/User-Ro… #39528
- Update redirects.csv #39530
- [CP Staging] Fix three-dot menu item display incorrectly when opening receipt in combine report #39572
- Attempt to fix deploy script #39580
- [NO QA] Fix GitHub action commenting #39593
- Revert "35797-preserving-the-transactions-amounts-the-same-as-entered" #39610
- [CP Stag][Fix] One character jumps "after" cursor when typing fast #39621
- Bump expensify-common #37723 #39634
- [CP Staging] Fix crash with zero tax rate and allow tax amount to be zero #39638
- [CP Staging] fix: taxpicker selection for tax settings #39646
- [CP Staging] Revert "Defer local updates if there are missing updates and only call
GetMissingOnyxMessagesonce" #39668 - [CP Staging] Fix crash when tax rate is deleted #39707
- [CP Staging] Validate tax amount in edit flow and fix skeleton #39720
- [CP Staging] Fix report and personal detail options are persisted after switching account #39753
Deploy Blockers:
- [HOLD for Payment 2024-05-29] [$250] Web - Attachment - The action bar flickers when downloading a video. #39598
- [HOLD for payment 2024-04-15] BNP - Unable to enter number on BNP unless the number 0.00 is erased first #39599
- [$500] Taxes - App crashes when changing tax rate to 0% on native apps and it shows 00 on web #39600
- Taxes - Tax amount input in transaction thread is not auto-focused #39601
- Taxes - Missing tax rates in currency default list & app crashes when clicking on foreign rate #39602
- [$250] Chat - The written message does not appear in the composer after navigating via a deep link to the last message. #39603
- Taxes - System message for tax amount edit shows USD first, then changes to correct currency #39605
- [HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section #39607
- mWeb - Chat - When opening a request and going back, the requests list is displayed empty #39609
- [HOLD for payment 2024-04-15] BNP - Inconsistency in pointer position on android native and mWeb #39611
- [HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation #39613
- Taxes - Tax rate and tax amount take some time to show up in transaction thread #39615
- [Awaiting Payment 22nd May] [$250] [Track Tax] - Support for tax tracking when offline #39616
- Chat - Second and subsequent messages not displayed in chat until chat reloaded #39650
- [HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report #39679
- [HOLD for payment 2024-06-13] [$250] IOU - RBR is present in LHN but no error msg in combined report when deleting paid IOU offline #39689
- [$250] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Track Tax] Support tax tracking for split requests with workspace #39690
- [HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error #39691
- [PAID] [$250] Taxes - App crashes when visiting transaction thread with invalid tax rate on a fresh session #39695
- [Pay 4/29][$250] [Track Tax] Error on Amount and Merchant field after changing tax rate when scanning is ongoing #39699
- [HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time #39701
- [Track Tax] Expense request with tax amount higher than the tax rate limit can be created #39703
- Search - Created task not displayed in search results until page refreshed #39705
- [HOLD FOR SEARCH] IOU Actions - Notifications don't come if subscribed from combined report #39706
- [HOLD for payment 2024-04-15] [$500] Start chat - App shows data from User A after logging out of User A and logging in with User B #39710
- IOU - User able to start Money Request flow on IOU details page #39763
- Tax and tax amount are updated little bit delayed in transaction thread page. #39804
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
mountiny commentedon Apr 4, 2024
@Expensify/applauseleads Please use the below checklist + the one above as we cannot update the OP easily - each CP would overwrite it:
GetMissingOnyxMessagesonce #38997src/styles/directory #39365rlinoz commentedon Apr 4, 2024
Demoting #39601
mountiny commentedon Apr 4, 2024
Demoted #39598
amyevans commentedon Apr 4, 2024
Demoted #39603
jasperhuangg commentedon Apr 4, 2024
Checking off #39605 NAB
jasperhuangg commentedon Apr 4, 2024
Checking off #39607 NAB
jasperhuangg commentedon Apr 4, 2024
Checking off #39615 NAB
jasperhuangg commentedon Apr 4, 2024
Checking off #39609 Back-end issue
jasperhuangg commentedon Apr 4, 2024
Checking off #39650 back-end issue
jasperhuangg commentedon Apr 4, 2024
Checking off #39600 fixed in CP
kavimuru commentedon Apr 4, 2024
Regression is 87% progress.
#34902 failing with #39650
#39036 failing with #37508 and bug is not fixed in all the platforms, please see the commet
#39351 failing with #38558 and bug is not fixed in Web, please see the comment
#33927 pending validation in desktop and iOS
#38207 pending validation in iOS
#38613 pending validation in mweb and android
#38993 pending validation in mweb
#39017 pending validation in mweb, desktop and iOS
#39071 pending validation in iOS
aldo-expensify commentedon Apr 5, 2024
Checked #39650 off
2 remaining items
kavimuru commentedon Apr 5, 2024
Regression is completed.
Unchecked PRs
#38997- We are unsure of the step 3 asked help here. Also it seems this PR is reverted.
#33927 failing with #39600 and #39616
We are working on the CPs
mountiny commentedon Apr 5, 2024
Checking #33927 off, we will control the deploy blockers/ CPs
mountiny commentedon Apr 5, 2024
Checking #38997 it was reverted
mountiny commentedon Apr 5, 2024
demoted #39705
mountiny commentedon Apr 5, 2024
Demoting #39703 cc @MonilBhavsar
luacmartins commentedon Apr 5, 2024
Checking off #39763. Expected behavior
Julesssss commentedon Apr 8, 2024
Most of the remaining are CPs. I'll be reaching out to those to confirm these were tested manually.
Julesssss commentedon Apr 8, 2024
Julesssss commentedon Apr 8, 2024
Julesssss commentedon Apr 8, 2024
Checked off #39804 as not-a-blocker.
Julesssss commentedon Apr 8, 2024
Checked off
#39646 verified here
#39720 verified here
#39753 verified by QA here
#39572 tested here
Julesssss commentedon Apr 8, 2024
Julesssss commentedon Apr 8, 2024