Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.96-15
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Theme switching: Add TypeScript types #24178
- Upgrade to react-native-web v0.19.9 #24482
- Handle potential CORS issues during file downloads #25556
- add failure message when create a task error #26848
- [No QA] [TS Migration] FormActions lib #26883
- [No QA] [TS migration] Migrate 'Link.js' lib to TypeScript #28257
- [No QA] [TS migration] Migrate 'PersonalDetails.js' lib to TypeScript #28269
- Fix/27165: don't allow go to next step if empty waypoint #28308
- Create Copilot page #28361
- RequestorStep: Fix forward ref #28454
- perf: refactor heavy operations when user starts to type #28469
- [TS migration] Migrate 'EmojiUtils.js' lib to TypeScript #28589
- [NoQA] Add Spanish accessibility translation for floating action button #28703
- [No QA][TS migration] Migrate 'Clipboard' lib to TypeScript #28789
- ##23220 WEB maintainVisibleContentPosition #28793
- Show the context menu when we long press assignee of a task #28840
- Update The-Expenses-Page.md #29037
- Update Auto-Reconciliation.md to add image/screenshot placeholder #29140
- [NoQA] Bump onyx - Fix out of order updates #29169
- Fix/28925: Anonymous user can edit profile #29248
- Close Account on Mobile #29522
- [No QA][TS migration] Migrate 'withToggleVisibilityView.js' HOC to TypeScript #29559
- Composer - optimise rendering behaviour for onKeyPress & onSubmit #29561
- [No QA] [TS migration] Migrate 'LinearGradient' component to TypeScript #29580
- Update CSV-Import.md #29584
- Fix for Not found page appearing for private notes list, view and edit pages in deep link #29636
- Make optimistic requests/IOUs/expense reports “hidden” #29681
- [TS migration] Migrate 'Localize' lib to TypeScript #29742
- [TS migration] Migrate 'SafeAreaConsumer.js' component to TypeScript #29755
- Remove error when all workspace is deleted #29781
- Update composer number of lines when window width changes #29845
- [No QA] [TS migration] Migrate 'PopoverProvider' component to TypeScript #29857
- Update Expensify-Playbook-For-Small-To-Medium-Sized-Businesses.md #29907
- [TS migration] Migrate 'SafeArea' component to TypeScript #29947
- Only allow certain filetypes for receipt uploads #29963
- Reopened/Feature: Remove moment from datepicker #29984
- [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988
- Fix: android pdf scrolling issue #30050
- [TS migration] Migrate 'RNTextInput.js' component to TypeScript #30056
- Fix 17866: After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #30065
- [No QA] [TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #30072
- [TS migration] Migrate 'OpacityView.js' component to TypeScript #30074
- [TS migration] Migrate 'SelectCircle.js' component to TypeScript #30077
- Use OSBotify App token in additional workflows #30106
- check attachment msg after deleted parent action #30117
- [TS migration] Migrate 'getPermittedDecimalSeparator' lib to TypeScript #30160
- [No QA] [TS Migration] Migrate 'ImageWithSizeCalculation.js' component to TypeScript #30179
- Fix/27544 Incorrect Old Dot comment formatting when viewed on New Dot #30193
- feat: new emoji font for Windows #30201
- [TS migration] Migrate TextWithEllipsis #30202
- Fix: Add not allowed sign for archived workspace. #30229
- fix: regression 29888 #30231
- Fix/issue 29899 #30232
- refactor: LHN dataflow rework #30242
- Create Fringe-Benefits.md #30245
- [TS migration] Migrate 'CurrentWalletBalance.js' component to TypeScript #30262
- perf: improve performance when opening Search with cmd+k #30263
- Limit report routes in the customStackNavigator #30279
- Update error flow for prevent splitting bill with workspace and additional participants #30302
- Update CONTRIBUTING.md #30320
- fix show name on tooltip member page #30322
- Update LHN/chat header to handle displayName not being set - MR participants list fix #30342
- fix: 24473 Deepliink - Keyboard displayed upon splash screen #30345
- Migrate Button.js to function component #30349
- [Perf] ReportScreen rendering optimisation part 2 #30354
- [Form Provider Refactor] WorkspaceSettingsPage #30355
- Amount in the Distance e-receipt is cut off when device font size is minimum #30401
- feat: add whitespace after inserting emoji via native keyboard #30412
- [NoQA] feat: add Reassure perf tests to ReportScreen #30414
- [Form Provider Refactor] KnowATeacherPage #30434
- [No QA] [TS migration] Migrate 'SVGImage' component to TypeScript #30443
- ignore currency symbol for tbd #30459
- Fix: Copy to clipboard paid IOU in IOU page, instead of paid text requested text shown #30478
- Move QRCode component out of the folder #30480
- [NoQA] test(reassure): get last visible action #30482
- [DEV] E2e/add typing tests #30502
- Remove last few
report.managerEmailuses #30515 - Fix: Add Empty State Background To Tasks #30516
- Update and rename File-A-Dispute.md to Dispute-A-Transaction.md #30524
- Fix error message for duplicate waypoint #30548
- Fix avatar of the report action is not displayed properly if there is report preview action before it #30553
- fix: 30268 The keyboard closes after a moment when tapping back button #30557
- Fix: 27902 Members - Invite message doesn't remain when User navigate back to Invite members page #30562
- fix: change moment of displaying chat after editing existed message #30564
- [NO QA] Remove unnecessary screenshot/videos section from issue template #30574
- [TS migration] Migrate 'InlineErrorText.js' component to TypeScript #30580
- Fix user display name is changed to their login after doing a money request #30591
- fix: goBack from 'I am a teacher' contact methods #30608
- Parsing the welcome message into html in the create new room action #30609
- Fix: invite and remove member when offline in workspace #30627
- [NoQA] feat: add perf tests for composer #30633
- [NoQA] Add sleep cooldowns to e2e tests #30635
- Workspace settings page form error fix #30638
- fix clipboard in report utils #30640
- remove unused TextPill.js file #30642
- Left line/border of quoted text is not visible when hovering over it in Notes #30653
- Feat: Update how GBR is determined for IOU/expense reports #30655
- Remove CPA Card mention in sign in page footer #30656
- fix: Extra padding between bank account selector and ToS checkbox #30657
- fix: Chat - Skeleton placeholder flickers when opening chat with IOU in offline mode #30658
- Update Reimbursement.md #30661
- [NoQA] Update Teachers Unite by removing the '!' and capitalising the U #30667
- Fix arrow up on message deletion #30669
- Fix/30539: App crash when creating task #30670
- Fix/29228: Task needs revisit to update members #30671
- fix: mapbox attribution controls getting hidden #30673
- Fix: Merchant is not focused when back from search page #30675
- fix: private note draft not cleanup after saving #30688
- Fix: Wallet page does not update instantly when bank account is added or deleted #30700
- fix Android inconsistent pixel of +n triangle corner #30701
- fix "Sign in with Google" button jumping #30705
- Revert "[Form Provider Refactor] AddDebitCardPage" #30708
- [No QA] Update footer.html #30709
- Delete docs/articles/expensify-classic/send-payments/Pay-Invoices.md #30710
- Delete docs/articles/expensify-classic/expensify-card/Connect-To-Indi… #30711
- [CP Staging] Revert "27456 Chat - The green line is displayed chaotically at the recipient" #30712
- Delete docs/articles/expensify-classic/get-paid-back/Third-Party-Paym… #30713
- Delete docs/articles/expensify-classic/integrations/travel-integratio… #30714
- Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #30715
- Delete docs/articles/expensify-classic/getting-started/Policy-Admins.md #30716
- Delete docs/articles/expensify-classic/getting-started/Best-Practices.md #30717
- Update and rename Personal-Credit-Cards.md to Personal-Cards.md #30718
- Update and rename Overview.md to Billing-Overview.md #30719
- [NoQA] Update and rename Card-Settings.md to Admin-Card-Settings-and-Feature… #30722
- Update and rename Adding-Users.md to Add-Members-to-your-Workspace.md #30723
- fix: added new condition when we need to refetch data #30730
- Default to true to make type happy #30731
- XOF currency not searchable by its second term #30735
- Update CONTRIBUTING.md #30736
- [No QA] Add a worker to deploy community > help redirects #30739
- fix copy text for split action #30742
- Only search USA address in address form #30745
- [HelpDot] Fix search styling #30748
- Fix: Whisper message displays in public room only after page refresh #30751
- fix: Distance: prevent unnecessary operations when adding an empty stop #30754
- Upgrade
lottie-react-nativeto 6.4.0 #30772 - Fix: HeaderWithBackButton component shows error in storybook #30773
- [TS migration] Migrate 'Pressable' component to TypeScript #30777
- Adds Violations Beta #30779
- [No QA] Add missing displayName to components #30784
- Update Approval-Workflows.md #30785
- fix 30211 #30787
- Display public room in LHN #30814
- Fix Out of Pocket Spend / Company Spend Totals calculation in NewDot #30820
- Fix EReceipt Color Hashing #30822
- Update Workday help to include custom field 1 and 2 #30828
- Fix/30304: zipcode does not clear when country change #30831
- [NoQA] Revert "perf: refactor heavy operations when user starts to type" #30852
- Update Attendee-Tracking.md #30853
- Fix ios and msafari to scroll text of edit message to bottom when click edit comment #30857
- Fix incorrect email validation msg caused comma separated search term #30859
- fix wrong last sender name in LHN after login #30872
- Make lint happy on
main#30899 - Update CONTRIBUTING.md #30916
- Update Expensify-Card-Perks.md #30926
- [ImgBot] Optimize images #30928
- fix: app crashes when using deeplink to request new participants #30961
- [ImgBot] Optimize images #30963
- Fix: 2FA code should auto-submit after entering the code for the first time #30966
- Adding Removing Members image #30980
- Update Removing-Members.md #30982
- [CP Staging] fix: correctly pass transactions and reportActions to LHN #31007
- [No QA] Fix babel.config metro plugins syntax #31008
- [CP Staging] Bump the onyx version to 1.0.115 #31066
- fix: add null check to emoji suggestions #31072
Internal QA:
- Disable logs for staging and production native apps #30875 - @kidroca
- Allow requesting money when expensify account owns workspace #30019 - @puneetlath
Deploy Blockers:
- [HOLD for payment 2023-11-13] Android - Bank - After opening calendar for incorporation date day that comes before is selected #30871
- Chat - Default avatars are shown in LHN instead of custom ones #30932
- [HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants #30933
- [HOLD for payment 2023-11-17] Login - Chat loads infinitely after logging in unless user opens another chat #30934
- [$500] Web - Chat - Console error "Uncaught TypeError" shows up when sending a message #30935
- Chat - Participants screen briefly shown and distance page opens few times after opening link #30936
- Log out - A blank space shows up when logging out #30945
- Chat - Scrolling does not work if the user adds a message or clicks 'New messages' button #30947
- [HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page #30949
- Chat - Emoji picker and send buttons appear on the left of composer briefly when opening chat #30950
- Workspace - Inconsistency with hovering styles #30952
- [HOLD for payment 2023-11-17] [$500] mWeb/Chrome - Start Chat- #Rooms creation menu is misaligned #30976
- [HOLD for payment 2023-11-21] [HOLD for payment 2023-11-17] [$500] Android - Attachments-Password protected file preview is not shown #30977
- [$500] Android - Chat - Attachment - Preview of a multi-page PDF cannot be scrolled #30979
- [HOLD FOR PAYMENT] [$500] mWeb/Chrome - Compose-After pasting emoji, cursor moving single space away #30983
- [HOLD for payment 2023-12-01] [$500] Web – Login – New dot opens when navigate to the staging magic link, not abracadabra page. #30988
- [$500] Android - Chat - Keyboard does not pull up when editing the message #30991
- [HOLD for payment 2023-12-06] [$250] Workspace - Custom invitation message is still preserved after sending an invitation #30992
- [HOLD for payment 2023-11-17] [$500] Chat – Page crashes when open attachment preview in any chat and reload the page (Ctrl+R) #30998
- Web - Public Room - Two console errors show up when navigating to public room anonymously #31000
- Chat - Default emoji skin tone works only for yellow color #31006
- [HOLD for payment 2023-11-17] Desktop - App redirection - Logged in with different accounts App crashed #31027
- [HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report #31028
- [$500] IOU-For User B, receipt removed is not updated in real time & receipt page loading infinitely #31062
- Workspace creation - 'Hmm... it's not here' in NewDot after workspace creation under OldDot #31075
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
kavimuru commentedon Nov 6, 2023
Checking off the following PRs from the past builds
#29140
#29845
#29984
#30065
#30263
#30320
#30322
#30342
#30401
#30478
#30591
#30609
#30640
#30656
#30671
#30708
#30710
#30712
#30731
#30736
#30655
OSBotify commentedon Nov 7, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.96-0 🚀
kavimuru commentedon Nov 7, 2023
Not sure if QA can test or it is internal.
#30822 and #30820
cristipaval commentedon Nov 7, 2023
Checking off #30991, it's a minor issue, not a blocker.
mountiny commentedon Nov 7, 2023
puneetlath commentedon Nov 7, 2023
Checked off #30945 as not a blocker.
puneetlath commentedon Nov 7, 2023
Checked off #30935 as not a blocker.
kavimuru commentedon Nov 7, 2023
@puneetlath could check this one? #30929 (comment)
puneetlath commentedon Nov 7, 2023
@kavimuru I'll ask internally.
Checking off #31000 as non-reproducible.
puneetlath commentedon Nov 7, 2023
#30977 has been fixed via CP.
puneetlath commentedon Nov 7, 2023
@kavimuru looks like #30822 and #30820 got tested internally and are passing.
kavimuru commentedon Nov 7, 2023
Thank you!
8 remaining items
puneetlath commentedon Nov 8, 2023
@kavimuru is #30459 failing?
kavimuru commentedon Nov 8, 2023
@puneetlath Only in iOS.
luacmartins commentedon Nov 8, 2023
Checking off #31062. It's a dupe of another issue and it also happens in prod.
puneetlath commentedon Nov 8, 2023
##30653 was reverted. Checking off.
puneetlath commentedon Nov 8, 2023
All cleared! Shipping it.
puneetlath commentedon Nov 8, 2023
os-botify commentedon Nov 8, 2023
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
melvin-bot commentedon Nov 8, 2023
📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
puneetlath commentedon Nov 8, 2023
puneetlath commentedon Nov 8, 2023