Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.0.81-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- feat: There is no way to identify the primary workspace, making it appear essentially random. #53048
- Fix: Description hint field shows previous data after reenabling 'Req… #53249
- Tweaks to the expense flow #53760
- Add go to workspace shortcut and fix regression #53898
- Fix The sum of splits must equal the total amount error is displayed #53901
- feat: only pin the selfDM if the onboarding purpose is newDotPersonalSpend #54098
- fix: Skeleton is displayed when create offline Room in focus mode and switch #54180
- Fix: navigate to LHN after onboarding #54200
- [NO QA] add tests for product traing context and hook #54222
- Implemented per diem request flow #54252
- fix: track-merchant field is shown instead of distance and rate field #54273
- Update the text in the preview component to be plural if multiple receipts are being scanned #54274
- fix: remove sms domain from local notification #54275
- Align default IDs in ReportUtils file #54297
- Displaying price of upgrading a subscription in the user's local currency. #54340
- Change errors key #54370
- fix: IOS - Room description input field needs multiple taps before it gets focused. #54374
- Fix - Android - Wallet - "Get physical card" button overlaps with device navigation bar #54409
- feat: export performance data #54412
- phone number field is not auto focused #54447
- iOS/Android - App returns to account settings instead of workspace list after deleting workspace #54458
- fix: smooth keyboard handling in BaseModal #54533
- fix: android native tooltip appears broken #54550
- Revert changes to retrieve policy outputCurrency #54631
- fix offline workspace save #54634
- Fix new message shows for message sent from another user #54653
- fix approval mode is wrong when enabling again #54678
- [No QA] Add newDotMergeAccounts beta #54688
- [No QA] Filter out other reportAction types in Search #54690
- Limit search query length #54706
- Feat: Make it possible to click the element the product training tooltip is pointing to #54710
- fix: Features in Workspace LHN are not in the same order #54721
- Fix: invite/remove room member action displays incorrectly in thread header #54734
- Add nonce for Google Tag Manager script #54782
- [CP Staging] Fix crash when opening context menu #54832
- [CP Staging] Add loading state to ProductTrainingContextProvider #54865
- [CP Staging] Revert "Merge pull request #53760 from callstack-internal/JKobrynski/… #54878
- [CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897
- [CP Staging] Revert "fix: smooth keyboard handling in BaseModal" #54913
- Fix: We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over #54921
Internal QA:
- [No QA] Feat: Remove default selection of the card #54774 - @mountiny
- [Internal QA]: Add additional navigation for not existing export #54433 - @mountiny
Deploy Blockers:
- [AU] - Public room deeplink leads to skeleton loader for anonymous user #54753
- [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] [Awaiting payment] Chat - App crashes when right clicking on message (open context menu) #54827
- BA -The BA flow doesn't open automatically after clicking the Start Over option #54828
- Per diem - Confirmation page shows per diem confirm page when it is a manual expense #54830
- [$250] Per diem - Error persists after entering value in empty fields #54831
- [$250] Per diem - Unable to enter time once the time is erased #54833
- [HOLD for payment 2025-01-28] Per diem - Subrate quantity field has no limitation #54834
- [Due for payment 2025-01-17] [Due for payment 2025-01-15] Invoices - User can send invoice to themselves #54836
- [$250] Per diem - Selected worksapce with a checkmark is not highlighted #54838
- [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Tooltip - "Submit your expenses here" tooltip appears in the wrong location #54841
- [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Expense - Green button changes from "Create x expense" to "Submit x" after adding a receipt #54844
- mWeb - Per diem-Unable to submit a Per diem expense #54845
- [$250] Expense - Admin can submit expense to member's workspace chat via FAB #54846
- [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Login - FAB tooltip appears briefly after login when FAB tooltip is previously dismissed #54859
- [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Track expense -Green button on confirm page shows "Create 0.00 expense" for track scan expense #54861
- Onboarding tooltips can't be dismissed when clicking away #54862
- mWeb - Tooltip - The FAB Tooltip doesn't reappear when a modal is closed. #54867
- [Due for payment 2025-04-16] [$250] iOS - Conversation History - Scroll up to the beginning loads the end of the conversation #54870
- [$250] Per diem -"It's not here" page flickers after choosing the destination #54875
- [$250] [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] Reports - "Customize your search" tooltip reappears while creating an expense. #54879
- [HOLD for payment 2025-01-28] [$250] Per diem - App still shows old subrate and quantity after changing subrate and quantity to new value #54884
- [$250] Chat - Adding emojis from search results on the picker in unresponsive #54885
- Performance - JSON file is not downloaded #54886
- Per diem - Per diem page does not open in RHP when it is opened from create expense RHP #54887
- Per diem - The Quantity field allows float number #54889
- Per diem - Destination list shows the selected destination twice #54890
- [HOLD for payment 2025-01-28] Per diem - App shows partial offline blocking view in per diem RHP when there is no rate #54892
- Per diem - The string "Qty" in the Confirm details page is not translated into Spanish #54902
- [HOLD for payment 2025-01-28] [$250] Per diem - Labels show quantities only in the plural #54905
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
francoisl commentedon Jan 6, 2025
Demoting #54830 as NAB since the feature is behind a beta and is behind patched already (discussion)
blimpich commentedon Jan 6, 2025
Demoting #54845 b/c its behind a beta
mvtglobally commentedon Jan 7, 2025
Regression is at 60% complete
izarutskaya commentedon Jan 7, 2025
Regression is at 77 % completed
QA team don't have Hybrid Android build
Unchecked PRs:
#54180 - failing on mWeb with original KI #54180 (comment)
#54252 - failing with issues #54252 (comment)
#54340 - found issue #54340 (comment)
#54653 - failing on Web with original KI #54653 (comment)
#54710 - failing with issues #54710 (comment)
#54734 - failing with issue #54734 (comment)
DB:
#54753
#54828
#54831
#54833
#54834
#54836
#54841
#54844
#54846
#54859
#54861
#54867
mountiny commentedon Jan 7, 2025
@joekaufmanexpensify is going to tst the internalQA later in the day
amyevans commentedon Jan 7, 2025
Demoting #54884 since it's behind a beta
joekaufmanexpensify commentedon Jan 7, 2025
checked off #54774
joekaufmanexpensify commentedon Jan 7, 2025
checked off #54433
MarioExpensify commentedon Jan 7, 2025
checked off #54885 (offending PR was reverted)
izarutskaya commentedon Jan 7, 2025
Regression is at 2% left
Unchecked PRs:
#54098 - failing with original #54098 (comment)
#54180 - Repro in PROD, checking off #54180 (comment)
#54252 - failing with issues #54252 (comment)
#54275 - Pending validation on Web, Desktop
#54340 - found issue #54340 (comment)
#54370 - found issue on mWeb and iOS #54370 (comment) Pending validation on Android
#54409 - Pending validation on Android
#54412 - failing with #54412 (comment) Repro in PROD Can I check off ?
#54550 - checking off based on this comment #54550 (comment)
#54631 - Pending validation on iOS
#54653 - failing on Web with original KI #54653 (comment)
#54678 - Pending validation on Android
#54710 - failing with issues #54710 (comment)
#54734 -can I check off based this comment ?#54734 (comment)
DB:
#54753
#54879
thienlnam commentedon Jan 8, 2025
Yup this is fine, I've been checking off a few that fail original KIs that don't have any impact
thienlnam commentedon Jan 8, 2025
@izarutskaya / @mvtglobally I've cleared the deploy blockers, so all that is remaining is the Android validations for the PRs as well as one re-test of this issue
mvtglobally commentedon Jan 8, 2025
Regression sis completed. Will post a last pending PR summary in a bit
mvtglobally commentedon Jan 8, 2025
Unchecked PRs:
#54275 - Pending validation on Web, Desktop
#54409 - Pending validation on Android
#54631 - Pending validation on iOS
#54678 - Pending validation on Android
Checking 2 CPs
#54897 & #54921
puneetlath commentedon Jan 8, 2025