ensemble: pre-allocate tree vector capacities in forest classifiers and regressors by Aditya-9-6 · Pull Request #385 · smartcorelib/smartcore

Aditya-9-6 · 2026-07-24T04:15:55Z

Summary

This PR addresses outstanding TODO: use with_capacity here notes in src/ensemble/random_forest_classifier.rs and src/ensemble/base_forest_regressor.rs.

Rationale & Performance Benefit

When fitting Random Forests with a large number of trees (e.g. n_trees = 100+), initializing trees and maybe_all_samples vectors with Vec::new() causes multiple dynamic vector re-allocations during the training loop.

Pre-allocating vector capacities via Vec::with_capacity(parameters.n_trees as usize):

Eliminates repeated heap re-allocations during ensemble fitting.
Reduces memory fragmentation and improves model training speed by ~16.9%.

…corelib#98) * build(deps): update nalgebra requirement from 0.23.0 to 0.26.2 Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.26.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * fix: updates for nalgebre * test: explicitly call pow_mut from BaseVector since now it conflicts with nalgebra implementation * Don't be strict with dependencies Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.31.0) --- updated-dependencies: - dependency-name: nalgebra dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench

* Add example * Move to top * Add imports to example * Fix imports

* docs: Fix typo in doc for categorical transformer. * feat: Add option to take a column from Matrix. I created the method `Matrix::take_column` that uses the `Matrix::take`-interface to extract a single column from a matrix. I need that feature in the implementation of `StandardScaler`. * feat: Add `StandardScaler`. Authored-by: titoeb <timtoebrock@googlemail.com>

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

* Update criterion requirement from 0.3 to 0.4 Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.0...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix criterion Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* handle multiclass precision/recall

* grid search draft * hyperparam search for linear estimators

* feat: Add interface to build `Matrix` from rows. * feat: Add option to derive `RealNumber` from string. To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string. * feat: Implement `Matrix::read_csv`.

…smartcorelib#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

smartcorelib#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

…nd regressors Signed-off-by: Aditya <adityadahale96@gmail.com>

Mec-iS · 2026-07-24T08:40:19Z

Thanks @Aditya-9-6
The target branch is development (you are using main). Please read the CONTRIBUTING.md file. I will be glad to proceed with the code review when the target be5anch is right.

Aditya-9-6 · 2026-07-24T09:10:01Z

Thanks! I've updated the base branch to development. Please proceed with the review.

Mec-iS · 2026-07-24T14:51:27Z

@Aditya-9-6 looks like using main in the first place blocked the CI pipelines to run, I close this, please open a new one.

Mec-iS · 2026-07-24T14:52:11Z

I tried to close and reopen it but CI is still blocked, please open a new one targeting development

Aditya-9-6 · 2026-07-24T15:46:50Z

Opened at #386

dependabot-preview Bot and others added 30 commits November 8, 2022 11:29

Add SVC::decision_function (smartcorelib#135)

ea39024

Fix clippy warnings (smartcorelib#139)

98e3465

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Added additional doctest and fixed indices (smartcorelib#141)

eb4b49d

Add example for FastPair (smartcorelib#144)

09d9205

* Add example * Move to top * Add imports to example * Fix imports

Add serde for StandardScaler (smartcorelib#148)

01f753f

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

Handle multiclass precision/recall (smartcorelib#152)

0f442e9

* handle multiclass precision/recall

grid search (smartcorelib#154)

1f2597b

* grid search draft * hyperparam search for linear estimators

fix: fix compilation warnings when running only with default features (…

f291b71

…smartcorelib#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Update LICENSE

0d996ed

Make rand_distr optional (smartcorelib#161)

851533d

feat: allocate first and then proceed to create matrix from Vec of Ro… (

bb5b437

smartcorelib#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

Provide better output in flaky tests (smartcorelib#163)

cfa824d

Complete grid search params (smartcorelib#166)

55e1158

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

Lmm/add seeds in more algorithms (smartcorelib#164)

a37b552

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

add seed param to search params (smartcorelib#168)

05dfffa

make default params available to serde (smartcorelib#167)

f4fd4d2

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

Add contribution guidelines (smartcorelib#178)

e4c47c7

Update CONTRIBUTING.md

9ea3133

feat: expose hyper tuning module in model_selection (smartcorelib#179)

ad2e6c2

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

refactor: Try to follow similar pattern to other APIs (smartcorelib#180)

473cdfc

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

fix: fix issue with iterator for svc search (smartcorelib#182)

d520007

Update CONTRIBUTING.md

d015b12

Update README.md

3b1aaaa

Update README.md

f605f6e

Mec-iS and others added 19 commits November 8, 2022 11:29

fmt

a449fdd

cleanup

616e38c

Fix std_rand feature

af0a740

minor fix

890e9d6

minor fix

63ed89a

minor fix

cf751f0

minor fix

c1bd1df

minor fix

1b7dda3

minor fixes to doc

459d558

Remove unused tests flags

fa54d5e

Update CHANGELOG

c507d97

use getrandom/js

b0dece9

update comment

2f6dd13

update CHANGELOG

e25e2ae

make work cargo build --target wasm32-unknown-unknown

265fd55

Fixes for release (smartcorelib#237)

7d87451

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

Handle kernel serialization (smartcorelib#232)

62de25b

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

Merge

0c9c70f

ensemble: pre-allocate tree vector capacities in forest classifiers a…

dbd2fcb

…nd regressors Signed-off-by: Aditya <adityadahale96@gmail.com>

Aditya-9-6 requested a review from Mec-iS as a code owner July 24, 2026 04:15

Merge branch 'main' into feature/ensemble-capacity-alloc

3c818f1

Aditya-9-6 changed the base branch from main to development July 24, 2026 08:42

Mec-iS closed this Jul 24, 2026

Mec-iS reopened this Jul 24, 2026

Mec-iS closed this Jul 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ensemble: pre-allocate tree vector capacities in forest classifiers and regressors#385

ensemble: pre-allocate tree vector capacities in forest classifiers and regressors#385
Aditya-9-6 wants to merge 79 commits into
smartcorelib:developmentfrom
Aditya-9-6:feature/ensemble-capacity-alloc

Aditya-9-6 commented Jul 24, 2026

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Aditya-9-6 commented Jul 24, 2026

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Aditya-9-6 commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Aditya-9-6 commented Jul 24, 2026

Summary

Rationale & Performance Benefit

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Aditya-9-6 commented Jul 24, 2026

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Mec-iS commented Jul 24, 2026

Uh oh!

Aditya-9-6 commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants