Skip to content

Add cryptography and key-management hunting companion guide - #101

Closed
spidervirus wants to merge 1 commit into
cloudflare:mainfrom
spidervirus:add-cryptography-and-key-management
Closed

spidervirus wants to merge 1 commit into
cloudflare:mainfrom
spidervirus:add-cryptography-and-key-management

Conversation

@spidervirus

Copy link
Copy Markdown

Closes #39

Summary

Adds a dedicated CRYPTOGRAPHY-AND-KEY-MANAGEMENT.md companion guide to make cryptographic implementation review a first-class audit category within the security-audit skill.

Scope & Structure

  • Symmetric ciphers & AEAD: Covers ECB mode, unauthenticated encryption, CBC padding oracles, nonce/IV reuse in AES-GCM and ChaCha20-Poly1305, and weak/deprecated ciphers (DES, 3DES, RC4).
  • Randomness & KDF: Covers predictable non-cryptographic PRNGs (Math.random(), rand()), inadequate password hashing work factors/iteration counts, static salts, and key derivation context mixing without HKDF.
  • Asymmetric crypto & signatures: Covers decode-without-verify, algorithm confusion (alg: none, public key as HMAC secret), untrusted key selector injection (kid, jku, jwk, x5u), missing/broken MAC verification, timing side-channels on secret comparison, and Bleichenbacher padding oracles.
  • TLS & transport security: Covers InsecureSkipVerify: true, disabled hostname verification, and weak TLS / cipher suite downgrades.
  • Secret management & key lifecycle: Covers hardcoded keys, insecure storage/logging, and key rotation/retirement failures.
  • Cross-references & docs: Updates ATTACK-CLASSES.md, WEB-PROTOCOL-AND-AUTH.md, and README.md to link and route to the new companion guide.

Validation

  • Adheres strictly to the established companion layout (When to use this file, Core discipline, (subagent_type: general) attack classes, Universal moves, and Validation rules).
  • Ran validator test suite with node --test skills/security-audit/*.test.cjs — all 65/65 tests passed.

- Add skills/security-audit/CRYPTOGRAPHY-AND-KEY-MANAGEMENT.md covering symmetric ciphers, randomness, signatures, MACs, TLS, and key lifecycle.
- Update ATTACK-CLASSES.md to reference the new companion guide.
- Update WEB-PROTOCOL-AND-AUTH.md with a cross-reference for low-level cryptographic primitives.
- Add entry to README.md file table.

Closes cloudflare#39
coffeegrind123 added a commit to coffeegrind123/security-audit-skill that referenced this pull request Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are
open. Each was read at the diff level, tested in its own worktree, and
checked for conflicts; the best of each duplicate group is ported.

Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts
within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field
objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded
ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line
upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked
open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact
check (skills/ part only). Overlapping changes were merged so both
behaviours and both test sets survive.

Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls
become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23
streaming tool calls, cloudflare#50 config-dependent reachability stays
needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no
longer sees the hunter's verdict, severity or fix.

Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95
sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content
prompt block; cloudflare#129 isolation built beside the host) moves into
EXECUTION-SAFETY.md so SKILL.md stays under its token budget.

Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state.

Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25
cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99),
README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32.

UPGRADE.md records this sync procedure.

Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com>
Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com>
Co-authored-by: Rudy Celekli <rudy@gradiahq.com>
Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com>
Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com>
Co-authored-by: CodeInf <jiuqiaoy@gmail.com>
Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Pizo <pizofreude@proton.me>
Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com>
Co-authored-by: shivam <juyaljii610@gmail.com>
Co-authored-by: Dante <duanjl.china@gmail.com>
Co-authored-by: Francisco <francisco@theysay.me>
Co-authored-by: Roman Dolgov <alter@users.noreply.github.com>
Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com>
Co-authored-by: itinance <hhuebel@itinance.com>
Co-authored-by: ChoYugyeong <cho4639@gmail.com>
Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za>
Co-authored-by: JAI <jai19kharb@gmail.com>
Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com>
Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com>
Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com>
Co-authored-by: jastfan <duohello640@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@spidervirus
spidervirus deleted the add-cryptography-and-key-management branch November 18, 2026 09:44
@tinambuchman

Copy link
Copy Markdown

Cloud services backup and current? https://secure.metrobyt-mobile.com/TY0NDkNDa8bhttp://www.samsungapps.com/appquery/appDetail.as?appId=com.panruyiapp.android.phone.system.update.check.samsungCorrelation ID: 3b3009b7a626498f9e5643801d666f42
Timestamp: 2026-11-17T14:49:48.726Zhttps://chatgpt.com/share/6afc2ba4-ff98-83e9-937c-860baf558f1e?ogimg=plainhttps://chatgpt.com/share/6afc2ba4-ff98-83e9-937c-860baf558f1e?ogimg=plainhttps://www.cloudflare.com/press/press-kit/https://www.affinitycuia.org/locations/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CRYPTOGRAPHY-AND-KEY-MANAGEMENT.md security audit guide

2 participants