Skip to content

Allow multiple local checks in an archived attempt to share an artifact - #70

Open
ALANDVO wants to merge 1 commit into
cloudflare:mainfrom
ALANDVO:portfolio/alan/be5a1725c8a0
Open

ALANDVO wants to merge 1 commit into
cloudflare:mainfrom
ALANDVO:portfolio/alan/be5a1725c8a0

Conversation

@ALANDVO

@ALANDVO ALANDVO commented Oct 7, 2026

Copy link
Copy Markdown

Problem

In skills/security-audit/validate-coverage-ledger.cjs, validateAttempts immediately added each local check's artifact to priorArtifacts during iteration. When an archived attempt contained multiple local checks that shared the same artifact, subsequent checks within that same attempt failed validation with artifact from an earlier attempt cannot be reused.

Solution

Collect local check artifacts for each attempt into an attemptArtifacts set during check iteration, and defer adding them to priorArtifacts until all checks in that attempt have been processed. This mirrors the existing deferred registration pattern used for priorOwners.

Validation

  • Added allows multiple local checks within the same archived attempt to share an artifact in skills/security-audit/validate-coverage-ledger.test.cjs, asserting that multiple checks in the same archived attempt can share an artifact and confirming that cross-attempt artifact reuse is still rejected.
  • Ran node skills/security-audit/validate-coverage-ledger.test.cjs (32 tests pass).
  • Ran node skills/security-audit/validate-findings.test.cjs (34 tests pass).

Limitations

Does not alter live unit local check validation or allow cross-attempt artifact reuse.

AI Disclosure

Developed and reviewed with AI assistance.

AI-assisted development and review; submitted by Alan Vo.

Validated against upstream commit c1c8a8c1471069fb0e188eeaff69b8e8db6564a8.

Refs #28.

@ALANDVO
ALANDVO marked this pull request as ready for review October 9, 2026 15:22
coffeegrind123 added a commit to coffeegrind123/security-audit-skill that referenced this pull request Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are
open. Each was read at the diff level, tested in its own worktree, and
checked for conflicts; the best of each duplicate group is ported.

Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts
within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field
objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded
ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line
upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked
open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact
check (skills/ part only). Overlapping changes were merged so both
behaviours and both test sets survive.

Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls
become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23
streaming tool calls, cloudflare#50 config-dependent reachability stays
needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no
longer sees the hunter's verdict, severity or fix.

Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95
sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content
prompt block; cloudflare#129 isolation built beside the host) moves into
EXECUTION-SAFETY.md so SKILL.md stays under its token budget.

Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state.

Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25
cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99),
README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32.

UPGRADE.md records this sync procedure.

Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com>
Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com>
Co-authored-by: Rudy Celekli <rudy@gradiahq.com>
Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com>
Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com>
Co-authored-by: CodeInf <jiuqiaoy@gmail.com>
Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Pizo <pizofreude@proton.me>
Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com>
Co-authored-by: shivam <juyaljii610@gmail.com>
Co-authored-by: Dante <duanjl.china@gmail.com>
Co-authored-by: Francisco <francisco@theysay.me>
Co-authored-by: Roman Dolgov <alter@users.noreply.github.com>
Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com>
Co-authored-by: itinance <hhuebel@itinance.com>
Co-authored-by: ChoYugyeong <cho4639@gmail.com>
Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za>
Co-authored-by: JAI <jai19kharb@gmail.com>
Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com>
Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com>
Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com>
Co-authored-by: jastfan <duohello640@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dante-dan added a commit to Dante-dan/security-audit-skill that referenced this pull request Nov 19, 2026
Combine cloudflare#70, cloudflare#87, cloudflare#91 and cloudflare#106
into cloudflare#82 while retaining each original commit. Use one pass to
validate checks and collect artifacts, then register them once
validation of the attempt is complete. Keep the existing negative
reuse checks and add cloudflare#70's covered-attempt fixture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant