Skip to content

Add abort-path cleanup and cross-request stale state classes - #93

Open
kelmia-stack wants to merge 1 commit into
cloudflare:mainfrom
kelmia-stack:add-reused-worker-and-abort-path-classes
Open

kelmia-stack wants to merge 1 commit into
cloudflare:mainfrom
kelmia-stack:add-reused-worker-and-abort-path-classes

Conversation

@kelmia-stack

Copy link
Copy Markdown

Summary

The October 2026 PHP disclosures (CVE-2026-109618 and CVE-2026-109619, "php2shell") show two bug classes that the memory-safety companion did not name directly:

  • Abort-path cleanup of partially initialized state. An allocation failure, memory or time limit, or fatal bailout abandons setup midway, then cleanup treats the half-built structure as valid.
  • Cross-request stale state in reused workers. A runtime or interpreter host reuses a process across requests, and global state still points to memory freed by an earlier request. Consumers that run before normal initialization, fatal paths that skip reset, and shutdown diagnostics that repopulate cleared state all matter here.

The new text is target-neutral, like the rest of the skill. It names no specific runtime or CVE and applies to any interpreter host or server that recycles workers.

Changes

  • MEMORY-SAFETY-AND-BINARY.md: two lifetime classes, plus a universal move that treats each request boundary in a reused worker as a teardown.
  • RESOURCE-EXHAUSTION-AND-AVAILABILITY.md: reachable fatal errors that skip cleanup or reset also route to the new memory-safety classes, since impact can exceed availability.
  • ATTACK-CLASSES.md: interpreter hosts that reuse workers across requests are listed among native targets.

Testing

  • node skills/security-audit/validate-findings.test.cjs passes
  • node skills/security-audit/validate-coverage-ledger.test.cjs passes

These tests cover the validators, not the Markdown text.

References

🤖 Generated with Claude Code

Memory safety: two lifetime classes for runtimes and interpreter hosts.
Abort-path cleanup covers allocation failures, limits, and fatal
bailouts that leave partially initialized state for cleanup to trust.
Cross-request stale state covers reused workers whose globals still
reference memory freed by an earlier request, including consumers that
run before normal initialization and fatal paths that skip reset. A
universal move treats each request boundary as a teardown.

Resource exhaustion: route reachable fatal errors that skip cleanup or
reset to the new memory-safety classes, since impact can exceed
availability.

Attack classes: list interpreter hosts that reuse workers among native
targets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coffeegrind123 added a commit to coffeegrind123/security-audit-skill that referenced this pull request Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are
open. Each was read at the diff level, tested in its own worktree, and
checked for conflicts; the best of each duplicate group is ported.

Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts
within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field
objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded
ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line
upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked
open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact
check (skills/ part only). Overlapping changes were merged so both
behaviours and both test sets survive.

Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls
become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23
streaming tool calls, cloudflare#50 config-dependent reachability stays
needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no
longer sees the hunter's verdict, severity or fix.

Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95
sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content
prompt block; cloudflare#129 isolation built beside the host) moves into
EXECUTION-SAFETY.md so SKILL.md stays under its token budget.

Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state.

Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25
cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99),
README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32.

UPGRADE.md records this sync procedure.

Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com>
Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com>
Co-authored-by: Rudy Celekli <rudy@gradiahq.com>
Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com>
Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com>
Co-authored-by: CodeInf <jiuqiaoy@gmail.com>
Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Pizo <pizofreude@proton.me>
Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com>
Co-authored-by: shivam <juyaljii610@gmail.com>
Co-authored-by: Dante <duanjl.china@gmail.com>
Co-authored-by: Francisco <francisco@theysay.me>
Co-authored-by: Roman Dolgov <alter@users.noreply.github.com>
Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com>
Co-authored-by: itinance <hhuebel@itinance.com>
Co-authored-by: ChoYugyeong <cho4639@gmail.com>
Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za>
Co-authored-by: JAI <jai19kharb@gmail.com>
Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com>
Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com>
Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com>
Co-authored-by: jastfan <duohello640@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants