Skip to content

fix: reject duplicate object keys in findings.json - #102

Open
rudycelekli wants to merge 1 commit into
cloudflare:mainfrom
rudycelekli:fix/findings-duplicate-object-keys
Open

rudycelekli wants to merge 1 commit into
cloudflare:mainfrom
rudycelekli:fix/findings-duplicate-object-keys

Conversation

@rudycelekli

Copy link
Copy Markdown

What was wrong

validate-findings.cjs passes the file to JSON.parse, which keeps the last occurrence of a repeated object key. enforceJsonTextLimits scans the text before parsing, but it only counts nesting and array items, not object keys. So a record can say two different things, and the validator checks only the last one.

Input that triggers it

[{"verdict":"rejected","fingerprint":"a","title":"t","description":"d","claimed_root_cause":"c",
  "trace":[{"kind":"sink","file":"src/a.c","line":1,"scope":"s","description":"d"}],
  "evidence":[{"file":"src/a.c","line":1,"description":"d"}],
  "reason":"r","reason":"Second reason silently replaces the first."}]

On main: PASS: 1 findings valid. The same applies to "verdict":"needs_validation","verdict":"rejected", or to a repeated "line" inside a trace entry.

Fix

enforceJsonTextLimits now tracks whether each object expects a key next. It decodes every key with JSON.parse and keeps the decoded keys in a per-object Set. A repeated key fails with input has duplicate object key "<key>", and the key is escaped with the existing safeQuote, so it can't inject control bytes into the output.

Keys are compared after decoding, the same way JSON.parse compares them:

  • "verd\u0069ct" and "verdict" are treated as duplicates and rejected.
  • "a" and "A" are different keys, so they're still accepted. So are "\u00e9" and "e\u0301".
  • The same key in different objects, such as two findings that both have "verdict", is still accepted.

Tests

node --test skills/security-audit/validate-findings.test.cjs
# tests 36, pass 36, fail 0

This adds two tests:

  • CLI rejects duplicate object keys instead of keeping the last one fails on main.
  • CLI keeps distinct decoded keys and identical keys in separate objects guards against rejecting valid input.

The coverage-ledger validator has the same hole, but in its own parser, so it's fixed in a separate PR.

JSON.parse keeps the last occurrence of a repeated key, so a record such as
{"verdict":"needs_validation","verdict":"rejected",...} was validated only as
its final value. enforceJsonTextLimits now records each decoded key per object
and rejects a repeat, including escape-spelled repeats such as "verd\u0069ct".
coffeegrind123 added a commit to coffeegrind123/security-audit-skill that referenced this pull request Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are
open. Each was read at the diff level, tested in its own worktree, and
checked for conflicts; the best of each duplicate group is ported.

Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts
within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field
objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded
ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line
upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked
open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact
check (skills/ part only). Overlapping changes were merged so both
behaviours and both test sets survive.

Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls
become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23
streaming tool calls, cloudflare#50 config-dependent reachability stays
needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no
longer sees the hunter's verdict, severity or fix.

Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95
sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content
prompt block; cloudflare#129 isolation built beside the host) moves into
EXECUTION-SAFETY.md so SKILL.md stays under its token budget.

Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state.

Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25
cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99),
README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32.

UPGRADE.md records this sync procedure.

Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com>
Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com>
Co-authored-by: Rudy Celekli <rudy@gradiahq.com>
Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com>
Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com>
Co-authored-by: CodeInf <jiuqiaoy@gmail.com>
Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Pizo <pizofreude@proton.me>
Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com>
Co-authored-by: shivam <juyaljii610@gmail.com>
Co-authored-by: Dante <duanjl.china@gmail.com>
Co-authored-by: Francisco <francisco@theysay.me>
Co-authored-by: Roman Dolgov <alter@users.noreply.github.com>
Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com>
Co-authored-by: itinance <hhuebel@itinance.com>
Co-authored-by: ChoYugyeong <cho4639@gmail.com>
Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za>
Co-authored-by: JAI <jai19kharb@gmail.com>
Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com>
Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com>
Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com>
Co-authored-by: jastfan <duohello640@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant