Repository navigation
Conversation
validateAttempts registered each local check's artifact inside the per-check loop, so a second check in the same attempt that reused the same promoted artifact was rejected as reuse from an earlier attempt even though no attempt boundary had been crossed. Register an attempt's artifacts only after all of its checks have been validated, so intra-attempt sharing is allowed and cross-attempt reuse is still rejected. Add a regression test covering both directions.
Archived attempts previously added each local-check artifact to priorArtifacts immediately inside the per-check loop. When multiple checks within the same attempt shared a promoted artifact, subsequent checks were rejected as reusing an artifact from an earlier attempt. Register an attempt's artifacts in priorArtifacts only after validating all checks of that attempt, allowing intra-attempt sharing while continuing to reject cross-attempt reuse. Fixes cloudflare#81.
…n archived attempt
Upstream main has not moved since 2026-09-14, but 79 pull requests are open. Each was read at the diff level, tested in its own worktree, and checked for conflicts; the best of each duplicate group is ported. Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact check (skills/ part only). Overlapping changes were merged so both behaviours and both test sets survive. Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23 streaming tool calls, cloudflare#50 config-dependent reachability stays needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no longer sees the hunter's verdict, severity or fix. Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95 sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content prompt block; cloudflare#129 isolation built beside the host) moves into EXECUTION-SAFETY.md so SKILL.md stays under its token budget. Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state. Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25 cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99), README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32. UPGRADE.md records this sync procedure. Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com> Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com> Co-authored-by: Rudy Celekli <rudy@gradiahq.com> Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com> Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com> Co-authored-by: CodeInf <jiuqiaoy@gmail.com> Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com> Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-authored-by: Pizo <pizofreude@proton.me> Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com> Co-authored-by: shivam <juyaljii610@gmail.com> Co-authored-by: Dante <duanjl.china@gmail.com> Co-authored-by: Francisco <francisco@theysay.me> Co-authored-by: Roman Dolgov <alter@users.noreply.github.com> Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com> Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com> Co-authored-by: itinance <hhuebel@itinance.com> Co-authored-by: ChoYugyeong <cho4639@gmail.com> Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za> Co-authored-by: JAI <jai19kharb@gmail.com> Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com> Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com> Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com> Co-authored-by: jastfan <duohello640@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Five open PRs make the same fix for #81: register an archived attempt's artifacts only after all of its checks are validated, so checks inside one attempt can share an artifact. That's #70, #82, #87, #91 and #106. I compared them, and this one looks like the most complete, mainly because of the tests.
Small nit: the second loop repeats the |
Combine cloudflare#70, cloudflare#87, cloudflare#91 and cloudflare#106 into cloudflare#82 while retaining each original commit. Use one pass to validate checks and collect artifacts, then register them once validation of the attempt is complete. Keep the existing negative reuse checks and add cloudflare#70's covered-attempt fixture.
|
Thanks, @zachshallbetter. I updated #82 to collect local artifacts in a set during the validation loop and register them after the whole attempt has been checked. I consolidated #70 (ALANDVO), #87 (lab1207), #91 (Adarsh-mk7), and #106 (Dinesh-design786). All four original commits are in the merge commit's history. The combined tests cover sharing within an archived attempt and still check that later archived attempts and the live unit reject reuse. Both validator suites passed locally (67 tests), and |
Fixes #81.
Archived attempts currently add each local-check artifact to the prior-artifact set immediately. A second check sharing the same artifact is then incorrectly rejected as reuse from an earlier attempt. Register artifacts after checking the entire attempt so sharing within an attempt succeeds while later archived attempts and the current assignment still reject reuse.
Adds a regression for same-attempt sharing and checks both cross-attempt rejection paths. The sharing regression fails on the current main revision before the fix.
Validation:
node --test skills/security-audit/validate-coverage-ledger.test.cjs skills/security-audit/validate-findings.test.cjs— 66 tests passed;git diff --checkpassed.