Repository navigation
Support Windows in the validators with an identity-checked open - #145
Open
pizofreude wants to merge 1 commit into
Open
pizofreude wants to merge 1 commit into
pizofreude wants to merge 1 commit into
Conversation
Node on Windows exposes neither O_NOFOLLOW nor O_NONBLOCK, so both validators rejected every input there with "OS no-follow and nonblocking input protection is unavailable", and 7 tests failed on native Windows. On Windows, readFileWithinLimit now opens through openWindowsInputDescriptor: lstat the path and reject a symlink, junction or non-regular file before opening it; open read-only; then require fstat of the descriptor and a second lstat of the path to report the same volume and file index as the first lstat. A swap before, during or after the open changes that identity and is rejected, and the descriptor is closed. A path such as CON or a named pipe is never opened, so the open cannot block, and Windows filesystems have no FIFOs. A filesystem that reports no file index (0) is rejected. POSIX platforms keep the O_NOFOLLOW | O_NONBLOCK open unchanged, and other platforms without those flags still reject. Tests: - HAS_SAFE_INPUT_OPEN is true on win32, so the CLI tests now run there. - Windows CLI tests: regular file accepted, junction rejected, file symlink rejected (skips with a reason when the host cannot create one), and CON, NUL and a named pipe rejected without blocking. - Deterministic race tests on every platform: openWindowsInputDescriptor takes an injectable fs, and a scripted fs lands a swap between lstat and open, around the open, right after the open, onto another volume, a link after the open, and a missing file index. Each must reject and close the descriptor. Removing any one of the six checks fails at least one test. Results: native Windows (Node 24.21) 91 tests, 85 pass, 0 fail, 6 skip; Linux (Node 24.18) 91 tests, 83 pass, 0 fail, 8 skip.
coffeegrind123
added a commit
to coffeegrind123/security-audit-skill
that referenced
this pull request
Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are open. Each was read at the diff level, tested in its own worktree, and checked for conflicts; the best of each duplicate group is ported. Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact check (skills/ part only). Overlapping changes were merged so both behaviours and both test sets survive. Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23 streaming tool calls, cloudflare#50 config-dependent reachability stays needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no longer sees the hunter's verdict, severity or fix. Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95 sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content prompt block; cloudflare#129 isolation built beside the host) moves into EXECUTION-SAFETY.md so SKILL.md stays under its token budget. Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state. Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25 cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99), README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32. UPGRADE.md records this sync procedure. Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com> Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com> Co-authored-by: Rudy Celekli <rudy@gradiahq.com> Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com> Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com> Co-authored-by: CodeInf <jiuqiaoy@gmail.com> Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com> Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-authored-by: Pizo <pizofreude@proton.me> Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com> Co-authored-by: shivam <juyaljii610@gmail.com> Co-authored-by: Dante <duanjl.china@gmail.com> Co-authored-by: Francisco <francisco@theysay.me> Co-authored-by: Roman Dolgov <alter@users.noreply.github.com> Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com> Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com> Co-authored-by: itinance <hhuebel@itinance.com> Co-authored-by: ChoYugyeong <cho4639@gmail.com> Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za> Co-authored-by: JAI <jai19kharb@gmail.com> Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com> Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com> Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com> Co-authored-by: jastfan <duohello640@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
There are six open attempts at Windows input for the validators: #59, #99, #113, #131, #145, and the Windows commit in #75. I read through all of them, and this one looks like the strongest to me. The race tests are especially nice.
Two small things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On native Windows, both validators reject every input:
Node's Windows build exposes neither
fs.constants.O_NOFOLLOWnorO_NONBLOCK(onlyO_RDONLY,O_WRONLY,O_RDWR,O_CREAT,O_EXCL,O_TRUNC,O_APPEND), because Win32 has no POSIX no-follow flag. The shell does not matter: PowerShell, cmd and Git Bash all start the samenode.exe. On Node 24.21, 7 of the 65 tests fail on Windows, and Phase 4 cannot validatefindings.jsonthere at all.The current code says "Node exposes no race-safe fallback on these platforms". This PR adds one for Windows, and keeps every other platform unchanged.
Change
readFileWithinLimitnow opens throughopenInputDescriptor:O_RDONLY | O_NOFOLLOW | O_NONBLOCK, withELOOP/EMLINKreported as a symlink.openWindowsInputDescriptor:lstatthe path (bigint). Reject a symlink or junction (Node reports reparse points as symbolic links) and any non-regular file, before opening it.fstatthe descriptor andlstatthe path again. Require all three to report the same volume (dev) and file index (ino), and the secondlstatto still not be a link.input changed while it was opened, and close the descriptor.Why this is race-safe
lstat, so it is rejected.lstatdiffers from the descriptor, so it is rejected.ino === 0nis rejected, because nothing can be compared.O_NONBLOCKguards against FIFOs, which Windows filesystems do not have. Device paths such asCON,NULand\\.\pipe\...fail the pre-openlstat(ENOENT) or the regular-file check, so they are never opened.Tests
HAS_SAFE_INPUT_OPENis true onwin32, so the existing CLI tests now run on Windows. The FIFO and POSIX-symlink tests keep their Windows skip.Windows CLI tests:
CON,NULand a named pipe are rejected without blocking.Deterministic race tests (every platform):
openWindowsInputDescriptor(file, fsApi = fs)takes an injectable fs. A scripted fs places the swap at an exact step:lstatand the open,Each must reject and close the descriptor. Pre-open rejection must not open at all.
Mutation check: removing any one of the six checks fails at least one test:
Results
windows-latestmacos-latestubuntu-latestThe CI run is in my fork, on a separate branch that only adds the workflow, so this PR contains no CI files: https://github.com/pizofreude/security-audit-skill/actions/runs/42674348712. The
windows-latestrunner can create file symlinks, so bothWindows: rejects a file symlink without following ittests run and pass there instead of skipping. The Windows skips are the FIFO and POSIX-symlink tests. The Linux and macOS skips are the Windows-only tests.End-to-end check: on native Windows, the patched validators accept a real audit run's
findings.jsonandcoverage-ledger.json. Both reportPASS.