Repository navigation
Enforce the 1,000-field object limit in validate-findings.cjs - #111
Open
MohitRawat017 wants to merge 2 commits into
Open
MohitRawat017 wants to merge 2 commits into
MohitRawat017 wants to merge 2 commits into
Conversation
Ports the object-field cardinality defenses from validate-coverage-ledger.cjs so both validators reject objects with more than 1,000 fields before JSON.parse and on the parsed document, and stops schema validation iteration once the error cap is reached. Fixes cloudflare#107
athallajovian9-cyber
added a commit
to JovianOps/security-audit-skill
that referenced
this pull request
Oct 26, 2026
coffeegrind123
added a commit
to coffeegrind123/security-audit-skill
that referenced
this pull request
Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are open. Each was read at the diff level, tested in its own worktree, and checked for conflicts; the best of each duplicate group is ported. Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact check (skills/ part only). Overlapping changes were merged so both behaviours and both test sets survive. Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23 streaming tool calls, cloudflare#50 config-dependent reachability stays needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no longer sees the hunter's verdict, severity or fix. Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95 sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content prompt block; cloudflare#129 isolation built beside the host) moves into EXECUTION-SAFETY.md so SKILL.md stays under its token budget. Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state. Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25 cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99), README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32. UPGRADE.md records this sync procedure. Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com> Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com> Co-authored-by: Rudy Celekli <rudy@gradiahq.com> Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com> Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com> Co-authored-by: CodeInf <jiuqiaoy@gmail.com> Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com> Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-authored-by: Pizo <pizofreude@proton.me> Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com> Co-authored-by: shivam <juyaljii610@gmail.com> Co-authored-by: Dante <duanjl.china@gmail.com> Co-authored-by: Francisco <francisco@theysay.me> Co-authored-by: Roman Dolgov <alter@users.noreply.github.com> Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com> Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com> Co-authored-by: itinance <hhuebel@itinance.com> Co-authored-by: ChoYugyeong <cho4639@gmail.com> Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za> Co-authored-by: JAI <jai19kharb@gmail.com> Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com> Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com> Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com> Co-authored-by: jastfan <duohello640@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107. Implements the resolution proposed there by @Inkesk-Dozing — thanks for the detailed analysis and the precise diff suggestions, which this follows closely.
What was missing
validate-coverage-ledger.cjsbounds object property cardinality both pre-parse (token scan inpreflightJsonText) and post-parse (preflightDocument), butvalidate-findings.cjshad no object-field bound at all: a findings payload within the 5 MiB input limit but with hundreds of thousands of keys passedenforceJsonTextLimits, forced a large dictionary allocation inJSON.parse, and drove an unthrottledObject.keysloop invalidate().Changes (validate-findings.cjs)
LIMITSgainsobjectFields: 1000, matching the coverage-ledger validator.enforceJsonTextLimitsnow counts object fields pre-parse: object containers carry afieldscounter and anexpectsKeyflag (set on{and on,inside an object, mirroring the existingexpectsItemarray pattern), so a string that opens a key position increments the count and a >1000-field object is rejected withinput exceeds 1000 field object limitbeforeJSON.parseis ever called. String/escape handling is unchanged — keys containing{,,,"or escapes are not miscounted.collectDataLimitErrorsrejects parsed objects with more than 1000 keys (${location}: exceeds 1000 object fields), mirroringpreflightDocumentin the ledger validator.validate()stops iterating object keys once the error cap (LIMITS.validationErrors) is reached.validate-findings.test.cjs: alignment test now expects the sharedobjectFieldslimit; new tests for pre-parse CLI rejection, the exactly-1000 boundary (passes the scanner, fails schema validation instead), and post-parse rejection.VALIDATION-AND-REPORTING.mdandRECONNAISSANCE.mdnow state the 1,000-fields-per-object bound (the ledger one was already enforced but undocumented).Verification
node --teston both test files: 68 pass, 0 fail (65 pre-existing + 3 new; baseline onmainwas 65/65).mainand this branch.main~770-805 ms wall-clock per run (rejected only at schema validation after the full parse); this branch 27-30 ms (indistinguishable from Node startup; rejected pre-parse). Happy path unchanged (~26-29 ms on both).Notes for reviewers