Skip to content

Reject in_progress units at terminal coverage validation - #84

Open
mvanhorn wants to merge 1 commit into
cloudflare:mainfrom
mvanhorn:fix/never-returned-hunter
Open

mvanhorn wants to merge 1 commit into
cloudflare:mainfrom
mvanhorn:fix/never-returned-hunter

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Oct 20, 2026 •

Copy link
Copy Markdown

Summary

A hunter that never returns left its coverage unit in in_progress with no documented way out. The completion loop only gated on planned units, and validate-coverage-ledger.cjs accepted an in_progress ledger, so Phase 6 could still claim a finished run with an open assignment.

This defines the parent transition for a missing hunter result and adds a --terminal check that rejects leftover in_progress and planned units before a complete claim.

Closes #79

Changes

  • Treat a hunter that never returns as a missing conclusion: restore planned with a null owner and empty evidence; do not archive in_progress.
  • In quick, allow one retry in the same wave; if that retry also never returns, mark the unit deferred with reason hunter_never_returned.
  • Close a wave only when no planned or in_progress units remain.
  • validate-coverage-ledger.cjs --terminal rejects in_progress and planned units. Mid-run updates omit the flag so a live assignment still validates.
  • Phase 4 and later complete-path checks use --terminal. Remaining blocked and deferred units stay valid and must be disclosed as partial coverage.
  • REPORT.md coverage summary now includes an in_progress count.

Testing

node --test skills/security-audit/validate-findings.test.cjs \
  skills/security-audit/validate-coverage-ledger.test.cjs

68 tests passed, including CLI coverage that an in_progress ledger still passes without --terminal and fails with it.

Demo

demo

Define the parent transition for a hunter that never returns, require
--terminal ledger validation before a complete coverage claim, and
include in_progress counts in the report coverage summary.
sheduxdev added a commit to sheduxdev/security-audit-skill that referenced this pull request Oct 22, 2026
sheduxdev added a commit to sheduxdev/security-audit-skill that referenced this pull request Oct 22, 2026
…f validating only the first file

Conflict in validate-coverage-ledger.cjs resolved by rejecting a second positional path inside parseArgs, since PR cloudflare#84/cloudflare#26 own the CLI argument parsing.
coffeegrind123 added a commit to coffeegrind123/security-audit-skill that referenced this pull request Nov 11, 2026
Upstream main has not moved since 2026-09-14, but 79 pull requests are
open. Each was read at the diff level, tested in its own worktree, and
checked for conflicts; the best of each duplicate group is ported.

Validators: cloudflare#143 archived verifier owner reuse, cloudflare#87 shared artifacts
within one attempt, cloudflare#102/cloudflare#103 duplicate JSON keys, cloudflare#111 1,000-field
objects, cloudflare#127 ordinary class must match assignment, cloudflare#104 self-excluded
ordinary block, cloudflare#141 verbatim quotes checked with --target, cloudflare#45 line
upper bound, cloudflare#84 --terminal rejects open units, cloudflare#145 identity-checked
open on Windows (POSIX still fails closed), cloudflare#48 retained-artifact
check (skills/ part only). Overlapping changes were merged so both
behaviours and both test sets survive.

Method: cloudflare#125 critic reasons through handoff, cloudflare#132 deployment controls
become units, cloudflare#83 carried-record gates, cloudflare#93 abort cleanup, cloudflare#23
streaming tool calls, cloudflare#50 config-dependent reachability stays
needs_validation, cloudflare#58 sequential verifier fallback, cloudflare#96 verifier no
longer sees the hunter's verdict, severity or fix.

Execution safety (cloudflare#76 neutralized git, symlink-safe copies; cloudflare#95
sanitized repo ID and prior-run compatibility; cloudflare#108 untrusted-content
prompt block; cloudflare#129 isolation built beside the host) moves into
EXECUTION-SAFETY.md so SKILL.md stays under its token budget.

Companions: cloudflare#101 cryptography, cloudflare#116 Android, cloudflare#35 edge isolate state.

Skipped: duplicates (cloudflare#82 cloudflare#106 cloudflare#91 cloudflare#70 cloudflare#138 cloudflare#131 cloudflare#75 cloudflare#63 cloudflare#97 cloudflare#123 cloudflare#25
cloudflare#26 cloudflare#16 cloudflare#40 cloudflare#42 cloudflare#142), validator-weakening fallbacks (cloudflare#59 cloudflare#113 cloudflare#99),
README/LICENSE churn, rebrands, scope creep, and cloudflare#85 cloudflare#90 cloudflare#8 cloudflare#89 cloudflare#32.

UPGRADE.md records this sync procedure.

Co-authored-by: Rohankollabathula67 <rohankollabathula67@gmail.com>
Co-authored-by: lab 1207 <hajarevaibhav527@gmail.com>
Co-authored-by: Rudy Celekli <rudy@gradiahq.com>
Co-authored-by: Mohit Rawat <rawatmohit17906@gmail.com>
Co-authored-by: MAHER AL-AQIL <18458259+maqalaqil@users.noreply.github.com>
Co-authored-by: CodeInf <jiuqiaoy@gmail.com>
Co-authored-by: pucedoteth <119044801+pucedoteth@users.noreply.github.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
Co-authored-by: Pizo <pizofreude@proton.me>
Co-authored-by: ZhiHe-ma <302089060+ZhiHe-ma@users.noreply.github.com>
Co-authored-by: shivam <juyaljii610@gmail.com>
Co-authored-by: Dante <duanjl.china@gmail.com>
Co-authored-by: Francisco <francisco@theysay.me>
Co-authored-by: Roman Dolgov <alter@users.noreply.github.com>
Co-authored-by: bodapatisaikrishna <saikrishnabodapati@gmail.com>
Co-authored-by: alvessh <117163985+alvessh@users.noreply.github.com>
Co-authored-by: itinance <hhuebel@itinance.com>
Co-authored-by: ChoYugyeong <cho4639@gmail.com>
Co-authored-by: Shaun Liebenberg <shaun@liebies.co.za>
Co-authored-by: JAI <jai19kharb@gmail.com>
Co-authored-by: ghostzeronz-coder <ghostzeronz-coder@users.noreply.github.com>
Co-authored-by: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com>
Co-authored-by: Sandeep.dhami <sandeep84397@gmail.com>
Co-authored-by: jastfan <duohello640@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A never-returned hunter assignment is a dead-end state, and 'complete' does not require the ledger to be free of in_progress/blocked units

1 participant