[HAYDEN-OAI]

Summary

Keep the three handwritten raw chat-streaming examples usable when stdout is piped or redirected to a file.

Their line rewriters unconditionally called process.stdout.cursorTo() and other terminal-only methods. On an ordinary pipe/file stream, the first API chunk instead raised TypeError: process.stdout.cursorTo is not a function, aborting the example before its function/tool call could complete.

Each example now emits one uncolored, newline-delimited completed message when stdout is not a TTY. It does not repeatedly format or append growing snapshots for redirected output. Interactive terminal rendering still updates after every chunk; request bodies, tool execution, stream timing, and the existing stream reducers are unchanged. No generated SDK files, dependencies, declarations, or custom-code budget settings change.

Regression coverage

A table-driven test runs all three actual example CLIs through the documented ts-node -T / tsconfig-paths setup with stdout connected to a pipe. A local HTTP server supplies synthetic SSE chunks containing split function/tool arguments and a final assistant response. The test checks successful exit, the two-request tool round trip, exact function/tool results, final output, and absence of terminal controls. The final text prefix must occur exactly once, preventing repeated growing snapshots.

All three cases failed on the baseline with the cursor-method exception and pass with the fix. The review follow-up's one-prefix assertion also failed on the first PR head (the prefix appeared twice) and passes with completed-message-only output. The child environments use only a synthetic key and local API URL.

Verification

• pnpm lint — passed.
• pnpm exec tsc --noEmit (TypeScript 6.0.3) — passed.
• pnpm build — CommonJS and ESM passed.
• Strict compilation of the three examples against built SDK declarations with TypeScript 4.5.5 and 4.9.5 — passed.
• Actual built-SDK smoke matrix: all three examples in CommonJS and ESM, each with pipe, file, and real pseudo-terminal stdout, on Node 22.0.0, 24.20.0, and 26.7.0 — 54 cases passed on the final follow-up. Tool request/results and final assistant text were checked; terminal control sequences appeared only in TTY mode, and redirected output contained the final text prefix only once.
• CI=true ./scripts/test — 7,012 handwritten tests across 164 files and 556 generated tests across 82 suites passed, plus all 12 snapshots; the existing two generated test skips and one skipped suite are unchanged.

Two adversarial self-review passes covered non-TTY stream capabilities, preservation of terminal rendering and tool execution, output formatting, supported runtime/compiler compatibility, isolated credentials, and child/server cleanup in the regression.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-08-31T23:45:07.709244Z	7f88ad4	Manual request
🔒 Security Review	🔄 Running since 2026-08-31T23:45:07.723813Z	7f88ad4	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 9.286s for Node SDK PR #2546.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	130ms
tests/chat-completions-create.test.ts	✅ Passed	159ms
tests/chat-completions-stream.test.ts	✅ Passed	107ms
tests/files-content-binary.test.ts	✅ Passed	109ms
tests/files-create-multipart.test.ts	✅ Passed	155ms
tests/files-list-pagination.test.ts	✅ Passed	134ms
tests/initialize-config.test.ts	✅ Passed	140ms
tests/instance-isolation.test.ts	✅ Passed	99ms
tests/models-list.test.ts	✅ Passed	109ms
tests/responses-background-lifecycle.test.ts	✅ Passed	200ms
tests/responses-body-method-errors.test.ts	✅ Passed	260ms
tests/responses-cancel-timeout.test.ts	✅ Passed	194ms
tests/responses-cancel.test.ts	✅ Passed	194ms
tests/responses-compact-retries.test.ts	✅ Passed	222ms
tests/responses-compact.test.ts	✅ Passed	198ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	78ms
tests/responses-create-advanced.test.ts	✅ Passed	127ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.16s
tests/responses-create-errors.test.ts	✅ Passed	177ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	124ms
tests/responses-create-retries.test.ts	✅ Passed	237ms
tests/responses-create-stream-failures.test.ts	✅ Passed	160ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.144s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.199s
tests/responses-create-stream.test.ts	✅ Passed	134ms
tests/responses-create-terminal-states.test.ts	✅ Passed	156ms
tests/responses-create-timeout.test.ts	✅ Passed	189ms
tests/responses-create.test.ts	✅ Passed	140ms
tests/responses-delete.test.ts	✅ Passed	208ms
tests/responses-input-items-errors.test.ts	✅ Passed	156ms
tests/responses-input-items-list.test.ts	✅ Passed	196ms
tests/responses-input-items-options.test.ts	✅ Passed	95ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	210ms
tests/responses-input-tokens-count.test.ts	✅ Passed	175ms
tests/responses-malformed-inputs.test.ts	✅ Passed	1.858s
tests/responses-not-found-errors.test.ts	✅ Passed	210ms
tests/responses-parse.test.ts	✅ Passed	144ms
tests/responses-retrieve-retries.test.ts	✅ Passed	192ms
tests/responses-retrieve.test.ts	✅ Passed	199ms
tests/responses-stored-method-errors.test.ts	✅ Passed	479ms
tests/retry-behavior.test.ts	✅ Passed	3.179s
tests/sdk-error-shape.test.ts	✅ Passed	242ms

View OkTest run #33451953600

_{SDK merge (4b33821e642f) · head (7f88ad436e3f) · base (eea2292a4a52) · OkTest (2b1bdfd25e98)}

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared eea2292a4a52 → 7f88ad436e3f. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33452001022 --repo openai/openai-node \
  --name castiron-custom-code-33452001022-1 --dir /tmp/castiron-custom-code-33452001022-1
git apply --stat /tmp/castiron-custom-code-33452001022-1/custom-code.patch
cat /tmp/castiron-custom-code-33452001022-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin eea2292a4a523da9405161dde0a79ac5dc2ecb2a 7f88ad436e3f1991b94658d6409d9331f3cc0a6d
python3 scripts/castiron/custom_code_report.py report \
  --base eea2292a4a523da9405161dde0a79ac5dc2ecb2a \
  --head 7f88ad436e3f1991b94658d6409d9331f3cc0a6d --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-7f88ad436e3f
cat /tmp/castiron-custom-code-7f88ad436e3f/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84a597efa6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[HAYDEN-OAI]

@codex review

Addressed the repeated-output finding in 7f88ad4. TTY output still redraws after each chunk; redirected output formats and prints each completed message only once. No delta reconstruction, additional retained state, parser changes, or stream-timing changes were added.

The new real-CLI assertion failed on the prior head for all three examples because the final text prefix appeared twice, and now passes with exactly one occurrence. Parent-worktree verification passed: 7,012 handwritten plus 556 generated tests, lint, strict TypeScript 6/4.5/4.9 checks, CJS/ESM build, and 54 built-SDK cases covering pipe/file/real-TTY output on Node 22.0.0, 24.20.0, and 26.7.0.