[HAYDEN-OAI]

Summary

The image-streaming example catches request, stream, and filesystem failures but only logs them. It therefore exits successfully even when no final image can be produced, misleading shell scripts and CI that invoke it.

Set process.exitCode = 1 in the existing catch handler, matching the non-streaming picture example. This preserves the diagnostic and allows normal stream/socket cleanup instead of forcing an immediate exit.

Regression coverage

Four real child-process cases run the actual executable example against a synthetic loopback HTTP server:

• HTTP 400 rejection.
• A named SSE error after a partial image has been saved.
• A final-image write failure, induced portably by creating a directory at the output filename.
• Successful partial and final saves.

The tests assert exact exit status, request endpoint/authentication, scenario-specific diagnostics, and saved bytes. Each child has an isolated environment and temporary working directory; child processes, connections, and temporary output are cleaned up.

The test-only commit reproduced three 0-instead-of-1 failures and one passing success control locally before the fix. The final candidate passes all four cases.

Validation

• CI on 8208d2ef: 7,013 handwritten tests, 556 generated tests, and 12 generated snapshots pass on each of Node 22, 24, and 26. Existing skipped tests are unchanged.
• All 14 non-live ecosystem fixtures pass. Canonical lint, build, published-source TypeScript 4.9/6 checks, package/export validation, and benchmarks pass.
• Packed-package CJS, ESM, browser-bundling, and source-map checks pass on the supported Node 22/24 CI lines.
• Local full handwritten suite, canonical lint, TypeScript checking, and build pass.
• Independent focused execution passes on Node 24.20.0 and 26.7.0. A separate direct execution on exact Node 22.0.0 passes all four native HTTP/file cases with exit statuses 1/1/1/0, without requiring the newer pnpm tooling to run on that runtime.

Adversarial self-review and an independent closing review found no actionable issues in error coverage, compatibility, environment isolation, or cleanup.

Scope

One production line plus one focused test file. Both paths are handwritten and absent from the verified public generated reference 65094c1637432c123c310d03e0cda1e7e6f1c997. No SDK source, public API, dependencies, workflows, generated files, or custom-code budgets change.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 11.865s for Node SDK PR #2563.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	280ms
tests/chat-completions-create.test.ts	✅ Passed	324ms
tests/chat-completions-stream.test.ts	✅ Passed	296ms
tests/files-content-binary.test.ts	✅ Passed	195ms
tests/files-create-multipart.test.ts	✅ Passed	218ms
tests/files-list-pagination.test.ts	✅ Passed	232ms
tests/initialize-config.test.ts	✅ Passed	266ms
tests/instance-isolation.test.ts	✅ Passed	195ms
tests/models-list.test.ts	✅ Passed	204ms
tests/responses-background-lifecycle.test.ts	✅ Passed	266ms
tests/responses-body-method-errors.test.ts	✅ Passed	326ms
tests/responses-cancel-timeout.test.ts	✅ Passed	200ms
tests/responses-cancel.test.ts	✅ Passed	291ms
tests/responses-compact-retries.test.ts	✅ Passed	306ms
tests/responses-compact.test.ts	✅ Passed	292ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	147ms
tests/responses-create-advanced.test.ts	✅ Passed	247ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.317s
tests/responses-create-errors.test.ts	✅ Passed	227ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	191ms
tests/responses-create-retries.test.ts	✅ Passed	344ms
tests/responses-create-stream-failures.test.ts	✅ Passed	283ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.185s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.638s
tests/responses-create-stream.test.ts	✅ Passed	98ms
tests/responses-create-terminal-states.test.ts	✅ Passed	349ms
tests/responses-create-timeout.test.ts	✅ Passed	227ms
tests/responses-create.test.ts	✅ Passed	313ms
tests/responses-delete.test.ts	✅ Passed	272ms
tests/responses-input-items-errors.test.ts	✅ Passed	334ms
tests/responses-input-items-list.test.ts	✅ Passed	204ms
tests/responses-input-items-options.test.ts	✅ Passed	229ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	237ms
tests/responses-input-tokens-count.test.ts	✅ Passed	282ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.279s
tests/responses-not-found-errors.test.ts	✅ Passed	260ms
tests/responses-parse.test.ts	✅ Passed	252ms
tests/responses-retrieve-retries.test.ts	✅ Passed	366ms
tests/responses-retrieve.test.ts	✅ Passed	296ms
tests/responses-stored-method-errors.test.ts	✅ Passed	839ms
tests/retry-behavior.test.ts	✅ Passed	3.039s
tests/sdk-error-shape.test.ts	✅ Passed	313ms

View OkTest run #33560277750

_{SDK merge (b44cdc382fe7) · head (8208d2efd095) · base (82c5b2def367) · OkTest (2b1bdfd25e98)}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-01T21:19:06.133061Z	8208d2e	PR opened
🔒 Security Review	✅ Completed 2026-09-01T21:20:09.926756Z	8208d2e	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 82c5b2def367 → 8208d2efd095. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33560347524 --repo openai/openai-node \
  --name castiron-custom-code-33560347524-1 --dir /tmp/castiron-custom-code-33560347524-1
git apply --stat /tmp/castiron-custom-code-33560347524-1/custom-code.patch
cat /tmp/castiron-custom-code-33560347524-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 82c5b2def367f88d9c05c83b23dfb78ac6b9f25c 8208d2efd095f9b2bac1f6039da28f59a54a7624
python3 scripts/castiron/custom_code_report.py report \
  --base 82c5b2def367f88d9c05c83b23dfb78ac6b9f25c \
  --head 8208d2efd095f9b2bac1f6039da28f59a54a7624 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-8208d2efd095
cat /tmp/castiron-custom-code-8208d2efd095/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch