[HAYDEN-OAI]

Summary

Fix constructor inheritance for the callable CommonJS entrypoint returned by require('openai').

The handwritten packaging wrapper currently returns new exports.default(...) regardless of the constructor being invoked. As a result, new DerivedClient(...) silently returns a base-client instance: subclass methods and protected overrides disappear, withOptions() loses the subclass, and even new OpenAI(...) instanceof OpenAI is false.

The wrapper now forwards new.target through Reflect.construct() and shares the SDK class's instance and static prototype chains. Calling OpenAI(options) without new still works. Existing named/default exports, own export names, module paths, and ESM output are unchanged.

Only two handwritten files change: the CommonJS packaging helper and the existing plain-Node ecosystem fixture. No generated SDK source, declaration, export-map, dependency, or custom-code-budget changes are included.

Regression

Replace the Node.js fixture's construction-only smoke check with assertions against the actual packed and installed public package:

• construction with and without new, plus named/default aliases;
• instanceof, instance methods, and static inheritance through two subclass levels;
• subclass-preserving withOptions() cloning;
• real SDK requests through an overridden defaultQuery() method, with caller query settings preserved.

The canonical ecosystem runner freshly built, packed, and installed main, then failed the new instanceof assertion. Repeating the same command after the fix passes. The transport is a local synthetic fetch implementation; no live credentials or API calls are used.

Validation

• pnpm exec ts-node -T ecosystem-tests/cli.ts node-js: passed after failing on main.
• The installed-package constructor regression passed on Node 22.0.0, 24.20.0, and 26.7.0.
• pnpm exec ts-node -T ecosystem-tests/cli.ts node-ts-cjs node-ts4.5-jest28: passed, including TypeScript 5.9/Jest 29 and TypeScript 4.5.5/Jest 28.
• pnpm exec ts-node -T scripts/test-packed-package.ts: passed CommonJS/ESM imports, ES2020 browser bundling, TypeScript 4.9/6 checks, optional-integration checks, and 1,286 source maps.
• CI=true ./scripts/test: 7,009 handwritten and 556 generated tests passed; 12 snapshots passed, with existing generated skips unchanged.
• pnpm lint, pnpm exec tsc --noEmit, and fresh builds: passed. The changed ecosystem fixture was also checked explicitly with the pinned formatter.

Adversarial self-review

Reviewed constructor forwarding, callable compatibility, subclass hooks, cloning, nested inheritance, export identity, static members, and module initialization twice. Prototype targets are the already-loaded SDK class, not caller-controlled options. The SDK constructor and its authentication/browser checks still execute normally, and the existing public aliases remain intact. No wrapper cache, proxy abstraction, or alternate client implementation is introduced.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-31T23:24:23.932119Z	c22924a	PR opened
🔒 Security Review	✅ Completed 2026-08-31T23:24:59.168757Z	c22924a	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared eea2292a4a52 → c22924a0d552. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33450365855 --repo openai/openai-node \
  --name castiron-custom-code-33450365855-1 --dir /tmp/castiron-custom-code-33450365855-1
git apply --stat /tmp/castiron-custom-code-33450365855-1/custom-code.patch
cat /tmp/castiron-custom-code-33450365855-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin eea2292a4a523da9405161dde0a79ac5dc2ecb2a c22924a0d552a2c6ffa7acaf3c5f44aa1cf04f6f
python3 scripts/castiron/custom_code_report.py report \
  --base eea2292a4a523da9405161dde0a79ac5dc2ecb2a \
  --head c22924a0d552a2c6ffa7acaf3c5f44aa1cf04f6f --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-c22924a0d552
cat /tmp/castiron-custom-code-c22924a0d552/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 9.811s for Node SDK PR #2547.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	158ms
tests/chat-completions-create.test.ts	✅ Passed	213ms
tests/chat-completions-stream.test.ts	✅ Passed	126ms
tests/files-content-binary.test.ts	✅ Passed	153ms
tests/files-create-multipart.test.ts	✅ Passed	164ms
tests/files-list-pagination.test.ts	✅ Passed	138ms
tests/initialize-config.test.ts	✅ Passed	127ms
tests/instance-isolation.test.ts	✅ Passed	101ms
tests/models-list.test.ts	✅ Passed	125ms
tests/responses-background-lifecycle.test.ts	✅ Passed	223ms
tests/responses-body-method-errors.test.ts	✅ Passed	288ms
tests/responses-cancel-timeout.test.ts	✅ Passed	186ms
tests/responses-cancel.test.ts	✅ Passed	215ms
tests/responses-compact-retries.test.ts	✅ Passed	255ms
tests/responses-compact.test.ts	✅ Passed	205ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	109ms
tests/responses-create-advanced.test.ts	✅ Passed	195ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.096s
tests/responses-create-errors.test.ts	✅ Passed	201ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	108ms
tests/responses-create-retries.test.ts	✅ Passed	236ms
tests/responses-create-stream-failures.test.ts	✅ Passed	222ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.148s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.333s
tests/responses-create-stream.test.ts	✅ Passed	72ms
tests/responses-create-terminal-states.test.ts	✅ Passed	203ms
tests/responses-create-timeout.test.ts	✅ Passed	194ms
tests/responses-create.test.ts	✅ Passed	152ms
tests/responses-delete.test.ts	✅ Passed	249ms
tests/responses-input-items-errors.test.ts	✅ Passed	149ms
tests/responses-input-items-list.test.ts	✅ Passed	167ms
tests/responses-input-items-options.test.ts	✅ Passed	98ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	215ms
tests/responses-input-tokens-count.test.ts	✅ Passed	232ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.008s
tests/responses-not-found-errors.test.ts	✅ Passed	220ms
tests/responses-parse.test.ts	✅ Passed	245ms
tests/responses-retrieve-retries.test.ts	✅ Passed	273ms
tests/responses-retrieve.test.ts	✅ Passed	212ms
tests/responses-stored-method-errors.test.ts	✅ Passed	553ms
tests/retry-behavior.test.ts	✅ Passed	3.024s
tests/sdk-error-shape.test.ts	✅ Passed	262ms

View OkTest run #33450347200

_{SDK merge (ee1d479b05d8) · head (c22924a0d552) · base (eea2292a4a52) · OkTest (2b1bdfd25e98)}