[HAYDEN-OAI]

Summary

• Capture the original parameters schema once in zodFunction() and zodResponsesFunction(), and use that same reference for both JSON Schema generation and argument parsing.
• Add a focused public-entrypoint regression covering Zod v3, v4, and v4 Mini through Chat Completions and Responses, in both parsing and streaming modes.
• Preserve callbacks, schema-object identity, serialization, and public types. No generated files, dependencies, or parser implementations are changed.

Reproduction

Create a tool using a six-character string schema, then reuse its options object by assigning a four-character schema to options.parameters. On main, the existing tool still sends the six-character JSON Schema, but its parser follows the replacement schema: it rejects valid original arguments and accepts replacement-only arguments. A newly constructed tool correctly uses the replacement.

The fix binds each tool's parser to the schema used when that tool was constructed, matching the existing behavior of the Standard Schema helpers.

Validation

• New 72-case regression: 24 failures and 48 passing controls before the source change; all 72 pass afterward.
• Full canonical handwritten suite: 7,872 tests passed across 206 files.
• Built-package CJS/ESM parsing and CJS streaming checks pass on exact Node 22.0.0, Node 24.19.0, and Node 26.7.0, including retained-tool and newly-created-tool acceptance/rejection controls.
• All 651 published declaration files are byte-identical to main. Repository TypeScript 6, published-source TypeScript 4.9/6, CJS/ESM build, formatting, canonical lint, and git diff --check pass.
• publint passes with the same pre-existing vendored-export warning as main.
• Independent adversarial review checks single-read getters, parser receiver/schema identity, callback identity, unchanged serialized tool definitions, validation, and public parse/stream regression coverage.

The generated resource suite and remaining platform integrations are left to CI. This is separate from #2463's extracted-definition conversion work.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-06T23:18:48.314561Z	773242a	PR opened
🔒 Security Review	✅ Completed 2026-09-06T23:19:57.594220Z	773242a	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 10.362s for Node SDK PR #2662.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	139ms
tests/chat-completions-create.test.ts	✅ Passed	211ms
tests/chat-completions-stream.test.ts	✅ Passed	213ms
tests/files-content-binary.test.ts	✅ Passed	179ms
tests/files-create-multipart.test.ts	✅ Passed	141ms
tests/files-list-pagination.test.ts	✅ Passed	143ms
tests/initialize-config.test.ts	✅ Passed	200ms
tests/instance-isolation.test.ts	✅ Passed	115ms
tests/models-list.test.ts	✅ Passed	146ms
tests/responses-background-lifecycle.test.ts	✅ Passed	203ms
tests/responses-body-method-errors.test.ts	✅ Passed	367ms
tests/responses-cancel-timeout.test.ts	✅ Passed	230ms
tests/responses-cancel.test.ts	✅ Passed	219ms
tests/responses-compact-retries.test.ts	✅ Passed	242ms
tests/responses-compact.test.ts	✅ Passed	200ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	121ms
tests/responses-create-advanced.test.ts	✅ Passed	168ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.136s
tests/responses-create-errors.test.ts	✅ Passed	203ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	166ms
tests/responses-create-retries.test.ts	✅ Passed	277ms
tests/responses-create-stream-failures.test.ts	✅ Passed	201ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.149s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.648s
tests/responses-create-stream.test.ts	✅ Passed	97ms
tests/responses-create-terminal-states.test.ts	✅ Passed	208ms
tests/responses-create-timeout.test.ts	✅ Passed	213ms
tests/responses-create.test.ts	✅ Passed	167ms
tests/responses-delete.test.ts	✅ Passed	244ms
tests/responses-input-items-errors.test.ts	✅ Passed	226ms
tests/responses-input-items-list.test.ts	✅ Passed	183ms
tests/responses-input-items-options.test.ts	✅ Passed	114ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	270ms
tests/responses-input-tokens-count.test.ts	✅ Passed	212ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.225s
tests/responses-not-found-errors.test.ts	✅ Passed	226ms
tests/responses-parse.test.ts	✅ Passed	188ms
tests/responses-retrieve-retries.test.ts	✅ Passed	233ms
tests/responses-retrieve.test.ts	✅ Passed	216ms
tests/responses-stored-method-errors.test.ts	✅ Passed	458ms
tests/retry-behavior.test.ts	✅ Passed	3.012s
tests/sdk-error-shape.test.ts	✅ Passed	253ms

View OkTest run #34066473476

_{SDK merge (695feec567c7) · head (773242a3463f) · base (7b5d1209090f) · OkTest (2b1bdfd25e98)}

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 7b5d1209090f → 773242a3463f. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 34066489761 --repo openai/openai-node \
  --name castiron-custom-code-34066489761-1 --dir /tmp/castiron-custom-code-34066489761-1
git apply --stat /tmp/castiron-custom-code-34066489761-1/custom-code.patch
cat /tmp/castiron-custom-code-34066489761-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 7b5d1209090f82f56b4971976147b5c2a859452e 773242a3463fe57641c1c0b3d040d6f81fe634f0
python3 scripts/castiron/custom_code_report.py report \
  --base 7b5d1209090f82f56b4971976147b5c2a859452e \
  --head 773242a3463fe57641c1c0b3d040d6f81fe634f0 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-773242a3463f
cat /tmp/castiron-custom-code-773242a3463f/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[jbeckwith-oai]

Reviewed the exact head 773242a. Capturing options.parameters once keeps the serialized JSON Schema and the parser bound to the same construction-time object for both Chat Completions and Responses without changing callbacks, public types, generated files, dependencies, or parser internals. The regression covers Zod v3, v4, and v4 Mini across parse and streaming paths, including retained-tool and newly-created-tool acceptance/rejection behavior. I also ran the focused 72-case test locally (72/72 passed), oxlint and oxfmt on both changed files, and git diff --check; all passed. No unresolved threads or blocking findings. The remaining ecosystem and Node matrix checks are still running.

[markstuart-oai]

Reviewed exact head 773242a against 7b5d120. No actionable correctness, security, or maintainability findings. Capturing the schema at construction is the direct fix at the owning boundary, consistent with Standard Schema. No new production branches or abstractions are needed. zod.ts grows 497→499 lines; the separate 259-line regression earns its fixtures by exercising distinct public parse/stream wire contracts. No generated files, dependencies, parser implementations, or exported signatures change.

Fresh validation on Node 24.20.0: all 72 regression cases pass; substituting the exact base zod.ts through a temporary test-loader configuration reproduces 24 retained-tool failures with 48 passing controls. Five adjacent helper/parser/Responses-stream suites pass (672 tests). Independent probes verify original/new-tool acceptance and rejection, single-read parameters getters, receiver/schema identity, callback identity, unchanged serialized definitions, malformed-JSON rejection, and Standard Schema binding. Changed-file oxlint, oxfmt, and git diff --check pass.

Validation limits: reused dependencies with an identical lockfile; pnpm exec rejects stale workspace-install metadata, and direct repository typechecking reports missing example dependencies (dotenv, @azure/identity, express). I did not rerun the author's full suite, built-package/declaration comparison, or platform/Node matrix.