[HAYDEN-OAI]

Summary

Clean up the owned Steady process when scripts/mock --daemon fails during startup.

Previously, a live process whose health endpoint never became ready survived the launcher's 300-attempt timeout. The script exited with status 1 but left the mock server running.

The daemon branch now captures its child PID immediately and installs an EXIT trap that terminates and waits for that exact child. Cleanup commands cannot replace the original failure status. The trap is removed immediately after health succeeds, before the final output, so a healthy daemon remains running.

Foreground execution, command/spec arguments, health probes, polling intervals, and successful startup behavior are unchanged. Cleanup retains the locked server's normal SIGTERM behavior; this does not add process-group killing, port-wide discovery, or shutdown escalation.

Regression coverage

The existing tests invoke the actual Bash launcher with isolated synthetic Steady and health-check executables:

• Foreground execution remains synchronous and uses the locked local binary.
• A healthy daemon remains alive after the launcher exits, then the test cleans up its exact PID.
• An early child exit preserves failure status and startup-log output.
• A live but unhealthy child is terminated and reaped when startup times out.

The timeout regression failed against unchanged main while the two original launcher controls passed. Final fixtures publish the child PID before readiness, use bounded failing probes, verify the missing-PID probe terminates, and recover cleanup ownership in finally. The preflight invokes Bash explicitly for compatibility with the existing launcher tests.

Validation

• Final focused tests: 4/4 on Node 22.0.0, 24.20.0, and 26.7.0.
• Complete CI on the exact final commit: 7,011 handwritten tests across 163 files, 556 generated tests across 82 suites, and 12 snapshots pass on the Node 22, 24, and 26 matrix. Existing generated skips are unchanged.
• Lint, TypeScript, build, packed-package checks, offline ecosystem tests, and performance benchmarks pass.
• Bash syntax, diff checks, executable mode, and byte-for-byte comparison of the published files with the locally tested files pass.

The isolated local environment exposed a PID-namespace mismatch in the separate scripts/test cleanup: generated assertions passed but that wrapper exited nonzero. No workaround was committed; the complete unchanged test entrypoint and cleanup pass in GitHub CI.

Repeated adversarial self-review and independent final review found no remaining actionable issue. Only the handwritten scripts/mock and tests/mock-launcher.test.ts change; no SDK implementation, generated code, dependencies, or custom-code-budget settings change.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-01T19:11:19.614962Z	b8b854b	PR opened
🔒 Security Review	✅ Completed 2026-09-01T19:12:51.764170Z	b8b854b	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 8.456s for Node SDK PR #2558.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	113ms
tests/chat-completions-create.test.ts	✅ Passed	177ms
tests/chat-completions-stream.test.ts	✅ Passed	95ms
tests/files-content-binary.test.ts	✅ Passed	106ms
tests/files-create-multipart.test.ts	✅ Passed	121ms
tests/files-list-pagination.test.ts	✅ Passed	149ms
tests/initialize-config.test.ts	✅ Passed	124ms
tests/instance-isolation.test.ts	✅ Passed	82ms
tests/models-list.test.ts	✅ Passed	108ms
tests/responses-background-lifecycle.test.ts	✅ Passed	155ms
tests/responses-body-method-errors.test.ts	✅ Passed	235ms
tests/responses-cancel-timeout.test.ts	✅ Passed	193ms
tests/responses-cancel.test.ts	✅ Passed	166ms
tests/responses-compact-retries.test.ts	✅ Passed	177ms
tests/responses-compact.test.ts	✅ Passed	198ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	77ms
tests/responses-create-advanced.test.ts	✅ Passed	149ms
tests/responses-create-disconnect.test.ts	✅ Passed	995ms
tests/responses-create-errors.test.ts	✅ Passed	141ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	89ms
tests/responses-create-retries.test.ts	✅ Passed	145ms
tests/responses-create-stream-failures.test.ts	✅ Passed	105ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.128s
tests/responses-create-stream-wire.test.ts	✅ Passed	1.932s
tests/responses-create-stream.test.ts	✅ Passed	59ms
tests/responses-create-terminal-states.test.ts	✅ Passed	164ms
tests/responses-create-timeout.test.ts	✅ Passed	178ms
tests/responses-create.test.ts	✅ Passed	99ms
tests/responses-delete.test.ts	✅ Passed	114ms
tests/responses-input-items-errors.test.ts	✅ Passed	150ms
tests/responses-input-items-list.test.ts	✅ Passed	145ms
tests/responses-input-items-options.test.ts	✅ Passed	78ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	180ms
tests/responses-input-tokens-count.test.ts	✅ Passed	169ms
tests/responses-malformed-inputs.test.ts	✅ Passed	1.625s
tests/responses-not-found-errors.test.ts	✅ Passed	177ms
tests/responses-parse.test.ts	✅ Passed	130ms
tests/responses-retrieve-retries.test.ts	✅ Passed	194ms
tests/responses-retrieve.test.ts	✅ Passed	181ms
tests/responses-stored-method-errors.test.ts	✅ Passed	486ms
tests/retry-behavior.test.ts	✅ Passed	3.22s
tests/sdk-error-shape.test.ts	✅ Passed	181ms

View OkTest run #33547900659

_{SDK merge (93d122fe04d5) · head (b8b854b9ba8d) · base (a408e0b8d993) · OkTest (2b1bdfd25e98)}

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared a408e0b8d993 → b8b854b9ba8d. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33547954307 --repo openai/openai-node \
  --name castiron-custom-code-33547954307-1 --dir /tmp/castiron-custom-code-33547954307-1
git apply --stat /tmp/castiron-custom-code-33547954307-1/custom-code.patch
cat /tmp/castiron-custom-code-33547954307-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin a408e0b8d993fb4e04852cbaecbbcd92cee0dd1c b8b854b9ba8de315f80bf5b11e46606ff227d942
python3 scripts/castiron/custom_code_report.py report \
  --base a408e0b8d993fb4e04852cbaecbbcd92cee0dd1c \
  --head b8b854b9ba8de315f80bf5b11e46606ff227d942 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-b8b854b9ba8d
cat /tmp/castiron-custom-code-b8b854b9ba8d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch