[HAYDEN-OAI]

Problem

Steady's cache wrapper installs SIGINT and SIGTERM handlers before acquiring the cache lifecycle lock, but those handlers only forward signals to an already-created child. If an install or mock command is waiting for another cache user, cancellation is swallowed. Once the lock is released, the cancelled command can still start and exit successfully.

This is reproducible through the actual wrapper CLI on unchanged main. Holding the lock, interrupting the wrapper, and then releasing the lock still prints the command's execution marker and exits zero for either signal.

Change

Make the existing lock wait cancellable with a standard AbortSignal before child startup. Recheck cancellation after acquiring the lock and before running the command. A pending SIGINT or SIGTERM returns the existing signal-equivalent status of 130 or 143 without starting the command or reacquiring another owner's lock for cleanup.

Preserve the first cancellation signal, distinguish the actual cancellation error from unrelated filesystem failures, and keep active-child signal forwarding, exit codes, lease cleanup, cache pruning, and lock timeout behavior unchanged.

Only the handwritten cache wrapper and a new cohesive CLI regression file change. Both paths are absent from the verified pure-generated snapshot d223f5ab382c6a7d64f3863e75865624cbefad21. There are no dependency, manifest, downloaded-source, SDK, lease-format, or generated-file changes, and no open PR covers this issue.

Verification

• The exact final six-case regression file on unchanged main 124b6525497a93315f8563d8e4e3d552cbb0518f has two expected pending-cancellation failures and four passing controls. All six pass after the fix on Node 22.22.3, 24.19.0, and 26.7.0.
• The regressions run the actual wrapper, hold another owner's lock throughout cancellation, and verify no command starts, the ownership sentinel survives, and no lease is created. Controls cover normal zero/nonzero exits and both signals after the command starts.
• Existing cache-lifecycle tests pass on all three Node lines. Cache and concurrent-publication controls also pass on the exact Node 22.0.0 floor.
• The complete Steady integration passes both before and after the fix, including the pinned installation, offline launch, source/runtime integrity checks, relative paths, server health, and signal-driven shutdown.
• Full TypeScript checking, canonical lint, and the final diff check pass.
• All 7,673 handwritten tests pass across 199 files on Node 24.19.0 through the canonical test script with two workers. An initial full-suite attempt was interrupted by host disk exhaustion; the unchanged rerun passed after disk space recovered.

Adversarial review

Reviewed cancellation during lock acquisition, lock and lease ownership, error filtering, first-signal behavior, and active-child compatibility. Independent review caught a test-cleanup risk involving historical process IDs; the final fixture uses a bounded child lifetime and only signals the live owned wrapper handle. Repeated review found no remaining required changes.

Signal-dependent regressions are POSIX-only; ordinary exit controls remain portable. All fixture data is synthetic, and no live OpenAI API call is made.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-05T18:58:39.285983Z	5c62a0c	PR opened
🔒 Security Review	✅ Completed 2026-09-05T19:00:43.536645Z	5c62a0c	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 10.72s for Node SDK PR #2636.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	166ms
tests/chat-completions-create.test.ts	✅ Passed	224ms
tests/chat-completions-stream.test.ts	✅ Passed	224ms
tests/files-content-binary.test.ts	✅ Passed	188ms
tests/files-create-multipart.test.ts	✅ Passed	134ms
tests/files-list-pagination.test.ts	✅ Passed	179ms
tests/initialize-config.test.ts	✅ Passed	250ms
tests/instance-isolation.test.ts	✅ Passed	103ms
tests/models-list.test.ts	✅ Passed	149ms
tests/responses-background-lifecycle.test.ts	✅ Passed	248ms
tests/responses-body-method-errors.test.ts	✅ Passed	300ms
tests/responses-cancel-timeout.test.ts	✅ Passed	230ms
tests/responses-cancel.test.ts	✅ Passed	207ms
tests/responses-compact-retries.test.ts	✅ Passed	241ms
tests/responses-compact.test.ts	✅ Passed	232ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	145ms
tests/responses-create-advanced.test.ts	✅ Passed	202ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.171s
tests/responses-create-errors.test.ts	✅ Passed	236ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	196ms
tests/responses-create-retries.test.ts	✅ Passed	261ms
tests/responses-create-stream-failures.test.ts	✅ Passed	240ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.148s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.55s
tests/responses-create-stream.test.ts	✅ Passed	111ms
tests/responses-create-terminal-states.test.ts	✅ Passed	331ms
tests/responses-create-timeout.test.ts	✅ Passed	233ms
tests/responses-create.test.ts	✅ Passed	152ms
tests/responses-delete.test.ts	✅ Passed	231ms
tests/responses-input-items-errors.test.ts	✅ Passed	181ms
tests/responses-input-items-list.test.ts	✅ Passed	198ms
tests/responses-input-items-options.test.ts	✅ Passed	131ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	256ms
tests/responses-input-tokens-count.test.ts	✅ Passed	258ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.254s
tests/responses-not-found-errors.test.ts	✅ Passed	252ms
tests/responses-parse.test.ts	✅ Passed	228ms
tests/responses-retrieve-retries.test.ts	✅ Passed	286ms
tests/responses-retrieve.test.ts	✅ Passed	229ms
tests/responses-stored-method-errors.test.ts	✅ Passed	589ms
tests/retry-behavior.test.ts	✅ Passed	2.998s
tests/sdk-error-shape.test.ts	✅ Passed	340ms

View OkTest run #33985588894

_{SDK merge (94914f9874a6) · head (5c62a0ce1bd4) · base (124b6525497a) · OkTest (2b1bdfd25e98)}

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 124b6525497a → 5c62a0ce1bd4. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33985913730 --repo openai/openai-node \
  --name castiron-custom-code-33985913730-1 --dir /tmp/castiron-custom-code-33985913730-1
git apply --stat /tmp/castiron-custom-code-33985913730-1/custom-code.patch
cat /tmp/castiron-custom-code-33985913730-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 124b6525497a93315f8563d8e4e3d552cbb0518f 5c62a0ce1bd42c1fadeec8cbfd2068edb988c80b
python3 scripts/castiron/custom_code_report.py report \
  --base 124b6525497a93315f8563d8e4e3d552cbb0518f \
  --head 5c62a0ce1bd42c1fadeec8cbfd2068edb988c80b --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-5c62a0ce1bd4
cat /tmp/castiron-custom-code-5c62a0ce1bd4/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[jbeckwith-oai]

Reviewed the exact head across the full two-file diff. The AbortSignal integration makes only the pre-spawn lock wait cancellable, preserves the first signal, rechecks cancellation after lock acquisition, removes only a lock acquired by this process, and leaves active-child forwarding plus ordinary exit and cleanup behavior intact. The regression tests exercise the real wrapper for both pending signals, both active-child signals, and ordinary zero/nonzero exits while protecting another owners lock and asserting no lease or command startup. Review threads are clear and the full Node matrix is green. No blocking findings.

[markstuart-oai]

Reviewed both changed files and the Steady install/launch and lease-cleanup paths. The abort signal stays with the pending acquisition; the post-acquisition check releases an acquired lock before cancellation returns, and the cleanup guard avoids reacquiring another owner's lock while preserving unrelated error behavior. Active-child forwarding remains intact.

Validated on Node 24.20.0: all six CLI regressions pass at this head; the same tests on base reproduce only the two pending-cancellation failures. Existing cache lifecycle tests and additional isolated checks for pre-abort, acquisition-boundary cancellation, first-signal preservation, exactly-once release, filesystem/action errors, and listener cleanup pass. Canonical lint passes. No substantive correctness or maintainability findings. Full TypeScript checking could not pass with the available dependency tree because example-only dotenv, @azure/identity, and express imports are missing; I did not rerun the full SDK suite or download the Steady integration dependencies.