[HAYDEN-OAI]

Summary

• Pass the complete options metadata to AutoParseableTool and AutoParseableResponseTool instead of passing the parsed argument value type a second time.
• Preserve explicit parser-output, callback-argument, and function-name types in both public custom-tool factories.
• Derive Chat Completions runnable metadata from the supplied callback: a guaranteed callback is runnable, undefined is parse-only, and an optional callback remains unguaranteed. Callback parameters are checked against the parser's declared output.

Reproduction

A custom factory call with metadata such as { name: 'lookup'; arguments: { city: string }; function: (args: { city: string }) => string } currently returns a tool whose $parseRaw() result and name metadata are unknown. The argument object is incorrectly treated as another metadata object. A valid callback-backed Chat Completions tool is also incorrectly marked non-runnable and rejected by both public runTools() overloads.

A strict public-import consumer reproduced these errors before the change. The new compile-time regressions fail on the base and pass with the fix. They also ensure correcting the metadata cannot accidentally make a callback-free or optional-callback tool runnable, even if the declared metadata contains a function or the parsed argument object has its own name, arguments, and function properties.

Validation

• Complete CI=true ./scripts/test: 7,012 handwritten tests and 556 generated tests pass (2 existing generated skips), with all 12 generated snapshots passing.
• Focused factory/parser suites: 46 tests pass.
• pnpm exec tsc --noEmit, pnpm lint, and pnpm build pass. CI's existing type-check step includes the new compile-time assertions.
• Strict emitted-declaration consumer passes TypeScript 4.5.5 (CommonJS), 4.9 (CommonJS/ESM), and 6 (CommonJS/ESM), all with skipLibCheck: false. TypeScript 4.9 also checks distributed source.
• Built CJS/ESM factory checks pass on Node 22.0.0, 24.20.0, and 26.7.0: 12 cases per runtime covering missing/sync/async callbacks, parser and callback identity, frozen definitions, non-enumerable metadata, and unchanged JSON serialization.
• Compared both factories' emitted CJS/ESM code with main using the pinned compilers to normalize comments/formatting; runtime code is unchanged.

Adversarial self-review and scope

Reviewed the complete return-type invariant in both factories, not just the initially failing property access. Verified callback presence is determined by the actual callback argument rather than unrelated parser-output properties or a possibly inaccurate metadata declaration. Covered parse-only and optional tools in both runner modes, sync/async callbacks, metadata without a function field, string/array/nested parser outputs, and incompatible callback argument types. Rechecked the final diff after validation.

This is a types-only change in handwritten code. No runtime parser, schema conversion, request serialization, generated file, dependency, custom-code budget, or runtime policy changes. All three paths are absent from the pinned generated snapshot. Open-PR checks found no overlap; #2517 changes the Zod convenience helper, not these custom factories.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-31T01:07:13.744029Z	801ec5f	PR opened
🔒 Security Review	✅ Completed 2026-08-31T01:07:37.468735Z	801ec5f	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared eea2292a4a52 → 801ec5f24ab8. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33346525972 --repo openai/openai-node \
  --name castiron-custom-code-33346525972-1 --dir /tmp/castiron-custom-code-33346525972-1
git apply --stat /tmp/castiron-custom-code-33346525972-1/custom-code.patch
cat /tmp/castiron-custom-code-33346525972-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin eea2292a4a523da9405161dde0a79ac5dc2ecb2a 801ec5f24ab80efa938fb69a60ecae8d49ce9867
python3 scripts/castiron/custom_code_report.py report \
  --base eea2292a4a523da9405161dde0a79ac5dc2ecb2a \
  --head 801ec5f24ab80efa938fb69a60ecae8d49ce9867 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-801ec5f24ab8
cat /tmp/castiron-custom-code-801ec5f24ab8/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 10.34s for Node SDK PR #2526.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	160ms
tests/chat-completions-create.test.ts	✅ Passed	207ms
tests/chat-completions-stream.test.ts	✅ Passed	219ms
tests/files-content-binary.test.ts	✅ Passed	170ms
tests/files-create-multipart.test.ts	✅ Passed	129ms
tests/files-list-pagination.test.ts	✅ Passed	140ms
tests/initialize-config.test.ts	✅ Passed	151ms
tests/instance-isolation.test.ts	✅ Passed	118ms
tests/models-list.test.ts	✅ Passed	152ms
tests/responses-background-lifecycle.test.ts	✅ Passed	226ms
tests/responses-body-method-errors.test.ts	✅ Passed	345ms
tests/responses-cancel-timeout.test.ts	✅ Passed	194ms
tests/responses-cancel.test.ts	✅ Passed	254ms
tests/responses-compact-retries.test.ts	✅ Passed	277ms
tests/responses-compact.test.ts	✅ Passed	283ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	135ms
tests/responses-create-advanced.test.ts	✅ Passed	217ms
tests/responses-create-disconnect.test.ts	✅ Passed	998ms
tests/responses-create-errors.test.ts	✅ Passed	194ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	194ms
tests/responses-create-retries.test.ts	✅ Passed	302ms
tests/responses-create-stream-failures.test.ts	✅ Passed	213ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.156s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.478s
tests/responses-create-stream.test.ts	✅ Passed	81ms
tests/responses-create-terminal-states.test.ts	✅ Passed	205ms
tests/responses-create-timeout.test.ts	✅ Passed	207ms
tests/responses-create.test.ts	✅ Passed	213ms
tests/responses-delete.test.ts	✅ Passed	195ms
tests/responses-input-items-errors.test.ts	✅ Passed	177ms
tests/responses-input-items-list.test.ts	✅ Passed	194ms
tests/responses-input-items-options.test.ts	✅ Passed	112ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	252ms
tests/responses-input-tokens-count.test.ts	✅ Passed	240ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.145s
tests/responses-not-found-errors.test.ts	✅ Passed	220ms
tests/responses-parse.test.ts	✅ Passed	243ms
tests/responses-retrieve-retries.test.ts	✅ Passed	258ms
tests/responses-retrieve.test.ts	✅ Passed	270ms
tests/responses-stored-method-errors.test.ts	✅ Passed	583ms
tests/retry-behavior.test.ts	✅ Passed	3.009s
tests/sdk-error-shape.test.ts	✅ Passed	270ms

View OkTest run #33346511460

_{SDK merge (4f235122837f) · head (801ec5f24ab8) · base (eea2292a4a52) · OkTest (2b1bdfd25e98)}

[jbeckwith-oai]

Reviewed the exact head. The factory overloads correctly preserve the full metadata type, derive runnable status from the supplied callback, and keep callback argument types aligned with parser output. Focused type tests and tsc --noEmit pass.