[HAYDEN-OAI]

Summary

Interrupt pending upstream reads when a converted response stream is canceled, and release canceled tee branches without stopping live siblings.

The changes below are present in the public PR head:

• Capture the iterator's return hook once and preserve its receiver and cleanup errors. Abort a request-owning controller before awaiting that hook.
• Mark a canceled tee branch inactive, clear its queued results, and stop accepting later sibling-driven results.
• Propagate cleanup only after both branches close, including nested tees.
• Add public regressions for pending SSE/NDJSON reads, sibling isolation, nested cancellation, immediate backlog release, and no queue reaccumulation through 4,096 sibling reads.

Only one handwritten source file and two handwritten test files change. No generated code, exported signatures, dependencies, parsing rules, or payload limits change.

Cancellation boundaries

The JSDoc explicitly preserves already-issued shared next() promises, which may still deliver events. Closing both unstarted Stream.fromReadableStream() branches does not cancel the supplied readable; callers must cancel that readable directly. These inherited limitations are documented, not claimed as repaired here.

Public CI results

For head 41bdcb89:

• Push CI passes on Node 22, 24, and 26: 7,021 handwritten tests, 556 generated tests, and 12 snapshots per runtime. Build, lint/types, packed-package checks, and the Node 22.0.0 floor check also pass.
• All 14 ecosystem projects pass on the head and in merge CI, including Deno and Bun.
• CodeQL, the Castiron checks, and OkTest's 237 tests pass.

The automated Codex summary currently identifies runtime commit 303ff76c, not the documentation-only follow-up 41bdcb89; no new-head automated or human approval is claimed.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 11.142s for Node SDK PR #2556.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	243ms
tests/chat-completions-create.test.ts	✅ Passed	283ms
tests/chat-completions-stream.test.ts	✅ Passed	248ms
tests/files-content-binary.test.ts	✅ Passed	143ms
tests/files-create-multipart.test.ts	✅ Passed	135ms
tests/files-list-pagination.test.ts	✅ Passed	159ms
tests/initialize-config.test.ts	✅ Passed	191ms
tests/instance-isolation.test.ts	✅ Passed	99ms
tests/models-list.test.ts	✅ Passed	137ms
tests/responses-background-lifecycle.test.ts	✅ Passed	280ms
tests/responses-body-method-errors.test.ts	✅ Passed	418ms
tests/responses-cancel-timeout.test.ts	✅ Passed	241ms
tests/responses-cancel.test.ts	✅ Passed	291ms
tests/responses-compact-retries.test.ts	✅ Passed	343ms
tests/responses-compact.test.ts	✅ Passed	293ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	168ms
tests/responses-create-advanced.test.ts	✅ Passed	288ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.138s
tests/responses-create-errors.test.ts	✅ Passed	306ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	136ms
tests/responses-create-retries.test.ts	✅ Passed	289ms
tests/responses-create-stream-failures.test.ts	✅ Passed	181ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.161s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.561s
tests/responses-create-stream.test.ts	✅ Passed	98ms
tests/responses-create-terminal-states.test.ts	✅ Passed	255ms
tests/responses-create-timeout.test.ts	✅ Passed	262ms
tests/responses-create.test.ts	✅ Passed	128ms
tests/responses-delete.test.ts	✅ Passed	208ms
tests/responses-input-items-errors.test.ts	✅ Passed	260ms
tests/responses-input-items-list.test.ts	✅ Passed	182ms
tests/responses-input-items-options.test.ts	✅ Passed	136ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	287ms
tests/responses-input-tokens-count.test.ts	✅ Passed	270ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.145s
tests/responses-not-found-errors.test.ts	✅ Passed	340ms
tests/responses-parse.test.ts	✅ Passed	264ms
tests/responses-retrieve-retries.test.ts	✅ Passed	316ms
tests/responses-retrieve.test.ts	✅ Passed	315ms
tests/responses-stored-method-errors.test.ts	✅ Passed	710ms
tests/retry-behavior.test.ts	✅ Passed	2.896s
tests/sdk-error-shape.test.ts	✅ Passed	383ms

View OkTest run #33660063409

_{SDK merge (0293098313c4) · head (41bdcb89b435) · base (15dc890326c5) · OkTest (2b1bdfd25e98)}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-02T17:07:10.528995Z	303ff76	New commits
🔒 Security Review	✅ Completed 2026-09-02T17:08:52.513125Z	303ff76	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared eea2292a4a52 → 41bdcb89b435. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33661454865 --repo openai/openai-node \
  --name castiron-custom-code-33661454865-1 --dir /tmp/castiron-custom-code-33661454865-1
git apply --stat /tmp/castiron-custom-code-33661454865-1/custom-code.patch
cat /tmp/castiron-custom-code-33661454865-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 15dc890326c5156bb49ea7292aa47e718d628d59 41bdcb89b435d71d2c0a08002c04f3f71ab94b3d
python3 scripts/castiron/custom_code_report.py report \
  --base 15dc890326c5156bb49ea7292aa47e718d628d59 \
  --head 41bdcb89b435d71d2c0a08002c04f3f71ab94b3d --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-41bdcb89b435
cat /tmp/castiron-custom-code-41bdcb89b435/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04f50366fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[HAYDEN-OAI]

Addressed the single-read cleanup finding in 0b676ef. Cancellation captures return once, then invokes it with the iterator receiver through Reflect.apply; tee/no-return behavior is unchanged.

The new public Stream regression failed on Node 22, 24, and 26 because the getter was read twice (before). The exact updated commit passes all 7,016 handwritten tests, 556 generated tests, 12 snapshots, lint/types, build, packed-package checks, and ecosystem tests (after).

[sylvesterkaczmarek]

Canceling a toReadableStream() made from a tee branch does nothing because the tee iterator has no return(). The sibling keeps running, but tee() continues enqueueing every result into the canceled branch's queue, so that queue grows without bound. Mark the branch inactive/drop its queue on cancel without aborting the shared controller, and add a long-running sibling regression.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 303ff76cd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[HAYDEN-OAI]

The tee-cancellation finding is addressed in current head 303ff76: canceled branches clear their backlog and stop accepting sibling-driven results; plain and nested tees preserve live siblings, and the final branch closes the source once. The branch advanced to this commit during this verification pass, so no additional commit was needed.

Verified independently: a clean archive of 0b676ef retained 9,999 of 10,000 consumed synthetic events; the built candidate retained zero in CJS/plain and ESM/nested cases while the sibling continued. All 75 focused tests passed on Node 22.0.0, 24.20.0 and 26.7.0; all 7,021 handwritten tests were covered by passing runs after correcting local proxy/pnpm setup, and 556 generated tests plus 12 snapshots passed. Typechecking, canonical lint and build passed. Hosted CI for 303ff76 is being checked separately.

[HAYDEN-OAI]

Addressed the tee-retention review in 303ff76c: canceled branches immediately clear their backlog and stop enqueueing sibling-driven results, including nested tees. Final-branch cleanup propagates to the source without aborting live siblings.

The new regressions verify immediate backlog release, no reaccumulation through 4,096 sibling reads, and public Responses API cancellation with 2,048 subsequent events. The built-package 10,000-event reproduction now retains zero canceled-branch payloads versus 9,999 previously. Implementation CI passed all three Node suites and all 14 ecosystem projects; merge validation and OkTest also passed.

41bdcb89 adds only the reviewed lifecycle-boundary clarification discussed in the two newer inline threads. Its emitted runtime code is unchanged, all 75 focused tests/type checking/lint pass, and its fresh CI is running. The broader inherited unstarted-source limitation is not claimed as fixed.