[HAYDEN-OAI]

Summary

Fix request cancellation while Bedrock AWS credential resolution or SigV4 signing is still pending. Previously, client.models.list({ signal }) kept waiting after abort until the credential provider settled; a later provider rejection could replace the earlier cancellation with a credential error. This reproduces on both Mantle and Runtime.

Reuse the existing Bedrock bearer cancellation implementation as one shared authentication-operation helper:

• Observe both the caller signal and a finalized signal supplied by the protected request hook.
• Preserve the winning cancellation reason and existing credential-error wrapping.
• Apply bearer credentials or signed headers synchronously after the final cancellation checks.
• Continue observing late operation results without applying them or sending the cancelled request.

Cancellation settles the SDK request; it does not cancel arbitrary credential-provider or signing work. No new timeout, cache, listener framework, dependency, endpoint, or public credential-provider contract is introduced. Existing validation order, per-attempt credential refresh, successful signing, and optional AWS dependency isolation are preserved.

Only three wholly handwritten files change. All are absent from the verified Castiron generated snapshot 0669a894; no generated or mixed files change. The root and both Bedrock provider CJS/ESM type declarations remain byte-identical.

Validation

• Before: 18 new public SigV4 cancellation regressions failed; 71 existing controls passed.
• After: 796 related tests passed on Node 22.22.2 and 24.19.0, covering cancellation, signing fixtures, retries, endpoint routing, credential privacy, query handling, legacy providers, and optional-dependency isolation.
• 132 independent built-public checks passed across CJS/ESM on Node 22.0.0, 24.19.0, and 26.7.0. The same built entrypoints reproduced 24 expected cancellation hangs before the fix.
• Checked pre-abort, original/replaced signals, late resolve/reject, unchanged cancelled-request headers, no late fetch/unhandled rejection, concurrent isolation, recovery, and retry credential refresh.
• Whole-project TypeScript, canonical ./scripts/build, pinned Oxfmt 0.62.0, cached Oxlint 1.76.0, and git diff --check passed.
• Full handwritten suite: 7,486 passed, 1 failed. The sole failure is the existing tests/oxlint-config.test.ts:464 formatter fixture, reproduced identically on a clean 41f85bde baseline. Available cached Vitest is 4.1.10 rather than pinned 4.1.11, and Oxlint is 1.76.0 rather than pinned 1.79.0. Fresh frozen installation remains blocked by missing qs@6.16.0 publication-time metadata in the configured registry; no dependency safeguards, configuration, or lockfiles were changed.

Adversarial self-review

Reviewed signal-error provenance versus provider-originated abort errors, first-cause priority, listener cleanup, late settlement, synchronous header application, request isolation, validation precedence, credential privacy, and CJS/ESM/minimum-runtime compatibility. Two independent final reviews found no actionable issues. The implementation reuses the existing tested owner and stays limited to this cancellation boundary.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-04T17:50:53.311902Z	58fdf61	PR opened
🔒 Security Review	✅ Completed 2026-09-04T17:51:36.644313Z	58fdf61	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[openai-sdks]

OkTest Summary

✅ 237/237 SDK tests passed in 10.133s for Node SDK PR #2610.

Test results — 42 files

Test	Result	Time
tests/chat-completions-complex-body.test.ts	✅ Passed	176ms
tests/chat-completions-create.test.ts	✅ Passed	263ms
tests/chat-completions-stream.test.ts	✅ Passed	141ms
tests/files-content-binary.test.ts	✅ Passed	156ms
tests/files-create-multipart.test.ts	✅ Passed	150ms
tests/files-list-pagination.test.ts	✅ Passed	144ms
tests/initialize-config.test.ts	✅ Passed	158ms
tests/instance-isolation.test.ts	✅ Passed	98ms
tests/models-list.test.ts	✅ Passed	130ms
tests/responses-background-lifecycle.test.ts	✅ Passed	218ms
tests/responses-body-method-errors.test.ts	✅ Passed	295ms
tests/responses-cancel-timeout.test.ts	✅ Passed	221ms
tests/responses-cancel.test.ts	✅ Passed	237ms
tests/responses-compact-retries.test.ts	✅ Passed	230ms
tests/responses-compact.test.ts	✅ Passed	220ms
tests/responses-create-advanced-stream.test.ts	✅ Passed	117ms
tests/responses-create-advanced.test.ts	✅ Passed	202ms
tests/responses-create-disconnect.test.ts	✅ Passed	1.133s
tests/responses-create-errors.test.ts	✅ Passed	193ms
tests/responses-create-malformed-api-responses.test.ts	✅ Passed	122ms
tests/responses-create-retries.test.ts	✅ Passed	242ms
tests/responses-create-stream-failures.test.ts	✅ Passed	219ms
tests/responses-create-stream-timeout.test.ts	✅ Passed	2.155s
tests/responses-create-stream-wire.test.ts	✅ Passed	2.406s
tests/responses-create-stream.test.ts	✅ Passed	93ms
tests/responses-create-terminal-states.test.ts	✅ Passed	220ms
tests/responses-create-timeout.test.ts	✅ Passed	235ms
tests/responses-create.test.ts	✅ Passed	180ms
tests/responses-delete.test.ts	✅ Passed	189ms
tests/responses-input-items-errors.test.ts	✅ Passed	165ms
tests/responses-input-items-list.test.ts	✅ Passed	178ms
tests/responses-input-items-options.test.ts	✅ Passed	109ms
tests/responses-input-tokens-count-timeout.test.ts	✅ Passed	248ms
tests/responses-input-tokens-count.test.ts	✅ Passed	239ms
tests/responses-malformed-inputs.test.ts	✅ Passed	2.133s
tests/responses-not-found-errors.test.ts	✅ Passed	246ms
tests/responses-parse.test.ts	✅ Passed	179ms
tests/responses-retrieve-retries.test.ts	✅ Passed	265ms
tests/responses-retrieve.test.ts	✅ Passed	217ms
tests/responses-stored-method-errors.test.ts	✅ Passed	590ms
tests/retry-behavior.test.ts	✅ Passed	3.017s
tests/sdk-error-shape.test.ts	✅ Passed	267ms

View OkTest run #33902545167

_{SDK merge (c5f7d29d831a) · head (58fdf6123fd6) · base (41f85bde828c) · OkTest (2b1bdfd25e98)}

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 41f85bde828c → 58fdf6123fd6. Generated baselines verified.

32 existing customizations unchanged

• api.md
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py
• src/client.ts
• src/resources/audio/transcriptions.ts
• src/resources/audio/translations.ts
• src/resources/beta/assistants.ts
• src/resources/beta/beta.ts
• src/resources/beta/index.ts
• src/resources/beta/responses/internal-base.ts
• src/resources/beta/responses/responses.ts
• src/resources/beta/threads/index.ts
• src/resources/beta/threads/runs/index.ts
• src/resources/beta/threads/runs/runs.ts
• src/resources/beta/threads/threads.ts
• src/resources/chat/completions/completions.ts
• src/resources/chat/completions/index.ts
• src/resources/conversations/index.ts
• src/resources/embeddings.ts
• src/resources/files.ts
• src/resources/fine-tuning/checkpoints/permissions.ts
• src/resources/images.ts
• src/resources/responses/internal-base.ts
• src/resources/responses/responses.ts
• src/resources/skills/skills.ts
• src/resources/skills/versions/versions.ts
• src/resources/vector-stores/file-batches.ts
• src/resources/vector-stores/files.ts
• src/resources/webhooks/index.ts
• src/resources/webhooks/webhooks.ts
• tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33902579168 --repo openai/openai-node \
  --name castiron-custom-code-33902579168-1 --dir /tmp/castiron-custom-code-33902579168-1
git apply --stat /tmp/castiron-custom-code-33902579168-1/custom-code.patch
cat /tmp/castiron-custom-code-33902579168-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 41f85bde828cca667697c044004a21da5c2fe6a6 58fdf6123fd6a2c7339ca3087d607f1c9a71c8ba
python3 scripts/castiron/custom_code_report.py report \
  --base 41f85bde828cca667697c044004a21da5c2fe6a6 \
  --head 58fdf6123fd6a2c7339ca3087d607f1c9a71c8ba --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-58fdf6123fd6
cat /tmp/castiron-custom-code-58fdf6123fd6/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[jbeckwith-oai]

Reviewed exact head 58fdf61, including the authentication and cancellation security boundary. The shared helper preserves the first caller/finalized-signal cancellation, cleans up listeners, observes late signer/provider settlement, keeps provider failures wrapped, and applies signed or bearer headers only after final synchronous cancellation checks. Focused regressions cover both endpoints, late resolve/reject, retry refresh, signal replacement, request immutability, and recovery. No blocking issues found; current completed CI and automated security review are green.

[markstuart-oai]

Reviewed the full change at 58fdf61. The shared authentication helper preserves cancellation ownership and credential-error wrapping, observes late settlement, and applies authentication only after the final synchronous cancellation checks. No actionable correctness or maintainability issues found.

Verified the exact-head CI logs: the 89 cancellation tests and related signing, retry, and dependency-isolation suites passed on Node 22 and 24, along with the CJS/ESM build and packed-package checks. Local frozen installation stopped before tests because registry metadata for qs@6.16.0 was unavailable; dependency safeguards were preserved.

[sylvesterkaczmarek]

Generalising the existing bearer cancellation bridge into one authentication-operation owner is the right shape. The critical ordering is preserved: resolve/sign asynchronously, re-check both caller and finalized signals, remove listeners, and only then mutate request headers/redirect state synchronously. Observing late provider/signing settlement after cancellation also prevents unhandled rejections without allowing stale authentication work to leak into a later fetch. The SigV4 retry and late-settlement regressions cover the high-risk paths.